From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Matthew Garrett <mjg@redhat.com>,
Rezwanul Kabir <Rezwanul_Kabir@dell.com>,
Alex Hung <alex.hung@canonical.com>,
Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: Dell Vostro V131 hotkeys revisited
Date: Fri, 3 Jul 2015 15:32:27 +0200 [thread overview]
Message-ID: <20150703133227.GM1841@pali> (raw)
In-Reply-To: <20150703132341.GA3129@eudyptula.hq.kempniu.pl>
On Friday 03 July 2015 15:23:41 Michał Kępień wrote:
> > I would like to wait for documentation and not to invent/mess something
> > again and more.
>
> I get your point, but even getting our hands on the docs would most
> likely do nothing for the fact that hotkey behavior differs between
> models.
>
> > Creating big list with DMI names and associate hooks for
> > them based on "our" observation is good way to hell!
>
> Obviously it's not an elegant solution. Obviously using WMI for
> something as simple as handling a keypress is insane. Yet, this is the
> way vendors (at least some of them) chose. I guess the decision to be
> made is whether to try to support it anyway or accept the fact that
> arbitrary hardware will not be fully functional, even though we know
> exactly why.
>
> Of course that's not my call to make and I respect your decision. Just
> putting my two cents in as I despise the idea of letting the vendor
> decide which features of the hardware I bought from them I can use and
> which ones I can't.
>
> > We even do not know:
> >
> > 1) how to activate code for receiving events
>
> Oh, but we do! At least for some models ;) We just don't know _why_ it
> should be done the way it is done. It sure would be nice to know that,
> but should it stop us from implementing a working solution?
>
> > 2) what is format of which event
>
> Well, dell-wmi.ko seems to be decoding the events pretty well. And
> again, the format differs between models (and is probably subject to
> change in yet to be released hardware) and we can't really do a thing
> about it. We can either support it or not.
>
> > 3) which keypress should be reported by i8042 bus and which via ACPI/WMI
>
> That depends on the model ;)
>
There are two different things:
1) Vendor said that laptop models with specific DMI should be handled by
code XYZ...
2) Vendor said that all laptop models which report in register ABC value
47 should be handled by code XYZ.
And we are thing to fix above facts with solution:
3) See how one model reacts and from this information create specific
hook for that one model.
I'm really against solution 3) if we already know that every model uses
different event handling.
If for model Dell Vostro V131 vendor say 1) I'm fine with solution to
hardcode DMI name and hook for it. 2) is of course better, but 3) for
lot of machines is non go.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2015-07-03 13:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 11:26 Dell Vostro V131 hotkeys revisited Michał Kępień
2015-06-23 11:46 ` Pali Rohár
2015-06-23 19:40 ` Michał Kępień
2015-06-23 19:47 ` Pali Rohár
2015-06-24 11:18 ` Michał Kępień
2015-06-24 13:23 ` Pali Rohár
2015-06-25 9:02 ` Michał Kępień
2015-06-27 18:50 ` Pali Rohár
2015-06-30 7:38 ` Michał Kępień
2015-06-30 8:00 ` Pali Rohár
2015-07-01 8:32 ` Michał Kępień
2015-07-01 8:40 ` Pali Rohár
2015-07-01 10:11 ` Michał Kępień
2015-07-01 10:55 ` Pali Rohár
2015-07-02 20:41 ` Michał Kępień
2015-07-02 20:58 ` Pali Rohár
2015-07-03 6:52 ` Michał Kępień
2015-07-03 7:48 ` Pali Rohár
2015-07-03 11:26 ` Michał Kępień
2015-07-03 11:43 ` Pali Rohár
2015-07-03 13:23 ` Michał Kępień
2015-07-03 13:32 ` Pali Rohár [this message]
2015-07-03 13:50 ` Michał Kępień
2015-07-03 14:09 ` Pali Rohár
2015-07-03 14:14 ` Pali Rohár
2015-07-03 18:22 ` Gabriele Mazzotta
2015-07-03 20:07 ` Michał Kępień
2015-07-03 20:30 ` Gabriele Mazzotta
2015-07-04 19:41 ` Pali Rohár
2015-07-04 20:34 ` Gabriele Mazzotta
2015-07-03 20:55 ` Michał Kępień
2015-07-04 19:13 ` Pali Rohár
2015-07-04 19:47 ` Pali Rohár
2015-07-27 19:27 ` Michał Kępień
2015-07-07 18:36 ` Mario Limonciello
2015-07-07 21:01 ` Pali Rohár
2015-07-08 3:21 ` Michał Kępień
2015-07-08 3:53 ` Michał Kępień
2015-07-22 7:35 ` Michał Kępień
2015-08-31 9:51 ` Michał Kępień
2015-09-10 4:38 ` Darren Hart
2015-11-13 10:17 ` Michał Kępień
2015-12-07 11:43 ` Pali Rohár
2015-12-16 9:05 ` Michał Kępień
2015-12-16 9:30 ` Pali Rohár
2015-12-16 10:29 ` Hans de Goede
2015-12-17 8:05 ` Michał Kępień
2015-12-17 9:48 ` Hans de Goede
2015-12-17 18:47 ` Pali Rohár
2015-12-17 18:54 ` Hans de Goede
2015-12-19 0:02 ` Darren Hart
2015-12-19 9:59 ` Pali Rohár
2015-12-18 7:10 ` Michał Kępień
2015-12-18 10:44 ` Hans de Goede
2015-12-19 12:31 ` Michał Kępień
2015-07-04 21:24 ` Pali Rohár
2015-07-05 4:51 ` Michał Kępień
2015-06-23 12:18 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703133227.GM1841@pali \
--to=pali.rohar@gmail.com \
--cc=Rezwanul_Kabir@dell.com \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=kernel@kempniu.pl \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.