All of lore.kernel.org
 help / color / mirror / Atom feed
From: panand@redhat.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: Make all entry code as non-kprobe-able
Date: Mon, 6 Jul 2015 17:24:08 +0530	[thread overview]
Message-ID: <20150706115408.GC17305@dhcppc13.redhat.com> (raw)
In-Reply-To: <559A6075.5070502@hitachi.com>

On 06/07/2015:08:03:17 PM, Masami Hiramatsu wrote:
> On 2015/07/06 14:03, Pratyush Anand wrote:
> > Entry symbols are not kprobe safe. So blacklist them for kprobing.
> 
> As I've said, you can also use _ASM_NOKPROBE().

Thanks for this info.. May be we can use it if we find some single
discrete asm routines. Since here all the entry routines need to be
blacklisted, so may be this approach should be fine. This approach
have been emulated from x86 entry code blacklist.

> This patch itself looks good to me, but I'd like to ask arm64
> maintainers' opinion, whether they accept introducing entry-text
> section only for this purpose or not.
> 
> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks.

~Pratyush

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Anand <panand@redhat.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
	catalin.marinas@arm.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, wcohen@redhat.com,
	dave.long@linaro.org, steve.capper@linaro.org
Subject: Re: [PATCH 2/2] arm64: Make all entry code as non-kprobe-able
Date: Mon, 6 Jul 2015 17:24:08 +0530	[thread overview]
Message-ID: <20150706115408.GC17305@dhcppc13.redhat.com> (raw)
In-Reply-To: <559A6075.5070502@hitachi.com>

On 06/07/2015:08:03:17 PM, Masami Hiramatsu wrote:
> On 2015/07/06 14:03, Pratyush Anand wrote:
> > Entry symbols are not kprobe safe. So blacklist them for kprobing.
> 
> As I've said, you can also use _ASM_NOKPROBE().

Thanks for this info.. May be we can use it if we find some single
discrete asm routines. Since here all the entry routines need to be
blacklisted, so may be this approach should be fine. This approach
have been emulated from x86 entry code blacklist.

> This patch itself looks good to me, but I'd like to ask arm64
> maintainers' opinion, whether they accept introducing entry-text
> section only for this purpose or not.
> 
> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks.

~Pratyush

  reply	other threads:[~2015-07-06 11:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06  5:03 [PATCH 0/2] arm64: some symbols blacklisted for kprobing Pratyush Anand
2015-07-06  5:03 ` Pratyush Anand
2015-07-06  5:03 ` [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols Pratyush Anand
2015-07-06  5:03   ` Pratyush Anand
2015-07-06  9:03   ` Will Deacon
2015-07-06  9:03     ` Will Deacon
2015-07-06 10:48     ` Pratyush Anand
2015-07-06 10:48       ` Pratyush Anand
2015-07-06 11:56       ` Masami Hiramatsu
2015-07-06 11:56         ` Masami Hiramatsu
2015-07-06 11:37     ` Masami Hiramatsu
2015-07-06 11:37       ` Masami Hiramatsu
2015-07-06 14:42       ` William Cohen
2015-07-06 14:42         ` William Cohen
2015-07-06 11:11   ` Masami Hiramatsu
2015-07-06 11:11     ` Masami Hiramatsu
2015-07-06 11:49     ` Pratyush Anand
2015-07-06 11:49       ` Pratyush Anand
2015-07-09 13:53       ` Pratyush Anand
2015-07-09 13:53         ` Pratyush Anand
2015-07-06  5:03 ` [PATCH 2/2] arm64: Make all entry code as non-kprobe-able Pratyush Anand
2015-07-06  5:03   ` Pratyush Anand
2015-07-06 11:03   ` Masami Hiramatsu
2015-07-06 11:03     ` Masami Hiramatsu
2015-07-06 11:54     ` Pratyush Anand [this message]
2015-07-06 11:54       ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150706115408.GC17305@dhcppc13.redhat.com \
    --to=panand@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.