All of lore.kernel.org
 help / color / mirror / Atom feed
From: masami.hiramatsu.pt@hitachi.com (Masami Hiramatsu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols
Date: Mon, 06 Jul 2015 20:37:49 +0900	[thread overview]
Message-ID: <559A688D.1040501@hitachi.com> (raw)
In-Reply-To: <20150706090323.GB30342@arm.com>

On 2015/07/06 18:03, Will Deacon wrote:
> On Mon, Jul 06, 2015 at 06:03:21AM +0100, Pratyush Anand wrote:
>> Add all function symbols which are called from do_debug_exception under
>> NOKPROBE_SYMBOL, as they can not kprobed.
> 
> It's a shame this has to be so manual, but I suppose it's done on a
> best-effort basis to catch broken probe placement.

Ah, yes. You can use kprobe-tracer in ftrace by feeding all symbols to
them and enabling it (and pray).


> If we miss a function and somebody probes it, do we just get stuck in a
> recursive exception, or could we print something suggesting that a symbol
> be annotated as NOKPROBE?

For some cases we can detect recursion, but usually, it may reset
itself or infinite recursion loop before detecting it. :(

Thank you,

-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt at hitachi.com

WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Will Deacon <will.deacon@arm.com>, Pratyush Anand <panand@redhat.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"wcohen@redhat.com" <wcohen@redhat.com>,
	"dave.long@linaro.org" <dave.long@linaro.org>,
	"steve.capper@linaro.org" <steve.capper@linaro.org>
Subject: Re: [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols
Date: Mon, 06 Jul 2015 20:37:49 +0900	[thread overview]
Message-ID: <559A688D.1040501@hitachi.com> (raw)
In-Reply-To: <20150706090323.GB30342@arm.com>

On 2015/07/06 18:03, Will Deacon wrote:
> On Mon, Jul 06, 2015 at 06:03:21AM +0100, Pratyush Anand wrote:
>> Add all function symbols which are called from do_debug_exception under
>> NOKPROBE_SYMBOL, as they can not kprobed.
> 
> It's a shame this has to be so manual, but I suppose it's done on a
> best-effort basis to catch broken probe placement.

Ah, yes. You can use kprobe-tracer in ftrace by feeding all symbols to
them and enabling it (and pray).


> If we miss a function and somebody probes it, do we just get stuck in a
> recursive exception, or could we print something suggesting that a symbol
> be annotated as NOKPROBE?

For some cases we can detect recursion, but usually, it may reset
itself or infinite recursion loop before detecting it. :(

Thank you,

-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com

  parent reply	other threads:[~2015-07-06 11:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06  5:03 [PATCH 0/2] arm64: some symbols blacklisted for kprobing Pratyush Anand
2015-07-06  5:03 ` Pratyush Anand
2015-07-06  5:03 ` [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols Pratyush Anand
2015-07-06  5:03   ` Pratyush Anand
2015-07-06  9:03   ` Will Deacon
2015-07-06  9:03     ` Will Deacon
2015-07-06 10:48     ` Pratyush Anand
2015-07-06 10:48       ` Pratyush Anand
2015-07-06 11:56       ` Masami Hiramatsu
2015-07-06 11:56         ` Masami Hiramatsu
2015-07-06 11:37     ` Masami Hiramatsu [this message]
2015-07-06 11:37       ` Masami Hiramatsu
2015-07-06 14:42       ` William Cohen
2015-07-06 14:42         ` William Cohen
2015-07-06 11:11   ` Masami Hiramatsu
2015-07-06 11:11     ` Masami Hiramatsu
2015-07-06 11:49     ` Pratyush Anand
2015-07-06 11:49       ` Pratyush Anand
2015-07-09 13:53       ` Pratyush Anand
2015-07-09 13:53         ` Pratyush Anand
2015-07-06  5:03 ` [PATCH 2/2] arm64: Make all entry code as non-kprobe-able Pratyush Anand
2015-07-06  5:03   ` Pratyush Anand
2015-07-06 11:03   ` Masami Hiramatsu
2015-07-06 11:03     ` Masami Hiramatsu
2015-07-06 11:54     ` Pratyush Anand
2015-07-06 11:54       ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559A688D.1040501@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.