From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage
Date: Tue, 7 Jul 2015 14:31:55 +0100 [thread overview]
Message-ID: <20150707133155.GL2887@sirena.org.uk> (raw)
In-Reply-To: <1436173112-21397-9-git-send-email-lee.jones@linaro.org>
On Mon, Jul 06, 2015 at 09:58:30AM +0100, Lee Jones wrote:
> + tmp = max_duty_cycle - min_mV * max_duty_cycle / vdiff;
> + pwm_code = tmp + max_duty_cycle * volt_mV / vdiff;
These need some brackets to be clear that they're correct.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150707/a928d034/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
lgirdwood@gmail.com
Subject: Re: [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage
Date: Tue, 7 Jul 2015 14:31:55 +0100 [thread overview]
Message-ID: <20150707133155.GL2887@sirena.org.uk> (raw)
In-Reply-To: <1436173112-21397-9-git-send-email-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
On Mon, Jul 06, 2015 at 09:58:30AM +0100, Lee Jones wrote:
> + tmp = max_duty_cycle - min_mV * max_duty_cycle / vdiff;
> + pwm_code = tmp + max_duty_cycle * volt_mV / vdiff;
These need some brackets to be clear that they're correct.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-07 13:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 8:58 [RESEND 00/10] regulator: pwm-regulator: Introduce continuous-mode Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 01/10] ARM: multi_v7_defconfig: Enable ST's PWM driver Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 02/10] ARM: multi_v7_defconfig: Enable ST's Power Reset driver Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 03/10] ARM: multi_v7_defconfig: Enable support for PWM Regulators Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 04/10] ARM: STi: STiH407: Move PWM nodes STiH407 => STiH407-family Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 05/10] ARM: STi: STiH407: Add PWM Regulator node Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 06/10] dt: regulator: pwm-regulator: Re-write bindings Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-07 13:38 ` Mark Brown
2015-07-07 13:38 ` Mark Brown
2015-07-06 8:58 ` [RESEND 07/10] regulator: pwm-regulator: Separate voltage-table initialisation Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 8:58 ` [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-07 13:31 ` Mark Brown [this message]
2015-07-07 13:31 ` Mark Brown
2015-07-07 13:45 ` Lee Jones
2015-07-07 13:45 ` Lee Jones
2015-07-07 13:53 ` Mark Brown
2015-07-07 13:53 ` Mark Brown
2015-07-06 8:58 ` [RESEND 09/10] regulator: pwm-regulator: Simplify voltage to duty-cycle call Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-07 13:32 ` Mark Brown
2015-07-07 13:32 ` Mark Brown
2015-07-07 13:45 ` Lee Jones
2015-07-07 13:45 ` Lee Jones
2015-07-07 13:52 ` Mark Brown
2015-07-07 13:52 ` Mark Brown
2015-07-07 14:29 ` Lee Jones
2015-07-07 14:29 ` Lee Jones
2015-07-06 8:58 ` [RESEND 10/10] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones
2015-07-06 8:58 ` Lee Jones
2015-07-06 20:48 ` [RESEND 00/10] regulator: pwm-regulator: Introduce continuous-mode Mark Brown
2015-07-06 20:48 ` Mark Brown
2015-07-07 6:52 ` Lee Jones
2015-07-07 6:52 ` Lee Jones
2015-07-07 12:03 ` Mark Brown
2015-07-07 12:03 ` Mark Brown
2015-07-07 12:52 ` Lee Jones
2015-07-07 12:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707133155.GL2887@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.