All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND 09/10] regulator: pwm-regulator: Simplify voltage to duty-cycle call
Date: Tue, 7 Jul 2015 14:45:03 +0100	[thread overview]
Message-ID: <20150707134503.GG3182@x1> (raw)
In-Reply-To: <20150707133245.GM2887@sirena.org.uk>

On Tue, 07 Jul 2015, Mark Brown wrote:

> On Mon, Jul 06, 2015 at 09:58:31AM +0100, Lee Jones wrote:
> > If we reverse some of the logic and change the formula used,
> > we can simplify the function greatly.
> 
> > +static int pwm_voltage_to_duty_cycle(struct regulator_dev *rdev, int req_uV)
> >  {
> > -	struct pwm_regulator_data *drvdata = rdev_get_drvdata(rdev);
> 
> You just added this function in the previous patch?

You're right, it does look a little weird contained in a single
patch-set.  The submission in the previous patch is the tried and
tested (i.e. in real releases) method written by ST.  This patch
contains a simplification provided by me.  IMO it looks and performs
better, but doesn't have the same time-under-test that the original
method does.  I'm merely ensuring we keep some history in order so
provide and easy way back i.e. revert.

If I have any say at all, I'd really like to keep this piece of
history.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	lgirdwood@gmail.com
Subject: Re: [RESEND 09/10] regulator: pwm-regulator: Simplify voltage to duty-cycle call
Date: Tue, 7 Jul 2015 14:45:03 +0100	[thread overview]
Message-ID: <20150707134503.GG3182@x1> (raw)
In-Reply-To: <20150707133245.GM2887@sirena.org.uk>

On Tue, 07 Jul 2015, Mark Brown wrote:

> On Mon, Jul 06, 2015 at 09:58:31AM +0100, Lee Jones wrote:
> > If we reverse some of the logic and change the formula used,
> > we can simplify the function greatly.
> 
> > +static int pwm_voltage_to_duty_cycle(struct regulator_dev *rdev, int req_uV)
> >  {
> > -	struct pwm_regulator_data *drvdata = rdev_get_drvdata(rdev);
> 
> You just added this function in the previous patch?

You're right, it does look a little weird contained in a single
patch-set.  The submission in the previous patch is the tried and
tested (i.e. in real releases) method written by ST.  This patch
contains a simplification provided by me.  IMO it looks and performs
better, but doesn't have the same time-under-test that the original
method does.  I'm merely ensuring we keep some history in order so
provide and easy way back i.e. revert.

If I have any say at all, I'd really like to keep this piece of
history.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-07-07 13:45 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06  8:58 [RESEND 00/10] regulator: pwm-regulator: Introduce continuous-mode Lee Jones
2015-07-06  8:58 ` Lee Jones
2015-07-06  8:58 ` [RESEND 01/10] ARM: multi_v7_defconfig: Enable ST's PWM driver Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58 ` [RESEND 02/10] ARM: multi_v7_defconfig: Enable ST's Power Reset driver Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58 ` [RESEND 03/10] ARM: multi_v7_defconfig: Enable support for PWM Regulators Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58 ` [RESEND 04/10] ARM: STi: STiH407: Move PWM nodes STiH407 => STiH407-family Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58 ` [RESEND 05/10] ARM: STi: STiH407: Add PWM Regulator node Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58 ` [RESEND 06/10] dt: regulator: pwm-regulator: Re-write bindings Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-07 13:38   ` Mark Brown
2015-07-07 13:38     ` Mark Brown
2015-07-06  8:58 ` [RESEND 07/10] regulator: pwm-regulator: Separate voltage-table initialisation Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06  8:58 ` [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-07 13:31   ` Mark Brown
2015-07-07 13:31     ` Mark Brown
2015-07-07 13:45     ` Lee Jones
2015-07-07 13:45       ` Lee Jones
2015-07-07 13:53       ` Mark Brown
2015-07-07 13:53         ` Mark Brown
2015-07-06  8:58 ` [RESEND 09/10] regulator: pwm-regulator: Simplify voltage to duty-cycle call Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-07 13:32   ` Mark Brown
2015-07-07 13:32     ` Mark Brown
2015-07-07 13:45     ` Lee Jones [this message]
2015-07-07 13:45       ` Lee Jones
2015-07-07 13:52       ` Mark Brown
2015-07-07 13:52         ` Mark Brown
2015-07-07 14:29         ` Lee Jones
2015-07-07 14:29           ` Lee Jones
2015-07-06  8:58 ` [RESEND 10/10] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones
2015-07-06  8:58   ` Lee Jones
2015-07-06 20:48 ` [RESEND 00/10] regulator: pwm-regulator: Introduce continuous-mode Mark Brown
2015-07-06 20:48   ` Mark Brown
2015-07-07  6:52   ` Lee Jones
2015-07-07  6:52     ` Lee Jones
2015-07-07 12:03     ` Mark Brown
2015-07-07 12:03       ` Mark Brown
2015-07-07 12:52       ` Lee Jones
2015-07-07 12:52         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707134503.GG3182@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.