From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v6 6/7] zsmalloc: account the number of compacted pages
Date: Tue, 7 Jul 2015 23:21:09 +0900 [thread overview]
Message-ID: <20150707142109.GA1450@swordfish> (raw)
In-Reply-To: <20150707133916.GC3898@blaptop>
On (07/07/15 22:39), Minchan Kim wrote:
[..]
> > struct zs_pool_stats {
> > - /* How many objects were migrated */
> > - u64 num_migrated;
> > + /* How many pages were migrated (freed) */
> > + u64 pages_compacted;
>
> Hmm, if we account it as page unit, unsigned long is enough for 32bit.
Well, this is a 'how many pages were freed overall' counter. We don't
control the lifetime of device, so I think it can be bigger than 4 bytes
in some `extreme' cases.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v6 6/7] zsmalloc: account the number of compacted pages
Date: Tue, 7 Jul 2015 23:21:09 +0900 [thread overview]
Message-ID: <20150707142109.GA1450@swordfish> (raw)
In-Reply-To: <20150707133916.GC3898@blaptop>
On (07/07/15 22:39), Minchan Kim wrote:
[..]
> > struct zs_pool_stats {
> > - /* How many objects were migrated */
> > - u64 num_migrated;
> > + /* How many pages were migrated (freed) */
> > + u64 pages_compacted;
>
> Hmm, if we account it as page unit, unsigned long is enough for 32bit.
Well, this is a 'how many pages were freed overall' counter. We don't
control the lifetime of device, so I think it can be bigger than 4 bytes
in some `extreme' cases.
-ss
next prev parent reply other threads:[~2015-07-07 14:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 11:56 [PATCH v6 0/7] mm/zsmalloc: introduce automatic pool compaction Sergey Senozhatsky
2015-07-07 11:56 ` Sergey Senozhatsky
2015-07-07 11:56 ` [PATCH v6 1/7] zsmalloc: drop unused variable `nr_to_migrate' Sergey Senozhatsky
2015-07-07 11:56 ` Sergey Senozhatsky
2015-07-07 11:56 ` [PATCH v6 2/7] zsmalloc: always keep per-class stats Sergey Senozhatsky
2015-07-07 11:56 ` Sergey Senozhatsky
2015-07-07 11:56 ` [PATCH v6 3/7] zsmalloc: introduce zs_can_compact() function Sergey Senozhatsky
2015-07-07 11:56 ` Sergey Senozhatsky
2015-07-07 13:21 ` Minchan Kim
2015-07-07 13:21 ` Minchan Kim
2015-07-07 11:56 ` [PATCH v6 4/7] zsmalloc: cosmetic compaction code adjustments Sergey Senozhatsky
2015-07-07 11:56 ` Sergey Senozhatsky
2015-07-07 11:56 ` [PATCH v6 5/7] zsmalloc/zram: introduce zs_pool_stats api Sergey Senozhatsky
2015-07-07 11:56 ` Sergey Senozhatsky
2015-07-07 13:36 ` Minchan Kim
2015-07-07 13:36 ` Minchan Kim
2015-07-07 14:32 ` Sergey Senozhatsky
2015-07-07 14:32 ` Sergey Senozhatsky
2015-07-07 14:48 ` Minchan Kim
2015-07-07 14:48 ` Minchan Kim
2015-07-07 15:02 ` Sergey Senozhatsky
2015-07-07 15:02 ` Sergey Senozhatsky
2015-07-07 11:57 ` [PATCH v6 6/7] zsmalloc: account the number of compacted pages Sergey Senozhatsky
2015-07-07 11:57 ` Sergey Senozhatsky
2015-07-07 13:39 ` Minchan Kim
2015-07-07 13:39 ` Minchan Kim
2015-07-07 14:21 ` Sergey Senozhatsky [this message]
2015-07-07 14:21 ` Sergey Senozhatsky
2015-07-07 14:33 ` Minchan Kim
2015-07-07 14:33 ` Minchan Kim
2015-07-07 11:57 ` [PATCH v6 7/7] zsmalloc: use shrinker to trigger auto-compaction Sergey Senozhatsky
2015-07-07 11:57 ` Sergey Senozhatsky
2015-07-07 13:44 ` Minchan Kim
2015-07-07 13:44 ` Minchan Kim
2015-07-07 14:41 ` Sergey Senozhatsky
2015-07-07 14:41 ` Sergey Senozhatsky
2015-07-07 15:01 ` Minchan Kim
2015-07-07 15:01 ` Minchan Kim
2015-07-07 15:12 ` Sergey Senozhatsky
2015-07-07 15:12 ` Sergey Senozhatsky
2015-07-08 2:18 ` Sergey Senozhatsky
2015-07-08 2:18 ` Sergey Senozhatsky
2015-07-08 3:04 ` Minchan Kim
2015-07-08 3:04 ` Minchan Kim
2015-07-08 3:49 ` Sergey Senozhatsky
2015-07-08 3:49 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707142109.GA1450@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.