* musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-09 21:39 Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-10 19:50 ` Felipe Balbi
0 siblings, 2 replies; 14+ messages in thread
From: Pavel Machek @ 2015-07-09 21:39 UTC (permalink / raw)
To: Greg KH, balbi, bigeasy, george.cherian, tony, varkabhadram,
linux-kernel
Hi!
sysfs should contain one value per file. This one has at least two,
with nice english sentence as a bonus.
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
cat vbus
Vbus off, timeout 1100 msec
:-(.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-09 21:39 musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs Pavel Machek
2015-07-09 21:46 ` Pavel Machek
@ 2015-07-09 21:46 ` Pavel Machek
1 sibling, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2015-07-09 21:46 UTC (permalink / raw)
To: Greg KH, balbi, bigeasy, george.cherian, varkabhadram,
linux-kernel
Cc: pali.rohar, sre, sre, linux-arm-kernel, linux-omap, tony, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan
On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> Hi!
>
> sysfs should contain one value per file. This one has at least two,
> with nice english sentence as a bonus.
>
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> cat vbus
> Vbus off, timeout 1100 msec
>
> :-(.
Plus, documentation for this is nowhere to be seen:
pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
pavel@amd:/data/l/linux-n900$
..which is a shame, because it is not really clear how to use this
one:
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
cat mode
b_idle
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_suspend > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_host > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo b_host > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_idle > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo b_wait_acon > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-09 21:46 ` Pavel Machek
0 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2015-07-09 21:46 UTC (permalink / raw)
To: linux-arm-kernel
On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> Hi!
>
> sysfs should contain one value per file. This one has at least two,
> with nice english sentence as a bonus.
>
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> cat vbus
> Vbus off, timeout 1100 msec
>
> :-(.
Plus, documentation for this is nowhere to be seen:
pavel at amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
pavel at amd:/data/l/linux-n900$
..which is a shame, because it is not really clear how to use this
one:
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
cat mode
b_idle
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_suspend > mode
-bash: echo: write error: Invalid argument
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a > mode
-bash: echo: write error: Invalid argument
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_host > mode
-bash: echo: write error: Invalid argument
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo b_host > mode
-bash: echo: write error: Invalid argument
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_idle > mode
-bash: echo: write error: Invalid argument
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo b_wait_acon > mode
-bash: echo: write error: Invalid argument
root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-09 21:46 ` Pavel Machek
0 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2015-07-09 21:46 UTC (permalink / raw)
To: Greg KH, balbi, bigeasy, george.cherian, tony, varkabhadram,
linux-kernel
Cc: pali.rohar, sre, sre, linux-arm-kernel, linux-omap, tony, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan
On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> Hi!
>
> sysfs should contain one value per file. This one has at least two,
> with nice english sentence as a bonus.
>
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> cat vbus
> Vbus off, timeout 1100 msec
>
> :-(.
Plus, documentation for this is nowhere to be seen:
pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
pavel@amd:/data/l/linux-n900$
..which is a shame, because it is not really clear how to use this
one:
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
cat mode
b_idle
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_suspend > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_host > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo b_host > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo a_idle > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
echo b_wait_acon > mode
-bash: echo: write error: Invalid argument
root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-09 21:46 ` Pavel Machek
@ 2015-07-09 21:54 ` Pali Rohár
-1 siblings, 0 replies; 14+ messages in thread
From: Pali Rohár @ 2015-07-09 21:54 UTC (permalink / raw)
To: Pavel Machek
Cc: Greg KH, balbi, bigeasy, george.cherian, tony, varkabhadram,
linux-kernel, sre, sre, linux-arm-kernel, linux-omap, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan
[-- Attachment #1: Type: Text/Plain, Size: 2434 bytes --]
On Thursday 09 July 2015 23:46:10 Pavel Machek wrote:
> On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> > Hi!
> >
> > sysfs should contain one value per file. This one has at least two,
> > with nice english sentence as a bonus.
> >
> > root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/mu
> > sb-hdrc.0.auto# cat vbus
> > Vbus off, timeout 1100 msec
> >
> > :-(.
>
> Plus, documentation for this is nowhere to be seen:
>
> pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> pavel@amd:/data/l/linux-n900$
>
> ..which is a shame, because it is not really clear how to use this
> one:
>
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# cat mode
> b_idle
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a_suspend > mode
> -bash: echo: write error: Invalid argument
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a > mode
> -bash: echo: write error: Invalid argument
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a_host > mode
> -bash: echo: write error: Invalid argument
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo b_host > mode
> -bash: echo: write error: Invalid argument
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a_idle > mode
> -bash: echo: write error: Invalid argument
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo b_wait_acon > mode
> -bash: echo: write error: Invalid argument
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto#
>
>
> Pavel
Hi!
I remember that this file is used for switching between usb peripheral
and host mode. But because n900 HW somehow broken, for usb host mode are
needed couple of "hack" patches which workaround HW bugs... This is
still not enough and "support" from userspace is needed for it too.
Kernel patches are part of Maemo kernel-power 2.6.28 version and with
package usbmode http://maemo.org/packages/view/usbmode/ is it possible
to enter usb host mode on n900 (and then connect e.g. usb stick).
And IIRC correct command is:
# echo host > mode
# echo peripheral > mode
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-09 21:54 ` Pali Rohár
0 siblings, 0 replies; 14+ messages in thread
From: Pali Rohár @ 2015-07-09 21:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 09 July 2015 23:46:10 Pavel Machek wrote:
> On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> > Hi!
> >
> > sysfs should contain one value per file. This one has at least two,
> > with nice english sentence as a bonus.
> >
> > root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/mu
> > sb-hdrc.0.auto# cat vbus
> > Vbus off, timeout 1100 msec
> >
> > :-(.
>
> Plus, documentation for this is nowhere to be seen:
>
> pavel at amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> pavel at amd:/data/l/linux-n900$
>
> ..which is a shame, because it is not really clear how to use this
> one:
>
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# cat mode
> b_idle
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a_suspend > mode
> -bash: echo: write error: Invalid argument
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a > mode
> -bash: echo: write error: Invalid argument
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a_host > mode
> -bash: echo: write error: Invalid argument
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo b_host > mode
> -bash: echo: write error: Invalid argument
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo a_idle > mode
> -bash: echo: write error: Invalid argument
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto# echo b_wait_acon > mode
> -bash: echo: write error: Invalid argument
> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb
> -hdrc.0.auto#
>
>
> Pavel
Hi!
I remember that this file is used for switching between usb peripheral
and host mode. But because n900 HW somehow broken, for usb host mode are
needed couple of "hack" patches which workaround HW bugs... This is
still not enough and "support" from userspace is needed for it too.
Kernel patches are part of Maemo kernel-power 2.6.28 version and with
package usbmode http://maemo.org/packages/view/usbmode/ is it possible
to enter usb host mode on n900 (and then connect e.g. usb stick).
And IIRC correct command is:
# echo host > mode
# echo peripheral > mode
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150709/4145c2fd/attachment.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-09 21:46 ` Pavel Machek
@ 2015-07-10 7:17 ` Sebastian Andrzej Siewior
-1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Andrzej Siewior @ 2015-07-10 7:17 UTC (permalink / raw)
To: Pavel Machek, Greg KH, balbi, george.cherian, tony, varkabhadram,
linux-kernel
Cc: pali.rohar, sre, sre, linux-arm-kernel, linux-omap, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan
On 07/09/2015 11:46 PM, Pavel Machek wrote:
> On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
>> Hi!
Hi,
>>
>> sysfs should contain one value per file. This one has at least two,
>> with nice english sentence as a bonus.
>>
>> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
>> cat vbus
>> Vbus off, timeout 1100 msec
>>
>> :-(.
>
> Plus, documentation for this is nowhere to be seen:
>
> pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> pavel@amd:/data/l/linux-n900$
that is a shame indeed. It is part of the driver since TUSB support was
merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
years ago.
The parameter expects the timeout values which is used to poll the port
for mode changes (host/device mode) since it can not be detected on its
own.
Felipe knows best if it is better to document it or remove it. I can't
remember that I needed it on am335x.
> Pavel
>
Sebastian
^ permalink raw reply [flat|nested] 14+ messages in thread
* musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-10 7:17 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Andrzej Siewior @ 2015-07-10 7:17 UTC (permalink / raw)
To: linux-arm-kernel
On 07/09/2015 11:46 PM, Pavel Machek wrote:
> On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
>> Hi!
Hi,
>>
>> sysfs should contain one value per file. This one has at least two,
>> with nice english sentence as a bonus.
>>
>> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
>> cat vbus
>> Vbus off, timeout 1100 msec
>>
>> :-(.
>
> Plus, documentation for this is nowhere to be seen:
>
> pavel at amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> pavel at amd:/data/l/linux-n900$
that is a shame indeed. It is part of the driver since TUSB support was
merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
years ago.
The parameter expects the timeout values which is used to poll the port
for mode changes (host/device mode) since it can not be detected on its
own.
Felipe knows best if it is better to document it or remove it. I can't
remember that I needed it on am335x.
> Pavel
>
Sebastian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-09 21:39 musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs Pavel Machek
2015-07-09 21:46 ` Pavel Machek
@ 2015-07-10 19:50 ` Felipe Balbi
2015-07-10 21:46 ` Pavel Machek
1 sibling, 1 reply; 14+ messages in thread
From: Felipe Balbi @ 2015-07-10 19:50 UTC (permalink / raw)
To: Pavel Machek; +Cc: Greg KH, balbi, bigeasy, tony, varkabhadram, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Hi,
On Thu, Jul 09, 2015 at 11:39:22PM +0200, Pavel Machek wrote:
> Hi!
>
> sysfs should contain one value per file. This one has at least two,
> with nice english sentence as a bonus.
>
> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> cat vbus
> Vbus off, timeout 1100 msec
>
> :-(.
patches are always welcome.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-10 19:50 ` Felipe Balbi
@ 2015-07-10 21:46 ` Pavel Machek
2015-07-10 23:21 ` Greg KH
0 siblings, 1 reply; 14+ messages in thread
From: Pavel Machek @ 2015-07-10 21:46 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Greg KH, bigeasy, tony, varkabhadram, linux-kernel
On Fri 2015-07-10 14:50:12, Felipe Balbi wrote:
> Hi,
>
> On Thu, Jul 09, 2015 at 11:39:22PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > sysfs should contain one value per file. This one has at least two,
> > with nice english sentence as a bonus.
> >
> > root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> > cat vbus
> > Vbus off, timeout 1100 msec
> >
> > :-(.
>
> patches are always welcome.
You'd have to at least describe how you'd like to see it solved if you
wanted to pretend you maintain it... 2 new attributes? What should be
their names?
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/MAINTAINERS b/MAINTAINERS
index f6362d7..2e85300 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6900,7 +6900,7 @@ MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER
M: Felipe Balbi <balbi@ti.com>
L: linux-usb@vger.kernel.org
T: git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
-S: Maintained
+S: Odd fixes
F: drivers/usb/musb/
MXL5007T MEDIA DRIVER
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-10 21:46 ` Pavel Machek
@ 2015-07-10 23:21 ` Greg KH
0 siblings, 0 replies; 14+ messages in thread
From: Greg KH @ 2015-07-10 23:21 UTC (permalink / raw)
To: Pavel Machek; +Cc: Felipe Balbi, bigeasy, tony, varkabhadram, linux-kernel
On Fri, Jul 10, 2015 at 11:46:07PM +0200, Pavel Machek wrote:
> On Fri 2015-07-10 14:50:12, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Jul 09, 2015 at 11:39:22PM +0200, Pavel Machek wrote:
> > > Hi!
> > >
> > > sysfs should contain one value per file. This one has at least two,
> > > with nice english sentence as a bonus.
> > >
> > > root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> > > cat vbus
> > > Vbus off, timeout 1100 msec
> > >
> > > :-(.
> >
> > patches are always welcome.
>
> You'd have to at least describe how you'd like to see it solved if you
> wanted to pretend you maintain it... 2 new attributes? What should be
> their names?
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6362d7..2e85300 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6900,7 +6900,7 @@ MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER
> M: Felipe Balbi <balbi@ti.com>
> L: linux-usb@vger.kernel.org
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> -S: Maintained
> +S: Odd fixes
> F: drivers/usb/musb/
Don't be a jerk, you are _this_ close to being added to my killfile...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
2015-07-10 7:17 ` Sebastian Andrzej Siewior
(?)
@ 2015-07-13 20:30 ` Felipe Balbi
-1 siblings, 0 replies; 14+ messages in thread
From: Felipe Balbi @ 2015-07-13 20:30 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Pavel Machek, Greg KH, balbi, tony, varkabhadram, linux-kernel,
pali.rohar, sre, sre, linux-arm-kernel, linux-omap, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
On Fri, Jul 10, 2015 at 09:17:39AM +0200, Sebastian Andrzej Siewior wrote:
> On 07/09/2015 11:46 PM, Pavel Machek wrote:
> > On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> >> Hi!
>
> Hi,
>
> >>
> >> sysfs should contain one value per file. This one has at least two,
> >> with nice english sentence as a bonus.
> >>
> >> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> >> cat vbus
> >> Vbus off, timeout 1100 msec
> >>
> >> :-(.
> >
> > Plus, documentation for this is nowhere to be seen:
> >
> > pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> > pavel@amd:/data/l/linux-n900$
>
> that is a shame indeed. It is part of the driver since TUSB support was
> merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
> years ago.
> The parameter expects the timeout values which is used to poll the port
> for mode changes (host/device mode) since it can not be detected on its
> own.
> Felipe knows best if it is better to document it or remove it. I can't
> remember that I needed it on am335x.
N900's usersland relies on it, IIRC. But it could be that it was used
just for testing. I'm not entirely sure.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-13 20:30 ` Felipe Balbi
0 siblings, 0 replies; 14+ messages in thread
From: Felipe Balbi @ 2015-07-13 20:30 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 10, 2015 at 09:17:39AM +0200, Sebastian Andrzej Siewior wrote:
> On 07/09/2015 11:46 PM, Pavel Machek wrote:
> > On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> >> Hi!
>
> Hi,
>
> >>
> >> sysfs should contain one value per file. This one has at least two,
> >> with nice english sentence as a bonus.
> >>
> >> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> >> cat vbus
> >> Vbus off, timeout 1100 msec
> >>
> >> :-(.
> >
> > Plus, documentation for this is nowhere to be seen:
> >
> > pavel at amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> > pavel at amd:/data/l/linux-n900$
>
> that is a shame indeed. It is part of the driver since TUSB support was
> merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
> years ago.
> The parameter expects the timeout values which is used to poll the port
> for mode changes (host/device mode) since it can not be detected on its
> own.
> Felipe knows best if it is better to document it or remove it. I can't
> remember that I needed it on am335x.
N900's usersland relies on it, IIRC. But it could be that it was used
just for testing. I'm not entirely sure.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150713/9c93be7f/attachment-0001.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
@ 2015-07-13 20:30 ` Felipe Balbi
0 siblings, 0 replies; 14+ messages in thread
From: Felipe Balbi @ 2015-07-13 20:30 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Pavel Machek, Greg KH, balbi, tony, varkabhadram, linux-kernel,
pali.rohar, sre, sre, linux-arm-kernel, linux-omap, khilman,
aaro.koskinen, ivo.g.dimitrov.75, patrikbachan
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
On Fri, Jul 10, 2015 at 09:17:39AM +0200, Sebastian Andrzej Siewior wrote:
> On 07/09/2015 11:46 PM, Pavel Machek wrote:
> > On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
> >> Hi!
>
> Hi,
>
> >>
> >> sysfs should contain one value per file. This one has at least two,
> >> with nice english sentence as a bonus.
> >>
> >> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> >> cat vbus
> >> Vbus off, timeout 1100 msec
> >>
> >> :-(.
> >
> > Plus, documentation for this is nowhere to be seen:
> >
> > pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> > pavel@amd:/data/l/linux-n900$
>
> that is a shame indeed. It is part of the driver since TUSB support was
> merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
> years ago.
> The parameter expects the timeout values which is used to poll the port
> for mode changes (host/device mode) since it can not be detected on its
> own.
> Felipe knows best if it is better to document it or remove it. I can't
> remember that I needed it on am335x.
N900's usersland relies on it, IIRC. But it could be that it was used
just for testing. I'm not entirely sure.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-07-13 20:31 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09 21:39 musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-09 21:54 ` Pali Rohár
2015-07-09 21:54 ` Pali Rohár
2015-07-10 7:17 ` Sebastian Andrzej Siewior
2015-07-10 7:17 ` Sebastian Andrzej Siewior
2015-07-13 20:30 ` Felipe Balbi
2015-07-13 20:30 ` Felipe Balbi
2015-07-13 20:30 ` Felipe Balbi
2015-07-10 19:50 ` Felipe Balbi
2015-07-10 21:46 ` Pavel Machek
2015-07-10 23:21 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.