From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1 04/12] xprtrdma: Remove last ib_reg_phys_mr() call site
Date: Sat, 11 Jul 2015 03:34:28 -0700 [thread overview]
Message-ID: <20150711103428.GD14741@infradead.org> (raw)
In-Reply-To: <20150709204218.26247.67243.stgit@manet.1015granger.net>
On Thu, Jul 09, 2015 at 04:42:18PM -0400, Chuck Lever wrote:
> All HCA providers have an ib_get_dma_mr() verb. Thus
> rpcrdma_ia_open() will either grab the device's local_dma_key if one
> is available, or it will call ib_get_dma_mr() which is a 100%
> guaranteed fallback. There is never any need to use the
> ib_reg_phys_mr() code path in rpcrdma_register_internal(), so it can
> be removed.
Can you also send a follow-on to remove ib_reg_phys_mr entirely from
all core (= non-staging) code?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 04/12] xprtrdma: Remove last ib_reg_phys_mr() call site
Date: Sat, 11 Jul 2015 03:34:28 -0700 [thread overview]
Message-ID: <20150711103428.GD14741@infradead.org> (raw)
In-Reply-To: <20150709204218.26247.67243.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
On Thu, Jul 09, 2015 at 04:42:18PM -0400, Chuck Lever wrote:
> All HCA providers have an ib_get_dma_mr() verb. Thus
> rpcrdma_ia_open() will either grab the device's local_dma_key if one
> is available, or it will call ib_get_dma_mr() which is a 100%
> guaranteed fallback. There is never any need to use the
> ib_reg_phys_mr() code path in rpcrdma_register_internal(), so it can
> be removed.
Can you also send a follow-on to remove ib_reg_phys_mr entirely from
all core (= non-staging) code?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-11 10:34 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 20:41 [PATCH v1 00/12] NFS/RDMA client side for Linux 4.3 Chuck Lever
2015-07-09 20:41 ` Chuck Lever
2015-07-09 20:41 ` [PATCH v1 01/12] xprtrdma: Make xprt_setup_rdma() agnostic to family of server address Chuck Lever
2015-07-09 20:41 ` Chuck Lever
2015-07-09 20:41 ` [PATCH v1 02/12] xprtrdma: Raise maximum payload size to one megabyte Chuck Lever
2015-07-09 20:41 ` Chuck Lever
2015-07-10 10:25 ` Devesh Sharma
2015-07-10 10:25 ` Devesh Sharma
2015-07-10 19:21 ` Anna Schumaker
2015-07-10 19:21 ` Anna Schumaker
2015-07-10 19:33 ` Chuck Lever
2015-07-10 19:33 ` Chuck Lever
2015-07-10 19:41 ` Anna Schumaker
2015-07-10 19:41 ` Anna Schumaker
2015-07-12 14:31 ` Sagi Grimberg
2015-07-12 14:31 ` Sagi Grimberg
2015-07-09 20:42 ` [PATCH v1 03/12] xprtrdma: Increase default credit limit Chuck Lever
2015-07-09 20:42 ` Chuck Lever
2015-07-10 10:45 ` Devesh Sharma
2015-07-10 10:45 ` Devesh Sharma
2015-07-10 14:33 ` Chuck Lever
2015-07-10 14:33 ` Chuck Lever
2015-07-10 14:47 ` Devesh Sharma
2015-07-10 14:47 ` Devesh Sharma
2015-07-12 14:31 ` Sagi Grimberg
2015-07-12 14:31 ` Sagi Grimberg
2015-07-09 20:42 ` [PATCH v1 04/12] xprtrdma: Remove last ib_reg_phys_mr() call site Chuck Lever
2015-07-09 20:42 ` Chuck Lever
2015-07-10 10:52 ` Devesh Sharma
2015-07-10 10:52 ` Devesh Sharma
2015-07-11 10:34 ` Christoph Hellwig [this message]
2015-07-11 10:34 ` Christoph Hellwig
2015-07-11 18:50 ` Chuck Lever
2015-07-11 18:50 ` Chuck Lever
2015-07-12 7:58 ` Christoph Hellwig
2015-07-12 7:58 ` Christoph Hellwig
2015-07-12 14:31 ` Sagi Grimberg
2015-07-12 14:31 ` Sagi Grimberg
2015-07-09 20:42 ` [PATCH v1 05/12] xprtrdma: Account for RPC/RDMA header size when deciding to inline Chuck Lever
2015-07-09 20:42 ` Chuck Lever
2015-07-10 10:55 ` Devesh Sharma
2015-07-10 10:55 ` Devesh Sharma
2015-07-10 20:08 ` Anna Schumaker
2015-07-10 20:08 ` Anna Schumaker
2015-07-10 20:28 ` Chuck Lever
2015-07-10 20:28 ` Chuck Lever
2015-07-12 14:37 ` Sagi Grimberg
2015-07-12 14:37 ` Sagi Grimberg
2015-07-12 17:52 ` Chuck Lever
2015-07-12 17:52 ` Chuck Lever
2015-07-09 20:42 ` [PATCH v1 06/12] xprtrdma: Always provide a write list when sending NFS READ Chuck Lever
2015-07-09 20:42 ` Chuck Lever
2015-07-10 11:08 ` Devesh Sharma
2015-07-10 11:08 ` Devesh Sharma
2015-07-12 14:42 ` Sagi Grimberg
2015-07-12 14:42 ` Sagi Grimberg
2015-07-09 20:42 ` [PATCH v1 07/12] xprtrdma: Don't provide a reply chunk when expecting a short reply Chuck Lever
2015-07-09 20:42 ` Chuck Lever
2015-07-12 14:58 ` Sagi Grimberg
2015-07-12 14:58 ` Sagi Grimberg
2015-07-12 18:38 ` Chuck Lever
2015-07-12 18:38 ` Chuck Lever
2015-07-14 9:54 ` Sagi Grimberg
2015-07-14 9:54 ` Sagi Grimberg
2015-07-09 20:42 ` [PATCH v1 08/12] xprtrdma: Fix XDR tail buffer marshalling Chuck Lever
2015-07-09 20:42 ` Chuck Lever
2015-07-09 20:43 ` [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls Chuck Lever
2015-07-09 20:43 ` Chuck Lever
2015-07-10 11:29 ` Devesh Sharma
2015-07-10 11:29 ` Devesh Sharma
2015-07-10 12:58 ` Tom Talpey
2015-07-10 12:58 ` Tom Talpey
2015-07-10 14:11 ` Devesh Sharma
2015-07-10 14:11 ` Devesh Sharma
2015-07-10 14:53 ` Chuck Lever
2015-07-10 14:53 ` Chuck Lever
2015-07-10 22:44 ` Jason Gunthorpe
2015-07-10 22:44 ` Jason Gunthorpe
2015-07-10 20:43 ` Anna Schumaker
2015-07-10 20:43 ` Anna Schumaker
2015-07-10 20:52 ` Chuck Lever
2015-07-10 20:52 ` Chuck Lever
2015-07-09 20:43 ` [PATCH v1 10/12] xprtrdma: Fix large NFS SYMLINK calls Chuck Lever
2015-07-09 20:43 ` Chuck Lever
2015-07-14 16:01 ` Anna Schumaker
2015-07-14 16:01 ` Anna Schumaker
2015-07-14 19:09 ` Chuck Lever
2015-07-14 19:09 ` Chuck Lever
2015-07-09 20:43 ` [PATCH v1 11/12] xprtrdma: Clean up xprt_rdma_print_stats() Chuck Lever
2015-07-09 20:43 ` Chuck Lever
2015-07-09 20:43 ` [PATCH v1 12/12] xprtrdma: Count RDMA_NOMSG type calls Chuck Lever
2015-07-09 20:43 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150711103428.GD14741@infradead.org \
--to=hch@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.