All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	aarcange@redhat.com, riel@redhat.com, iamjoonsoo.kim@lge.com,
	xiexiuqi@huawei.com, gorcunov@openvz.org,
	linux-kernel@vger.kernel.org, mgorman@suse.de,
	rientjes@google.com, vbabka@suse.cz,
	aneesh.kumar@linux.vnet.ibm.com, hughd@google.com,
	hannes@cmpxchg.org, mhocko@suse.cz, boaz@plexistor.com,
	raindel@mellanox.com
Subject: Re: [RFC v3 2/3] mm: make optimistic check for swapin readahead
Date: Tue, 14 Jul 2015 00:07:27 +0300	[thread overview]
Message-ID: <20150713210727.GA1352@node.dhcp.inet.fi> (raw)
In-Reply-To: <1436819284-3964-3-git-send-email-ebru.akagunduz@gmail.com>

On Mon, Jul 13, 2015 at 11:28:03PM +0300, Ebru Akagunduz wrote:
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 595edd9..b4cef9d 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -24,6 +24,7 @@
>  #include <linux/migrate.h>
>  #include <linux/hashtable.h>
>  #include <linux/userfaultfd_k.h>
> +#include <linux/swapops.h>
>  
>  #include <asm/tlb.h>
>  #include <asm/pgalloc.h>
> @@ -2671,11 +2672,11 @@ static int khugepaged_scan_pmd(struct mm_struct *mm,
>  {
>  	pmd_t *pmd;
>  	pte_t *pte, *_pte;
> -	int ret = 0, none_or_zero = 0;
> +	int ret = 0, none_or_zero = 0, unmapped = 0;
>  	struct page *page = NULL;
>  	unsigned long _address;
>  	spinlock_t *ptl;
> -	int node = NUMA_NO_NODE;
> +	int node = NUMA_NO_NODE, max_ptes_swap = HPAGE_PMD_NR/8;

So, you've decide to ignore knob request for max_ptes_swap.
Why?

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	aarcange@redhat.com, riel@redhat.com, iamjoonsoo.kim@lge.com,
	xiexiuqi@huawei.com, gorcunov@openvz.org,
	linux-kernel@vger.kernel.org, mgorman@suse.de,
	rientjes@google.com, vbabka@suse.cz,
	aneesh.kumar@linux.vnet.ibm.com, hughd@google.com,
	hannes@cmpxchg.org, mhocko@suse.cz, boaz@plexistor.com,
	raindel@mellanox.com
Subject: Re: [RFC v3 2/3] mm: make optimistic check for swapin readahead
Date: Tue, 14 Jul 2015 00:07:27 +0300	[thread overview]
Message-ID: <20150713210727.GA1352@node.dhcp.inet.fi> (raw)
In-Reply-To: <1436819284-3964-3-git-send-email-ebru.akagunduz@gmail.com>

On Mon, Jul 13, 2015 at 11:28:03PM +0300, Ebru Akagunduz wrote:
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 595edd9..b4cef9d 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -24,6 +24,7 @@
>  #include <linux/migrate.h>
>  #include <linux/hashtable.h>
>  #include <linux/userfaultfd_k.h>
> +#include <linux/swapops.h>
>  
>  #include <asm/tlb.h>
>  #include <asm/pgalloc.h>
> @@ -2671,11 +2672,11 @@ static int khugepaged_scan_pmd(struct mm_struct *mm,
>  {
>  	pmd_t *pmd;
>  	pte_t *pte, *_pte;
> -	int ret = 0, none_or_zero = 0;
> +	int ret = 0, none_or_zero = 0, unmapped = 0;
>  	struct page *page = NULL;
>  	unsigned long _address;
>  	spinlock_t *ptl;
> -	int node = NUMA_NO_NODE;
> +	int node = NUMA_NO_NODE, max_ptes_swap = HPAGE_PMD_NR/8;

So, you've decide to ignore knob request for max_ptes_swap.
Why?

-- 
 Kirill A. Shutemov

  reply	other threads:[~2015-07-13 21:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 20:28 [RFC v3 0/3] mm: make swapin readahead to gain more thp performance Ebru Akagunduz
2015-07-13 20:28 ` Ebru Akagunduz
2015-07-13 20:28 ` [RFC v3 1/3] mm: add tracepoint for scanning pages Ebru Akagunduz
2015-07-13 20:28   ` Ebru Akagunduz
2015-07-13 21:06   ` Kirill A. Shutemov
2015-07-13 21:06     ` Kirill A. Shutemov
2015-07-14 19:16     ` Ebru Akagunduz
2015-07-14 19:16       ` Ebru Akagunduz
2015-07-28  8:39   ` Vlastimil Babka
2015-07-28  8:39     ` Vlastimil Babka
2015-07-13 20:28 ` [RFC v3 2/3] mm: make optimistic check for swapin readahead Ebru Akagunduz
2015-07-13 20:28   ` Ebru Akagunduz
2015-07-13 21:07   ` Kirill A. Shutemov [this message]
2015-07-13 21:07     ` Kirill A. Shutemov
2015-07-14 18:51     ` Ebru Akagunduz
2015-07-14 18:51       ` Ebru Akagunduz
2015-07-13 20:28 ` [RFC v3 3/3] mm: make swapin readahead to improve thp collapse rate Ebru Akagunduz
2015-07-13 20:28   ` Ebru Akagunduz
2015-07-14  9:02   ` Kirill A. Shutemov
2015-07-14  9:02     ` Kirill A. Shutemov
2015-07-28  8:59   ` Vlastimil Babka
2015-07-28  8:59     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713210727.GA1352@node.dhcp.inet.fi \
    --to=kirill@shutemov.name \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=boaz@plexistor.com \
    --cc=ebru.akagunduz@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=raindel@mellanox.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.