From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1
Date: Thu, 16 Jul 2015 21:32:32 +0100 [thread overview]
Message-ID: <20150716203232.GA1602@sirena.org.uk> (raw)
In-Reply-To: <1437070618-21330-6-git-send-email-vaibhav.hiremath@linaro.org>
On Thu, Jul 16, 2015 at 11:46:58PM +0530, Vaibhav Hiremath wrote:
> .disable = regulator_disable_regmap,
> .is_enabled = regulator_is_enabled_regmap,
> .get_current_limit = pm800_get_current_limit,
> + .set_current_limit = pm800_set_current_limit,
set_current_limit() isn't the right interface to use for this, this is
something that depends on the physical design of the system rather than
something that limits the current. It should be a DT property of its
own. There are some other PMICs with similar functions but it's not
clear yet how generic the configuration mechanism is.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150716/b5a98a6e/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
sameo@linux.intel.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1
Date: Thu, 16 Jul 2015 21:32:32 +0100 [thread overview]
Message-ID: <20150716203232.GA1602@sirena.org.uk> (raw)
In-Reply-To: <1437070618-21330-6-git-send-email-vaibhav.hiremath@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On Thu, Jul 16, 2015 at 11:46:58PM +0530, Vaibhav Hiremath wrote:
> .disable = regulator_disable_regmap,
> .is_enabled = regulator_is_enabled_regmap,
> .get_current_limit = pm800_get_current_limit,
> + .set_current_limit = pm800_set_current_limit,
set_current_limit() isn't the right interface to use for this, this is
something that depends on the physical design of the system rather than
something that limits the current. It should be a DT property of its
own. There are some other PMICs with similar functions but it's not
clear yet how generic the configuration mechanism is.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-16 20:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 18:16 [PATCH 0/5] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath
2015-07-16 18:16 ` Vaibhav Hiremath
2015-07-16 18:16 ` [PATCH 1/5] regulator: 88pm800: Fix indentation of assignments of data structures Vaibhav Hiremath
2015-07-16 18:16 ` Vaibhav Hiremath
2015-07-16 18:16 ` [PATCH 2/5] regulator: 88pm800: Update driver to use devm_regulator_register fn Vaibhav Hiremath
2015-07-16 18:16 ` Vaibhav Hiremath
2015-07-16 18:16 ` [PATCH 3/5] regulator: 88pm800: Use regulator_nodes/of_match in the descriptor Vaibhav Hiremath
2015-07-16 18:16 ` Vaibhav Hiremath
2015-07-16 18:16 ` [PATCH 4/5] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath
2015-07-16 18:16 ` Vaibhav Hiremath
2015-07-16 21:34 ` Mark Brown
2015-07-16 21:34 ` Mark Brown
2015-07-17 5:42 ` Vaibhav Hiremath
2015-07-17 5:42 ` Vaibhav Hiremath
2015-07-17 11:17 ` Mark Brown
2015-07-17 11:17 ` Mark Brown
2015-07-17 12:43 ` Vaibhav Hiremath
2015-07-17 12:43 ` Vaibhav Hiremath
2015-07-20 7:30 ` Lee Jones
2015-07-20 7:30 ` Lee Jones
2015-07-20 12:01 ` Vaibhav Hiremath
2015-07-20 12:01 ` Vaibhav Hiremath
2015-07-21 9:21 ` Lee Jones
2015-07-21 9:21 ` Lee Jones
2015-07-21 11:15 ` Vaibhav Hiremath
2015-07-21 11:15 ` Vaibhav Hiremath
2015-07-21 15:13 ` Lee Jones
2015-07-21 15:13 ` Lee Jones
2015-07-21 15:19 ` Vaibhav Hiremath
2015-07-21 15:19 ` Vaibhav Hiremath
2015-07-21 15:55 ` Lee Jones
2015-07-21 15:55 ` Lee Jones
2015-07-16 18:16 ` [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1 Vaibhav Hiremath
2015-07-16 18:16 ` Vaibhav Hiremath
2015-07-16 20:32 ` Mark Brown [this message]
2015-07-16 20:32 ` Mark Brown
2015-07-17 5:38 ` Vaibhav Hiremath
2015-07-17 5:38 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716203232.GA1602@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.