[Qemu-devel] [PATCH] vnc: fix vnc client authentication

[Qemu-devel] [PATCH] vnc: fix vnc client authentication

[Wolfgang Bumiller]

Commit 800567a61 updated the code to the generic crypto API
and mixed up encrypt and decrypt functions in
procotol_client_auth_vnc.
(Used to be: deskey(key, EN0) which encrypts, and was
changed to qcrypto_cipher_decrypt in 800567a61.)
Changed it to qcrypto_cipher_encrypt now.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
 ui/vnc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index 94e4f19..1483958 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2551,7 +2551,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
         goto reject;
     }
 
-    if (qcrypto_cipher_decrypt(cipher,
+    if (qcrypto_cipher_encrypt(cipher,
                                vs->challenge,
                                response,
                                VNC_AUTH_CHALLENGE_SIZE,
-- 
2.1.4

Re: [Qemu-devel] [PATCH] vnc: fix vnc client authentication

[Daniel P. Berrange]

On Tue, Jul 14, 2015 at 02:51:40PM +0200, Wolfgang Bumiller wrote:
> Commit 800567a61 updated the code to the generic crypto API
> and mixed up encrypt and decrypt functions in
> procotol_client_auth_vnc.
> (Used to be: deskey(key, EN0) which encrypts, and was
> changed to qcrypto_cipher_decrypt in 800567a61.)
> Changed it to qcrypto_cipher_encrypt now.
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
>  ui/vnc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 94e4f19..1483958 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2551,7 +2551,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
>          goto reject;
>      }
>  
> -    if (qcrypto_cipher_decrypt(cipher,
> +    if (qcrypto_cipher_encrypt(cipher,
>                                 vs->challenge,
>                                 response,
>                                 VNC_AUTH_CHALLENGE_SIZE,

I see its already merged while i was on holiday, but none the
less

 Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Thanks for fixing my stupid typo.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|