From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:34:26 +0100 [thread overview]
Message-ID: <20150721143426.GC10595@leverpostej> (raw)
In-Reply-To: <1437488279-2088-2-git-send-email-jszhang@marvell.com>
Hi,
> +/dts-v1/;
> +
> +/memreserve/ 0x00000000 0x01000000;
What's this reservation for?
Given you're using PSCI I can't see why we'd expect the kernel to map
but not use some memory.
> +
> +#include "berlin4ct.dtsi"
> +
> +/ {
> + model = "MARVELL BG4CT DMP BOARD";
> + compatible = "marvell,berlin4ct-dmp", "marvell,berlin4ct", "marvell,berlin";
> +
> + chosen {
> + bootargs = "earlyprintk";
> + stdout-path = "serial0:115200n8";
> + };
You shouldn't need those bootargs; "earlyprintk" does nothing on arm64.
[...]
> + gic: interrupt-controller at 901000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x901000 0x1000>,
> + <0x902000 0x1000>,
> + <0x904000 0x2000>,
> + <0x906000 0x2000>;
> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + };
> +
I believe the size of the cpu interface (the second reg entry) should be
0x2000, as GICC_DIR is at offset 0x1000.
Otherwise this looks fine.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Jisheng Zhang <jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Cc: Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <Will.Deacon-5wv7dgnIgG8@public.gmane.org>,
"khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
marc.zyngier-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:34:26 +0100 [thread overview]
Message-ID: <20150721143426.GC10595@leverpostej> (raw)
In-Reply-To: <1437488279-2088-2-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Hi,
> +/dts-v1/;
> +
> +/memreserve/ 0x00000000 0x01000000;
What's this reservation for?
Given you're using PSCI I can't see why we'd expect the kernel to map
but not use some memory.
> +
> +#include "berlin4ct.dtsi"
> +
> +/ {
> + model = "MARVELL BG4CT DMP BOARD";
> + compatible = "marvell,berlin4ct-dmp", "marvell,berlin4ct", "marvell,berlin";
> +
> + chosen {
> + bootargs = "earlyprintk";
> + stdout-path = "serial0:115200n8";
> + };
You shouldn't need those bootargs; "earlyprintk" does nothing on arm64.
[...]
> + gic: interrupt-controller@901000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x901000 0x1000>,
> + <0x902000 0x1000>,
> + <0x904000 0x2000>,
> + <0x906000 0x2000>;
> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + };
> +
I believe the size of the cpu interface (the second reg entry) should be
0x2000, as GICC_DIR is at offset 0x1000.
Otherwise this looks fine.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"khilman@linaro.org" <khilman@linaro.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"olof@lixom.net" <olof@lixom.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"galak@codeaurora.org" <galak@codeaurora.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
marc.zyngier@arm.com
Subject: Re: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:34:26 +0100 [thread overview]
Message-ID: <20150721143426.GC10595@leverpostej> (raw)
In-Reply-To: <1437488279-2088-2-git-send-email-jszhang@marvell.com>
Hi,
> +/dts-v1/;
> +
> +/memreserve/ 0x00000000 0x01000000;
What's this reservation for?
Given you're using PSCI I can't see why we'd expect the kernel to map
but not use some memory.
> +
> +#include "berlin4ct.dtsi"
> +
> +/ {
> + model = "MARVELL BG4CT DMP BOARD";
> + compatible = "marvell,berlin4ct-dmp", "marvell,berlin4ct", "marvell,berlin";
> +
> + chosen {
> + bootargs = "earlyprintk";
> + stdout-path = "serial0:115200n8";
> + };
You shouldn't need those bootargs; "earlyprintk" does nothing on arm64.
[...]
> + gic: interrupt-controller@901000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x901000 0x1000>,
> + <0x902000 0x1000>,
> + <0x904000 0x2000>,
> + <0x906000 0x2000>;
> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + };
> +
I believe the size of the cpu interface (the second reg entry) should be
0x2000, as GICC_DIR is at offset 0x1000.
Otherwise this looks fine.
Thanks,
Mark.
next prev parent reply other threads:[~2015-07-21 14:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 14:17 [PATCH 0/2] arm64: Add basic support for Marvell Berlin4CT SoC Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:17 ` [PATCH 1/2] arm64: dts: Add dts files " Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:34 ` Mark Rutland [this message]
2015-07-21 14:34 ` Mark Rutland
2015-07-21 14:34 ` Mark Rutland
2015-07-21 14:50 ` Jisheng Zhang
2015-07-21 14:50 ` Jisheng Zhang
2015-07-21 14:50 ` Jisheng Zhang
2015-07-21 14:56 ` Mark Rutland
2015-07-21 14:56 ` Mark Rutland
2015-07-21 14:56 ` Mark Rutland
2015-07-21 15:03 ` Sudeep Holla
2015-07-21 15:03 ` Sudeep Holla
2015-07-21 15:03 ` Sudeep Holla
2015-07-21 14:17 ` [PATCH 2/2] arm64: Enable Marvell Berlin SoC family in Kconfig and defconfig Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721143426.GC10595@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.