All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:56:43 +0100	[thread overview]
Message-ID: <20150721145643.GD10595@leverpostej> (raw)
In-Reply-To: <20150721225006.04c3d071@xhacker>

On Tue, Jul 21, 2015 at 03:50:06PM +0100, Jisheng Zhang wrote:
> Dear Mark,
> 
> Thanks a lot for so quick review!
> 
> On Tue, 21 Jul 2015 15:34:26 +0100
> Mark Rutland <mark.rutland@arm.com> wrote:
> 
> > Hi,
> > 
> > > +/dts-v1/;
> > > +
> > > +/memreserve/ 0x00000000 0x01000000;
> > 
> > What's this reservation for?
> 
> This is reserved for some firmwares' usage.
> 
> > 
> > Given you're using PSCI I can't see why we'd expect the kernel to map
> > but not use some memory.
> 
> Is it acceptable that we make memory start at 0x01000000 instead of reservation?

Yes, though it would still be worth a comment as to why that memory
can't be used.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Jisheng Zhang <jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Cc: Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <Will.Deacon-5wv7dgnIgG8@public.gmane.org>,
	"khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"arnd-r2nGTMty4D4@public.gmane.org"
	<arnd-r2nGTMty4D4@public.gmane.org>,
	"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
	<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
	<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
	Marc Zyngier <Marc.Zyngier-5wv7dgnIgG8@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:56:43 +0100	[thread overview]
Message-ID: <20150721145643.GD10595@leverpostej> (raw)
In-Reply-To: <20150721225006.04c3d071@xhacker>

On Tue, Jul 21, 2015 at 03:50:06PM +0100, Jisheng Zhang wrote:
> Dear Mark,
> 
> Thanks a lot for so quick review!
> 
> On Tue, 21 Jul 2015 15:34:26 +0100
> Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> 
> > Hi,
> > 
> > > +/dts-v1/;
> > > +
> > > +/memreserve/ 0x00000000 0x01000000;
> > 
> > What's this reservation for?
> 
> This is reserved for some firmwares' usage.
> 
> > 
> > Given you're using PSCI I can't see why we'd expect the kernel to map
> > but not use some memory.
> 
> Is it acceptable that we make memory start at 0x01000000 instead of reservation?

Yes, though it would still be worth a comment as to why that memory
can't be used.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"khilman@linaro.org" <khilman@linaro.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"olof@lixom.net" <olof@lixom.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:56:43 +0100	[thread overview]
Message-ID: <20150721145643.GD10595@leverpostej> (raw)
In-Reply-To: <20150721225006.04c3d071@xhacker>

On Tue, Jul 21, 2015 at 03:50:06PM +0100, Jisheng Zhang wrote:
> Dear Mark,
> 
> Thanks a lot for so quick review!
> 
> On Tue, 21 Jul 2015 15:34:26 +0100
> Mark Rutland <mark.rutland@arm.com> wrote:
> 
> > Hi,
> > 
> > > +/dts-v1/;
> > > +
> > > +/memreserve/ 0x00000000 0x01000000;
> > 
> > What's this reservation for?
> 
> This is reserved for some firmwares' usage.
> 
> > 
> > Given you're using PSCI I can't see why we'd expect the kernel to map
> > but not use some memory.
> 
> Is it acceptable that we make memory start at 0x01000000 instead of reservation?

Yes, though it would still be worth a comment as to why that memory
can't be used.

Thanks,
Mark.

  reply	other threads:[~2015-07-21 14:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21 14:17 [PATCH 0/2] arm64: Add basic support for Marvell Berlin4CT SoC Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:17 ` Jisheng Zhang
2015-07-21 14:17 ` [PATCH 1/2] arm64: dts: Add dts files " Jisheng Zhang
2015-07-21 14:17   ` Jisheng Zhang
2015-07-21 14:17   ` Jisheng Zhang
2015-07-21 14:34   ` Mark Rutland
2015-07-21 14:34     ` Mark Rutland
2015-07-21 14:34     ` Mark Rutland
2015-07-21 14:50     ` Jisheng Zhang
2015-07-21 14:50       ` Jisheng Zhang
2015-07-21 14:50       ` Jisheng Zhang
2015-07-21 14:56       ` Mark Rutland [this message]
2015-07-21 14:56         ` Mark Rutland
2015-07-21 14:56         ` Mark Rutland
2015-07-21 15:03   ` Sudeep Holla
2015-07-21 15:03     ` Sudeep Holla
2015-07-21 15:03     ` Sudeep Holla
2015-07-21 14:17 ` [PATCH 2/2] arm64: Enable Marvell Berlin SoC family in Kconfig and defconfig Jisheng Zhang
2015-07-21 14:17   ` Jisheng Zhang
2015-07-21 14:17   ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721145643.GD10595@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.