All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 7/8] perf: Define PMU_TXN_READ interface
Date: Thu, 23 Jul 2015 18:17:43 -0700	[thread overview]
Message-ID: <20150724011743.GA5847@us.ibm.com> (raw)
In-Reply-To: <20150723080435.GE25159@twins.programming.kicks-ass.net>

Peter Zijlstra [peterz@infradead.org] wrote:
| On Wed, Jul 22, 2015 at 04:19:16PM -0700, Sukadev Bhattiprolu wrote:
| > Peter Zijlstra [peterz@infradead.org] wrote:
| > | I've not woken up yet, and not actually fully read the email, but can
| > | you stuff the entire above chunk inside the IPI?
| > | 
| > | I think you could then actually optimize __perf_event_read() as well,
| > | because all these events should be on the same context, so no point in
| > | calling update_*time*() for every event or so.
| > | 
| > 
| > Do you mean something like this (will move the rename to a separate
| > patch before posting):
| 
| More like so.. please double check, I've not even had tea yet.

Yeah, I realized I had ignored the 'event->cpu' spec.
Will try this out. Thanks,

Sukadev

WARNING: multiple messages have this Message-ID (diff)
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 7/8] perf: Define PMU_TXN_READ interface
Date: Fri, 24 Jul 2015 01:17:43 +0000	[thread overview]
Message-ID: <20150724011743.GA5847@us.ibm.com> (raw)
In-Reply-To: <20150723080435.GE25159@twins.programming.kicks-ass.net>

Peter Zijlstra [peterz@infradead.org] wrote:
| On Wed, Jul 22, 2015 at 04:19:16PM -0700, Sukadev Bhattiprolu wrote:
| > Peter Zijlstra [peterz@infradead.org] wrote:
| > | I've not woken up yet, and not actually fully read the email, but can
| > | you stuff the entire above chunk inside the IPI?
| > | 
| > | I think you could then actually optimize __perf_event_read() as well,
| > | because all these events should be on the same context, so no point in
| > | calling update_*time*() for every event or so.
| > | 
| > 
| > Do you mean something like this (will move the rename to a separate
| > patch before posting):
| 
| More like so.. please double check, I've not even had tea yet.

Yeah, I realized I had ignored the 'event->cpu' spec.
Will try this out. Thanks,

Sukadev


  reply	other threads:[~2015-07-24  1:17 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  3:01 [PATCH v3 0/8] Implement group-read of events using txn interface Sukadev Bhattiprolu
2015-07-15  3:01 ` Sukadev Bhattiprolu
2015-07-15  3:01 ` Sukadev Bhattiprolu
2015-07-15  3:01 ` [PATCH v3 1/8] powerpc/perf/hv-24x7: Whitespace - fix parameter alignment Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-08-03  1:35   ` [v3, " Michael Ellerman
2015-08-03  1:35     ` [v3,1/8] " Michael Ellerman
2015-08-03  1:35     ` Michael Ellerman
2015-07-15  3:01 ` [PATCH v3 2/8] powerpc/perf/hv-24x7: Simplify extracting counter from result buffer Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-08-03  1:35   ` [v3, " Michael Ellerman
2015-08-03  1:35     ` Michael Ellerman
2015-07-15  3:01 ` [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-16 20:17   ` Peter Zijlstra
2015-07-16 20:17     ` Peter Zijlstra
2015-07-16 21:28     ` Sukadev Bhattiprolu
2015-07-16 21:28       ` Sukadev Bhattiprolu
2015-07-16 20:48   ` Peter Zijlstra
2015-07-16 20:48     ` Peter Zijlstra
2015-07-15  3:01 ` [PATCH v3 4/8] perf: Split perf_event_read() and perf_event_count() Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01 ` [PATCH v3 5/8] perf: Split perf_event_read_value() Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-16 21:12   ` Peter Zijlstra
2015-07-16 21:12     ` Peter Zijlstra
2015-07-16 21:41     ` Sukadev Bhattiprolu
2015-07-16 21:41       ` Sukadev Bhattiprolu
2015-07-23  7:45   ` Peter Zijlstra
2015-07-23  7:45     ` Peter Zijlstra
2015-07-27  5:54     ` Sukadev Bhattiprolu
2015-07-27  5:54       ` Sukadev Bhattiprolu
2015-07-15  3:01 ` [PATCH v3 6/8] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15  3:01   ` [PATCH v3 6/8] perf: Rename perf_event_read_{one,group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` [PATCH v3 6/8] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15  3:01 ` [PATCH v3 7/8] perf: Define PMU_TXN_READ interface Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-16 22:20   ` Peter Zijlstra
2015-07-16 22:20     ` Peter Zijlstra
2015-07-22  1:50     ` Sukadev Bhattiprolu
2015-07-22  1:50       ` Sukadev Bhattiprolu
2015-07-22  5:55       ` Peter Zijlstra
2015-07-22  5:55         ` Peter Zijlstra
2015-07-22 23:19         ` Sukadev Bhattiprolu
2015-07-22 23:19           ` Sukadev Bhattiprolu
2015-07-22 23:19           ` Sukadev Bhattiprolu
2015-07-23  8:04           ` Peter Zijlstra
2015-07-23  8:04             ` Peter Zijlstra
2015-07-24  1:17             ` Sukadev Bhattiprolu [this message]
2015-07-24  1:17               ` Sukadev Bhattiprolu
2015-09-13 11:11             ` [tip:perf/core] perf/core: Add group reads to perf_event_read() tip-bot for Peter Zijlstra
2015-07-15  3:01 ` [PATCH v3 8/8] powerpc/perf/hv-24x7: Use PMU_TXN_READ interface Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu
2015-07-15  3:01   ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150724011743.GA5847@us.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.