From: Peter Zijlstra <peterz@infradead.org>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces
Date: Thu, 16 Jul 2015 22:17:49 +0200 [thread overview]
Message-ID: <20150716201749.GL3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1436929315-28520-4-git-send-email-sukadev@linux.vnet.ibm.com>
On Tue, Jul 14, 2015 at 08:01:50PM -0700, Sukadev Bhattiprolu wrote:
> @@ -1604,6 +1613,12 @@ static void power_pmu_start_txn(struct pmu *pmu)
> static void power_pmu_cancel_txn(struct pmu *pmu)
> {
> struct cpu_hw_events *cpuhw = this_cpu_ptr(&cpu_hw_events);
> + int txn_flags;
> +
> + txn_flags = cpuhw->txn_flags;
> + cpuhw->txn_flags = 0;
> + if (cpuhw->txn_flags & ~PERF_PMU_TXN_ADD)
> + return;
That seems, unintentional? ;-)
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces
Date: Thu, 16 Jul 2015 20:17:49 +0000 [thread overview]
Message-ID: <20150716201749.GL3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1436929315-28520-4-git-send-email-sukadev@linux.vnet.ibm.com>
On Tue, Jul 14, 2015 at 08:01:50PM -0700, Sukadev Bhattiprolu wrote:
> @@ -1604,6 +1613,12 @@ static void power_pmu_start_txn(struct pmu *pmu)
> static void power_pmu_cancel_txn(struct pmu *pmu)
> {
> struct cpu_hw_events *cpuhw = this_cpu_ptr(&cpu_hw_events);
> + int txn_flags;
> +
> + txn_flags = cpuhw->txn_flags;
> + cpuhw->txn_flags = 0;
> + if (cpuhw->txn_flags & ~PERF_PMU_TXN_ADD)
> + return;
That seems, unintentional? ;-)
next prev parent reply other threads:[~2015-07-16 20:17 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 3:01 [PATCH v3 0/8] Implement group-read of events using txn interface Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 1/8] powerpc/perf/hv-24x7: Whitespace - fix parameter alignment Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-08-03 1:35 ` [v3, " Michael Ellerman
2015-08-03 1:35 ` [v3,1/8] " Michael Ellerman
2015-08-03 1:35 ` Michael Ellerman
2015-07-15 3:01 ` [PATCH v3 2/8] powerpc/perf/hv-24x7: Simplify extracting counter from result buffer Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-08-03 1:35 ` [v3, " Michael Ellerman
2015-08-03 1:35 ` Michael Ellerman
2015-07-15 3:01 ` [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-16 20:17 ` Peter Zijlstra [this message]
2015-07-16 20:17 ` Peter Zijlstra
2015-07-16 21:28 ` Sukadev Bhattiprolu
2015-07-16 21:28 ` Sukadev Bhattiprolu
2015-07-16 20:48 ` Peter Zijlstra
2015-07-16 20:48 ` Peter Zijlstra
2015-07-15 3:01 ` [PATCH v3 4/8] perf: Split perf_event_read() and perf_event_count() Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 5/8] perf: Split perf_event_read_value() Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-16 21:12 ` Peter Zijlstra
2015-07-16 21:12 ` Peter Zijlstra
2015-07-16 21:41 ` Sukadev Bhattiprolu
2015-07-16 21:41 ` Sukadev Bhattiprolu
2015-07-23 7:45 ` Peter Zijlstra
2015-07-23 7:45 ` Peter Zijlstra
2015-07-27 5:54 ` Sukadev Bhattiprolu
2015-07-27 5:54 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 6/8] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 6/8] perf: Rename perf_event_read_{one,group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 6/8] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 7/8] perf: Define PMU_TXN_READ interface Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-16 22:20 ` Peter Zijlstra
2015-07-16 22:20 ` Peter Zijlstra
2015-07-22 1:50 ` Sukadev Bhattiprolu
2015-07-22 1:50 ` Sukadev Bhattiprolu
2015-07-22 5:55 ` Peter Zijlstra
2015-07-22 5:55 ` Peter Zijlstra
2015-07-22 23:19 ` Sukadev Bhattiprolu
2015-07-22 23:19 ` Sukadev Bhattiprolu
2015-07-22 23:19 ` Sukadev Bhattiprolu
2015-07-23 8:04 ` Peter Zijlstra
2015-07-23 8:04 ` Peter Zijlstra
2015-07-24 1:17 ` Sukadev Bhattiprolu
2015-07-24 1:17 ` Sukadev Bhattiprolu
2015-09-13 11:11 ` [tip:perf/core] perf/core: Add group reads to perf_event_read() tip-bot for Peter Zijlstra
2015-07-15 3:01 ` [PATCH v3 8/8] powerpc/perf/hv-24x7: Use PMU_TXN_READ interface Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716201749.GL3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=sparclinux@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.