From: Lee Jones <lee@kernel.org>
To: Eric Anholt <eric@anholt.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH v4 6/8] ARM: bcm2835: Use the RPi firmware clocks for uart.
Date: Fri, 24 Jul 2015 16:22:00 +0100 [thread overview]
Message-ID: <20150724152200.GL3436@x1> (raw)
In-Reply-To: <1437420787-32137-7-git-send-email-eric@anholt.net>
On Mon, 20 Jul 2015, Eric Anholt wrote:
> This gets us a correct apb_pclk, which previously was accidentally
> using the "20201000.uart" clock from clk-bcm2835.c, due to the
> fallback clk_get_sys() path.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 7 +++++++
> arch/arm/boot/dts/bcm2835.dtsi | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
For my own reference:
Acked-by: Lee Jones <lee@kernel.org>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index 7cc47fb..9549eb8 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -1,3 +1,4 @@
> +#include <dt-bindings/clk/raspberrypi.h>
> #include "bcm2835.dtsi"
>
> / {
> @@ -62,3 +63,9 @@
> status = "okay";
> bus-width = <4>;
> };
> +
> +&uart0 {
> + clocks = <&firmware_clocks RPI_CLOCK_UART0>,
> + <&firmware_clocks RPI_CLOCK_CORE>;
> + clock-names = "uartclk", "apb_pclk";
> +};
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index 32f5830..5be2862 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -92,7 +92,7 @@
> #interrupt-cells = <2>;
> };
>
> - uart@7e201000 {
> + uart0: uart@7e201000 {
> compatible = "brcm,bcm2835-pl011", "arm,pl011", "arm,primecell";
> reg = <0x7e201000 0x1000>;
> interrupts = <2 25>;
WARNING: multiple messages have this Message-ID (diff)
From: lee@kernel.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/8] ARM: bcm2835: Use the RPi firmware clocks for uart.
Date: Fri, 24 Jul 2015 16:22:00 +0100 [thread overview]
Message-ID: <20150724152200.GL3436@x1> (raw)
In-Reply-To: <1437420787-32137-7-git-send-email-eric@anholt.net>
On Mon, 20 Jul 2015, Eric Anholt wrote:
> This gets us a correct apb_pclk, which previously was accidentally
> using the "20201000.uart" clock from clk-bcm2835.c, due to the
> fallback clk_get_sys() path.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 7 +++++++
> arch/arm/boot/dts/bcm2835.dtsi | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
For my own reference:
Acked-by: Lee Jones <lee@kernel.org>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index 7cc47fb..9549eb8 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -1,3 +1,4 @@
> +#include <dt-bindings/clk/raspberrypi.h>
> #include "bcm2835.dtsi"
>
> / {
> @@ -62,3 +63,9 @@
> status = "okay";
> bus-width = <4>;
> };
> +
> +&uart0 {
> + clocks = <&firmware_clocks RPI_CLOCK_UART0>,
> + <&firmware_clocks RPI_CLOCK_CORE>;
> + clock-names = "uartclk", "apb_pclk";
> +};
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index 32f5830..5be2862 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -92,7 +92,7 @@
> #interrupt-cells = <2>;
> };
>
> - uart at 7e201000 {
> + uart0: uart at 7e201000 {
> compatible = "brcm,bcm2835-pl011", "arm,pl011", "arm,primecell";
> reg = <0x7e201000 0x1000>;
> interrupts = <2 25>;
next prev parent reply other threads:[~2015-07-24 15:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 19:32 [PATCH v4 0/8] Raspberry Pi clock support Eric Anholt
2015-07-20 19:32 ` Eric Anholt
2015-07-20 19:33 ` [PATCH v4 1/8] clk: bcm2835: Add binding docs for the Raspberry Pi clock provider Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-08-11 21:18 ` Michael Turquette
2015-08-11 21:18 ` Michael Turquette
2015-08-12 17:56 ` Eric Anholt
2015-08-12 17:56 ` Eric Anholt
2015-07-20 19:33 ` [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-08-11 21:17 ` Michael Turquette
2015-08-11 21:17 ` Michael Turquette
2015-08-12 18:04 ` Eric Anholt
2015-08-12 18:04 ` Eric Anholt
2015-08-12 19:00 ` Michael Turquette
2015-08-12 19:00 ` Michael Turquette
2015-07-20 19:33 ` [PATCH v4 3/8] ARM: bcm2835: Add DT for the firmware clocks driver Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-07-24 15:23 ` Lee Jones
2015-07-24 15:23 ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 4/8] ARM: bcm2835: Drop never-used clock-frequency property of uart0 Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-07-24 15:22 ` Lee Jones
2015-07-24 15:22 ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 5/8] clk: bcm2835: Drop the fixed sys_pclk Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-08-11 21:19 ` Michael Turquette
2015-08-11 21:19 ` Michael Turquette
2015-08-11 21:19 ` Michael Turquette
2015-07-20 19:33 ` [PATCH v4 6/8] ARM: bcm2835: Use the RPi firmware clocks for uart Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-07-24 15:22 ` Lee Jones [this message]
2015-07-24 15:22 ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 7/8] ARM: bcm2835: Tie SPI clock to the core clock rate Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-07-24 15:23 ` Lee Jones
2015-07-24 15:23 ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 8/8] ARM: bcm2835: Use the firmware on rpi to get the EMMC clock Eric Anholt
2015-07-20 19:33 ` Eric Anholt
2015-07-24 15:22 ` Lee Jones
2015-07-24 15:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724152200.GL3436@x1 \
--to=lee@kernel.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.