All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@linaro.org>
To: Eric Anholt <eric@anholt.net>,  linux-arm-kernel@lists.infradead.org
Cc: linux-rpi-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Lee Jones" <lee@kernel.org>,
	linux-clk@vger.kernel.org, "Stephen Boyd" <sboyd@codeaurora.org>,
	"Eric Anholt" <eric@anholt.net>
Subject: Re: [PATCH v4 5/8] clk: bcm2835: Drop the fixed sys_pclk.
Date: Tue, 11 Aug 2015 14:19:46 -0700	[thread overview]
Message-ID: <20150811211946.31346.8021@quantum> (raw)
In-Reply-To: <1437420787-32137-6-git-send-email-eric@anholt.net>

Quoting Eric Anholt (2015-07-20 12:33:04)
> Nothing uses it, and I can't find any evidence that anything ever has.
> Its role is now filled by the core clock in the firmware driver.
> =

> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Applied to clk-next.

Regards,
Mike

> ---
>  drivers/clk/clk-bcm2835.c | 5 -----
>  1 file changed, 5 deletions(-)
> =

> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 6b950ca..dd295e4 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -32,11 +32,6 @@ void __init bcm2835_init_clocks(void)
>         struct clk *clk;
>         int ret;
>  =

> -       clk =3D clk_register_fixed_rate(NULL, "sys_pclk", NULL, CLK_IS_RO=
OT,
> -                                       250000000);
> -       if (IS_ERR(clk))
> -               pr_err("sys_pclk not registered\n");
> -
>         clk =3D clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_RO=
OT,
>                                         126000000);
>         if (IS_ERR(clk))
> -- =

> 2.1.4
>=20

WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Michael Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] clk: bcm2835: Drop the fixed sys_pclk.
Date: Tue, 11 Aug 2015 14:19:46 -0700	[thread overview]
Message-ID: <20150811211946.31346.8021@quantum> (raw)
In-Reply-To: <1437420787-32137-6-git-send-email-eric@anholt.net>

Quoting Eric Anholt (2015-07-20 12:33:04)
> Nothing uses it, and I can't find any evidence that anything ever has.
> Its role is now filled by the core clock in the firmware driver.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Applied to clk-next.

Regards,
Mike

> ---
>  drivers/clk/clk-bcm2835.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 6b950ca..dd295e4 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -32,11 +32,6 @@ void __init bcm2835_init_clocks(void)
>         struct clk *clk;
>         int ret;
>  
> -       clk = clk_register_fixed_rate(NULL, "sys_pclk", NULL, CLK_IS_ROOT,
> -                                       250000000);
> -       if (IS_ERR(clk))
> -               pr_err("sys_pclk not registered\n");
> -
>         clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT,
>                                         126000000);
>         if (IS_ERR(clk))
> -- 
> 2.1.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Michael Turquette <mturquette@linaro.org>
To: Eric Anholt <eric@anholt.net>, linux-arm-kernel@lists.infradead.org
Cc: linux-rpi-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Lee Jones" <lee@kernel.org>,
	linux-clk@vger.kernel.org, "Stephen Boyd" <sboyd@codeaurora.org>,
	"Eric Anholt" <eric@anholt.net>
Subject: Re: [PATCH v4 5/8] clk: bcm2835: Drop the fixed sys_pclk.
Date: Tue, 11 Aug 2015 14:19:46 -0700	[thread overview]
Message-ID: <20150811211946.31346.8021@quantum> (raw)
In-Reply-To: <1437420787-32137-6-git-send-email-eric@anholt.net>

Quoting Eric Anholt (2015-07-20 12:33:04)
> Nothing uses it, and I can't find any evidence that anything ever has.
> Its role is now filled by the core clock in the firmware driver.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Applied to clk-next.

Regards,
Mike

> ---
>  drivers/clk/clk-bcm2835.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 6b950ca..dd295e4 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -32,11 +32,6 @@ void __init bcm2835_init_clocks(void)
>         struct clk *clk;
>         int ret;
>  
> -       clk = clk_register_fixed_rate(NULL, "sys_pclk", NULL, CLK_IS_ROOT,
> -                                       250000000);
> -       if (IS_ERR(clk))
> -               pr_err("sys_pclk not registered\n");
> -
>         clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT,
>                                         126000000);
>         if (IS_ERR(clk))
> -- 
> 2.1.4
> 

  reply	other threads:[~2015-08-11 21:19 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 19:32 [PATCH v4 0/8] Raspberry Pi clock support Eric Anholt
2015-07-20 19:32 ` Eric Anholt
2015-07-20 19:33 ` [PATCH v4 1/8] clk: bcm2835: Add binding docs for the Raspberry Pi clock provider Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-08-11 21:18   ` Michael Turquette
2015-08-11 21:18     ` Michael Turquette
2015-08-12 17:56     ` Eric Anholt
2015-08-12 17:56       ` Eric Anholt
2015-07-20 19:33 ` [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-08-11 21:17   ` Michael Turquette
2015-08-11 21:17     ` Michael Turquette
2015-08-12 18:04     ` Eric Anholt
2015-08-12 18:04       ` Eric Anholt
2015-08-12 19:00       ` Michael Turquette
2015-08-12 19:00         ` Michael Turquette
2015-07-20 19:33 ` [PATCH v4 3/8] ARM: bcm2835: Add DT for the firmware clocks driver Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-07-24 15:23   ` Lee Jones
2015-07-24 15:23     ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 4/8] ARM: bcm2835: Drop never-used clock-frequency property of uart0 Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-07-24 15:22   ` Lee Jones
2015-07-24 15:22     ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 5/8] clk: bcm2835: Drop the fixed sys_pclk Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-08-11 21:19   ` Michael Turquette [this message]
2015-08-11 21:19     ` Michael Turquette
2015-08-11 21:19     ` Michael Turquette
2015-07-20 19:33 ` [PATCH v4 6/8] ARM: bcm2835: Use the RPi firmware clocks for uart Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-07-24 15:22   ` Lee Jones
2015-07-24 15:22     ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 7/8] ARM: bcm2835: Tie SPI clock to the core clock rate Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-07-24 15:23   ` Lee Jones
2015-07-24 15:23     ` Lee Jones
2015-07-20 19:33 ` [PATCH v4 8/8] ARM: bcm2835: Use the firmware on rpi to get the EMMC clock Eric Anholt
2015-07-20 19:33   ` Eric Anholt
2015-07-24 15:22   ` Lee Jones
2015-07-24 15:22     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811211946.31346.8021@quantum \
    --to=mturquette@linaro.org \
    --cc=eric@anholt.net \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=sboyd@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.