From: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Gregor Dick <gdick-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
Subject: Re: [PATCH v2 00/11] PCI: Fix ATS deadlock
Date: Wed, 29 Jul 2015 11:07:01 -0500 [thread overview]
Message-ID: <20150729160701.GC31170@google.com> (raw)
In-Reply-To: <20150721001243.28145.81610.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
On Mon, Jul 20, 2015 at 07:13:49PM -0500, Bjorn Helgaas wrote:
> Gregor reported a deadlock [1] when enabling a VF that supports ATS.
> This series is intended to fix that. The second patch should be enough to
> fix the deadlock; the rest are simplification and cleanup.
>
> These are based on v4.2-rc2.
>
> [1] http://permalink.gmane.org/gmane.linux.kernel.iommu/9433
>
> Changes between v1 and v2:
> - Remove use of pci_ats_enabled() (intel-iommu.c)
> - Call pci_ats_queue_depth() only once per device and cache result
> (intel-iommu.c)
> - Remove pci_ats_enabled() interface
> - Stop caching queue depth in pci_dev to save space
> - Add PF refcount of how many associated VFs have ATS enabled
> - Add comment that ATS must be enabled on PF before on VFs
> - Require ATS to be disabled on all VFs and PF before changing STU
>
>
> ---
>
> Bjorn Helgaas (11):
> iommu/vt-d: Cache PCI ATS state and Invalidate Queue Depth
> PCI: Allocate ATS struct during enumeration
> PCI: Embed ATS info directly into struct pci_dev
> PCI: Reduce size of ATS structure elements
> PCI: Rationalize pci_ats_queue_depth() error checking
> PCI: Inline the ATS setup code into pci_ats_init()
> PCI: Use pci_physfn() rather than looking up physfn by hand
> PCI: Clean up ATS error handling
> PCI: Move ATS declarations to linux/pci.h so they're all together
> PCI: Stop caching ATS Invalidate Queue Depth
> PCI: Remove pci_ats_enabled()
I applied these to a pci/iommu branch for v4.3. Let me know if you see any
issues.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
David Woodhouse <dwmw2@infradead.org>
Cc: iommu@lists.linux-foundation.org, Gregor Dick <gdick@solarflare.com>
Subject: Re: [PATCH v2 00/11] PCI: Fix ATS deadlock
Date: Wed, 29 Jul 2015 11:07:01 -0500 [thread overview]
Message-ID: <20150729160701.GC31170@google.com> (raw)
In-Reply-To: <20150721001243.28145.81610.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Mon, Jul 20, 2015 at 07:13:49PM -0500, Bjorn Helgaas wrote:
> Gregor reported a deadlock [1] when enabling a VF that supports ATS.
> This series is intended to fix that. The second patch should be enough to
> fix the deadlock; the rest are simplification and cleanup.
>
> These are based on v4.2-rc2.
>
> [1] http://permalink.gmane.org/gmane.linux.kernel.iommu/9433
>
> Changes between v1 and v2:
> - Remove use of pci_ats_enabled() (intel-iommu.c)
> - Call pci_ats_queue_depth() only once per device and cache result
> (intel-iommu.c)
> - Remove pci_ats_enabled() interface
> - Stop caching queue depth in pci_dev to save space
> - Add PF refcount of how many associated VFs have ATS enabled
> - Add comment that ATS must be enabled on PF before on VFs
> - Require ATS to be disabled on all VFs and PF before changing STU
>
>
> ---
>
> Bjorn Helgaas (11):
> iommu/vt-d: Cache PCI ATS state and Invalidate Queue Depth
> PCI: Allocate ATS struct during enumeration
> PCI: Embed ATS info directly into struct pci_dev
> PCI: Reduce size of ATS structure elements
> PCI: Rationalize pci_ats_queue_depth() error checking
> PCI: Inline the ATS setup code into pci_ats_init()
> PCI: Use pci_physfn() rather than looking up physfn by hand
> PCI: Clean up ATS error handling
> PCI: Move ATS declarations to linux/pci.h so they're all together
> PCI: Stop caching ATS Invalidate Queue Depth
> PCI: Remove pci_ats_enabled()
I applied these to a pci/iommu branch for v4.3. Let me know if you see any
issues.
next prev parent reply other threads:[~2015-07-29 16:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 0:13 [PATCH v2 00/11] PCI: Fix ATS deadlock Bjorn Helgaas
2015-07-21 0:13 ` [PATCH v2 01/11] iommu/vt-d: Cache PCI ATS state and Invalidate Queue Depth Bjorn Helgaas
[not found] ` <20150721001357.28145.83631.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-07-27 13:08 ` Joerg Roedel
2015-07-27 13:08 ` Joerg Roedel
2015-07-27 22:54 ` Bjorn Helgaas
[not found] ` <20150727225453.GB24401-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-07-28 7:14 ` Joerg Roedel
2015-07-28 7:14 ` Joerg Roedel
2015-07-21 0:14 ` [PATCH v2 02/11] PCI: Allocate ATS struct during enumeration Bjorn Helgaas
2015-07-27 12:40 ` Joerg Roedel
2015-07-21 0:14 ` [PATCH v2 03/11] PCI: Embed ATS info directly into struct pci_dev Bjorn Helgaas
[not found] ` <20150721001413.28145.38246.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-07-27 12:45 ` Joerg Roedel
2015-07-27 12:45 ` Joerg Roedel
[not found] ` <20150721001243.28145.81610.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-07-21 0:14 ` [PATCH v2 04/11] PCI: Reduce size of ATS structure elements Bjorn Helgaas
2015-07-21 0:14 ` Bjorn Helgaas
2015-07-21 0:14 ` [PATCH v2 07/11] PCI: Use pci_physfn() rather than looking up physfn by hand Bjorn Helgaas
2015-07-21 0:14 ` Bjorn Helgaas
2015-07-21 0:14 ` [PATCH v2 08/11] PCI: Clean up ATS error handling Bjorn Helgaas
2015-07-21 0:14 ` Bjorn Helgaas
2015-07-27 12:56 ` Joerg Roedel
2015-07-29 16:07 ` Bjorn Helgaas [this message]
2015-07-29 16:07 ` [PATCH v2 00/11] PCI: Fix ATS deadlock Bjorn Helgaas
2015-08-06 16:03 ` Yinghai Lu
2015-08-07 1:06 ` Yinghai Lu
2015-08-10 17:33 ` Bjorn Helgaas
2015-08-10 22:54 ` Yinghai Lu
2015-07-21 0:14 ` [PATCH v2 05/11] PCI: Rationalize pci_ats_queue_depth() error checking Bjorn Helgaas
2015-07-21 0:14 ` [PATCH v2 06/11] PCI: Inline the ATS setup code into pci_ats_init() Bjorn Helgaas
2015-07-21 0:15 ` [PATCH v2 09/11] PCI: Move ATS declarations to linux/pci.h so they're all together Bjorn Helgaas
2015-07-21 0:15 ` [PATCH v2 10/11] PCI: Stop caching ATS Invalidate Queue Depth Bjorn Helgaas
2015-07-27 12:57 ` Joerg Roedel
2015-07-27 14:00 ` Don Dutile
2015-07-27 22:27 ` Bjorn Helgaas
2015-07-27 23:13 ` Don Dutile
2015-07-21 0:15 ` [PATCH v2 11/11] PCI: Remove pci_ats_enabled() Bjorn Helgaas
[not found] ` <20150721001519.28145.73458.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-07-27 12:58 ` Joerg Roedel
2015-07-27 12:58 ` Joerg Roedel
2015-07-28 15:16 ` [PATCH v2 00/11] PCI: Fix ATS deadlock Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729160701.GC31170@google.com \
--to=bhelgaas-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=gdick-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.