From: Stephen Boyd <sboyd@codeaurora.org>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Heiko Stubner <heiko@sntech.de>,
srv_heupstream@mediatek.com, Daniel Kurtz <djkurtz@chromium.org>,
Ricky Liang <jcliang@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks
Date: Wed, 29 Jul 2015 17:27:54 -0700 [thread overview]
Message-ID: <20150730002754.GG3159@codeaurora.org> (raw)
In-Reply-To: <1438152754-11970-7-git-send-email-jamesjj.liao@mediatek.com>
On 07/29, James Liao wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> On the MT8173 the clocks are provided by different units. To enable
> the critical clocks we must be sure that all parent clocks are already
> registered, otherwise the parents of the critical clocks end up being
> unused and get disabled later.
>
> On MT8173, for example, it is the CLK_TOP clocks that have CLK_APMIXED
> PLLs as their parents, so we cannot enable the CLK_TOP critical clocks
> until the CLK_APMIXED clocks have all been registered.
>
> To find a place where all parents are registered we try each time
> after we've registered some clocks if all known providers are present
> now and only then we enable the critical clocks.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> ---
Please move up to v4.2-rc2 so that this patch can be dropped. I
already applied this and sent it off to Linus so it's in -rc2.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks
Date: Wed, 29 Jul 2015 17:27:54 -0700 [thread overview]
Message-ID: <20150730002754.GG3159@codeaurora.org> (raw)
In-Reply-To: <1438152754-11970-7-git-send-email-jamesjj.liao@mediatek.com>
On 07/29, James Liao wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> On the MT8173 the clocks are provided by different units. To enable
> the critical clocks we must be sure that all parent clocks are already
> registered, otherwise the parents of the critical clocks end up being
> unused and get disabled later.
>
> On MT8173, for example, it is the CLK_TOP clocks that have CLK_APMIXED
> PLLs as their parents, so we cannot enable the CLK_TOP critical clocks
> until the CLK_APMIXED clocks have all been registered.
>
> To find a place where all parents are registered we try each time
> after we've registered some clocks if all known providers are present
> now and only then we enable the critical clocks.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> ---
Please move up to v4.2-rc2 so that this patch can be dropped. I
already applied this and sent it off to Linus so it's in -rc2.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-07-30 0:27 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 6:52 [PATCH v5 00/10] Fixes and new clocks support for Mediatek MT8173 James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173 James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 7:05 ` Heiko Stübner
2015-07-29 7:05 ` Heiko Stübner
2015-07-29 7:17 ` James Liao
2015-07-29 7:17 ` James Liao
2015-07-29 7:17 ` James Liao
2015-07-30 17:36 ` Stephen Boyd
2015-07-30 17:36 ` Stephen Boyd
2015-07-30 17:36 ` Stephen Boyd
[not found] ` <20150730173643.GH3159-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-07-30 18:04 ` Heiko Stübner
2015-07-30 18:04 ` Heiko Stübner
2015-07-30 18:04 ` Heiko Stübner
2015-07-30 19:42 ` Stephen Boyd
2015-07-30 19:42 ` Stephen Boyd
2015-07-30 19:42 ` Stephen Boyd
2015-07-30 20:07 ` Heiko Stübner
2015-07-30 20:07 ` Heiko Stübner
2015-07-29 6:52 ` [PATCH v5 02/10] clk: mediatek: Remove unused code " James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 03/10] clk: mediatek: Add __initdata and __init for data and functions James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
[not found] ` <1438152754-11970-1-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-29 6:52 ` [PATCH v5 04/10] clk: mediatek: Add fixed clocks support for Mediatek SoC James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-30 0:27 ` Stephen Boyd [this message]
2015-07-30 0:27 ` Stephen Boyd
[not found] ` <20150730002754.GG3159-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-07-30 2:23 ` James Liao
2015-07-30 2:23 ` James Liao
2015-07-30 2:23 ` James Liao
2015-07-29 6:52 ` [PATCH v5 05/10] clk: mediatek: Fix rate and dependency of MT8173 clocks James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 07/10] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 08/10] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 09/10] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` [PATCH v5 10/10] arm64: dts: mt8173: Add subsystem clock controller device nodes James Liao
2015-07-29 6:52 ` James Liao
2015-07-29 6:52 ` James Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730002754.GG3159@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=heiko@sntech.de \
--cc=jamesjj.liao@mediatek.com \
--cc=jcliang@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.