All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	srv_heupstream@mediatek.com, Daniel Kurtz <djkurtz@chromium.org>,
	Ricky Liang <jcliang@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173
Date: Wed, 29 Jul 2015 09:05:52 +0200	[thread overview]
Message-ID: <6282882.pftQBj38E3@diego> (raw)
In-Reply-To: <1438152754-11970-2-git-send-email-jamesjj.liao@mediatek.com>

Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao:
> The dpi_ck clock can be removed because it not actually used
> in topckgen and subsystems.
> 
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>

>From our past discussions this change looks about right, and should still 
become _part of 4.2_, to not have the CLK_TOP_DPI become part of the 
devicetree CLK_TOP_DPI.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/clk/mediatek/clk-mt8173.c      | 1 -
>  include/dt-bindings/clock/mt8173-clk.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt8173.c
> b/drivers/clk/mediatek/clk-mt8173.c index 4b9e04c..4486f8f 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -26,7 +26,6 @@ static DEFINE_SPINLOCK(mt8173_clk_lock);
> 
>  static const struct mtk_fixed_factor root_clk_alias[] __initconst = {
>  	FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1),
> -	FACTOR(CLK_TOP_DPI, "dpi_ck", "clk_null", 1, 1),
>  	FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1),
>  	FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1),
>  };
> diff --git a/include/dt-bindings/clock/mt8173-clk.h
> b/include/dt-bindings/clock/mt8173-clk.h index 4ad76ed..7230c38 100644
> --- a/include/dt-bindings/clock/mt8173-clk.h
> +++ b/include/dt-bindings/clock/mt8173-clk.h
> @@ -18,7 +18,6 @@
>  /* TOPCKGEN */
> 
>  #define CLK_TOP_CLKPH_MCK_O		1
> -#define CLK_TOP_DPI			2
>  #define CLK_TOP_USB_SYSPLL_125M		3
>  #define CLK_TOP_HDMITX_DIG_CTS		4
>  #define CLK_TOP_ARMCA7PLL_754M		5

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173
Date: Wed, 29 Jul 2015 09:05:52 +0200	[thread overview]
Message-ID: <6282882.pftQBj38E3@diego> (raw)
In-Reply-To: <1438152754-11970-2-git-send-email-jamesjj.liao@mediatek.com>

Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao:
> The dpi_ck clock can be removed because it not actually used
> in topckgen and subsystems.
> 
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>

>From our past discussions this change looks about right, and should still 
become _part of 4.2_, to not have the CLK_TOP_DPI become part of the 
devicetree CLK_TOP_DPI.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/clk/mediatek/clk-mt8173.c      | 1 -
>  include/dt-bindings/clock/mt8173-clk.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt8173.c
> b/drivers/clk/mediatek/clk-mt8173.c index 4b9e04c..4486f8f 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -26,7 +26,6 @@ static DEFINE_SPINLOCK(mt8173_clk_lock);
> 
>  static const struct mtk_fixed_factor root_clk_alias[] __initconst = {
>  	FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1),
> -	FACTOR(CLK_TOP_DPI, "dpi_ck", "clk_null", 1, 1),
>  	FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1),
>  	FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1),
>  };
> diff --git a/include/dt-bindings/clock/mt8173-clk.h
> b/include/dt-bindings/clock/mt8173-clk.h index 4ad76ed..7230c38 100644
> --- a/include/dt-bindings/clock/mt8173-clk.h
> +++ b/include/dt-bindings/clock/mt8173-clk.h
> @@ -18,7 +18,6 @@
>  /* TOPCKGEN */
> 
>  #define CLK_TOP_CLKPH_MCK_O		1
> -#define CLK_TOP_DPI			2
>  #define CLK_TOP_USB_SYSPLL_125M		3
>  #define CLK_TOP_HDMITX_DIG_CTS		4
>  #define CLK_TOP_ARMCA7PLL_754M		5

  reply	other threads:[~2015-07-29  7:05 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29  6:52 [PATCH v5 00/10] Fixes and new clocks support for Mediatek MT8173 James Liao
2015-07-29  6:52 ` James Liao
2015-07-29  6:52 ` James Liao
2015-07-29  6:52 ` [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173 James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  7:05   ` Heiko Stübner [this message]
2015-07-29  7:05     ` Heiko Stübner
2015-07-29  7:17     ` James Liao
2015-07-29  7:17       ` James Liao
2015-07-29  7:17       ` James Liao
2015-07-30 17:36       ` Stephen Boyd
2015-07-30 17:36         ` Stephen Boyd
2015-07-30 17:36         ` Stephen Boyd
     [not found]         ` <20150730173643.GH3159-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-07-30 18:04           ` Heiko Stübner
2015-07-30 18:04             ` Heiko Stübner
2015-07-30 18:04             ` Heiko Stübner
2015-07-30 19:42             ` Stephen Boyd
2015-07-30 19:42               ` Stephen Boyd
2015-07-30 19:42               ` Stephen Boyd
2015-07-30 20:07               ` Heiko Stübner
2015-07-30 20:07                 ` Heiko Stübner
2015-07-29  6:52 ` [PATCH v5 02/10] clk: mediatek: Remove unused code " James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52 ` [PATCH v5 03/10] clk: mediatek: Add __initdata and __init for data and functions James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52 ` [PATCH v5 05/10] clk: mediatek: Fix rate and dependency of MT8173 clocks James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
     [not found] ` <1438152754-11970-1-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-29  6:52   ` [PATCH v5 04/10] clk: mediatek: Add fixed clocks support for Mediatek SoC James Liao
2015-07-29  6:52     ` James Liao
2015-07-29  6:52     ` James Liao
2015-07-29  6:52   ` [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-07-29  6:52     ` James Liao
2015-07-29  6:52     ` James Liao
2015-07-30  0:27     ` Stephen Boyd
2015-07-30  0:27       ` Stephen Boyd
     [not found]       ` <20150730002754.GG3159-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-07-30  2:23         ` James Liao
2015-07-30  2:23           ` James Liao
2015-07-30  2:23           ` James Liao
2015-07-29  6:52 ` [PATCH v5 07/10] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52 ` [PATCH v5 08/10] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52 ` [PATCH v5 09/10] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52 ` [PATCH v5 10/10] arm64: dts: mt8173: Add subsystem clock controller device nodes James Liao
2015-07-29  6:52   ` James Liao
2015-07-29  6:52   ` James Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6282882.pftQBj38E3@diego \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=jamesjj.liao@mediatek.com \
    --cc=jcliang@chromium.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.