From: Theodore Ts'o <tytso@mit.edu>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
Mani Nikula <jani.nikula@linux.intel.com>,
Ander Conselvan de Oliveira
<ander.conselvan.de.oliveira@intel.com>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached
Date: Wed, 29 Jul 2015 21:39:12 -0400 [thread overview]
Message-ID: <20150730013912.GA4068@thunk.org> (raw)
In-Reply-To: <20150730004937.GA3133@thunk.org>
On Wed, Jul 29, 2015 at 08:49:37PM -0400, Theodore Ts'o wrote:
>
> Unfortunately the failure causes a series of recursive faults and I
> haven't been able to capture the stack trace, but on 4.2-rcX kernels,
> I can reliably cause the system to crash if my T540p is booted with
> the docking station attached.
>
> It will also crash if I boot the system first, and then insert the
> laptop into the dockstation.
>
> Unfortunately, I can't get a stack trace because there are a huge
> number of recursive/double faults, and the system dies so quickly that
> nothing ends up in the log files. If you really need a stack dump I
> can try to rig something, but modern Laptops don't have serial
> consoles any more, alas, so it's bit of a pain.
The bad news is that I tried to use kdump to capture a crashdump and
hopefully get more information, and kdump utterly wedged on the panic.
The good news is because it wedged the system, I was able to get the
console stackdump before it scrolled off due to a whole series of
recursive oops messages.
It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9
Hopefully tihs is useful. It's not obvious how to revert this change,
since there were a large number of changes to i915 after this. If
someone could help me with a revert, I'd be happy to test it.
Thanks,
- Ted
>
> I was able to bisect it down to this commit, however: 8c7b5ccb72987:
> "drm/i915: Use atomic helpers for computing changed flags:"
>
> Is there any chance Intel could add a Lenovo Dockstation with a
> Multistream DP output to part of your test hardware? Unfortunately it
> seems pretty common that I see regressions with my particular
> hardware. Maybe there aren't enough people using Thinkpads any more? :-(
>
> - Ted
>
>
> P.S. The git bisect log
>
> git bisect start
> # bad: [421d125c06c4be4c5005cb69840206bd09b71dd6] builddeb: sign the modules after splitting out the debuginfo files
> git bisect bad 421d125c06c4be4c5005cb69840206bd09b71dd6
> # good: [b953c0d234bc72e8489d3bf51a276c5c4ec85345] Linux 4.1
> git bisect good b953c0d234bc72e8489d3bf51a276c5c4ec85345
> # good: [aeaa2122af4e53f3bfd28e8f294557bb95af43fc] drm/i915/skl: Add the INIT power domain to the MISC I/O power well
> git bisect good aeaa2122af4e53f3bfd28e8f294557bb95af43fc
> # bad: [4d70f38a760ad2879d2ebd84001c92980180f630] drm/i915/bios: remove a redundant NULL pointer check
> git bisect bad 4d70f38a760ad2879d2ebd84001c92980180f630
> # bad: [27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25] drm/i915/bxt: Enable WaEnableYV12BugFixInHalfSliceChicken7 for Broxton
> git bisect bad 27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25
> # good: [4be0731786de10d0e9ae1d159504c83c6b052647] drm/i915: Add crtc states before calling compute_config()
> git bisect good 4be0731786de10d0e9ae1d159504c83c6b052647
> # good: [d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1] drm/i915: Stage new modeset state straight into atomic state
> git bisect good d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1
> # bad: [a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10] drm/i915: Swap atomic state in legacy modeset
> git bisect bad a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10
> # bad: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags
> git bisect bad 8c7b5ccb729870e606321b3703e2c2e698c49a95
> # good: [0f63cca2afdc38877e86acfa9821020f6e2213fd] drm/i915: Update crtc state active flag based on DPMS
> git bisect good 0f63cca2afdc38877e86acfa9821020f6e2213fd
> # good: [840bfe953384a134c8639f2964d9b74bfa671e16] drm/atomic: Make mode_fixup() optional for check_modeset()
> git bisect good 840bfe953384a134c8639f2964d9b74bfa671e16
> # first bad commit: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
Mani Nikula <jani.nikula@linux.intel.com>,
Ander Conselvan de Oliveira
<ander.conselvan.de.oliveira@intel.com>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached
Date: Wed, 29 Jul 2015 21:39:12 -0400 [thread overview]
Message-ID: <20150730013912.GA4068@thunk.org> (raw)
In-Reply-To: <20150730004937.GA3133@thunk.org>
On Wed, Jul 29, 2015 at 08:49:37PM -0400, Theodore Ts'o wrote:
>
> Unfortunately the failure causes a series of recursive faults and I
> haven't been able to capture the stack trace, but on 4.2-rcX kernels,
> I can reliably cause the system to crash if my T540p is booted with
> the docking station attached.
>
> It will also crash if I boot the system first, and then insert the
> laptop into the dockstation.
>
> Unfortunately, I can't get a stack trace because there are a huge
> number of recursive/double faults, and the system dies so quickly that
> nothing ends up in the log files. If you really need a stack dump I
> can try to rig something, but modern Laptops don't have serial
> consoles any more, alas, so it's bit of a pain.
The bad news is that I tried to use kdump to capture a crashdump and
hopefully get more information, and kdump utterly wedged on the panic.
The good news is because it wedged the system, I was able to get the
console stackdump before it scrolled off due to a whole series of
recursive oops messages.
It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9
Hopefully tihs is useful. It's not obvious how to revert this change,
since there were a large number of changes to i915 after this. If
someone could help me with a revert, I'd be happy to test it.
Thanks,
- Ted
>
> I was able to bisect it down to this commit, however: 8c7b5ccb72987:
> "drm/i915: Use atomic helpers for computing changed flags:"
>
> Is there any chance Intel could add a Lenovo Dockstation with a
> Multistream DP output to part of your test hardware? Unfortunately it
> seems pretty common that I see regressions with my particular
> hardware. Maybe there aren't enough people using Thinkpads any more? :-(
>
> - Ted
>
>
> P.S. The git bisect log
>
> git bisect start
> # bad: [421d125c06c4be4c5005cb69840206bd09b71dd6] builddeb: sign the modules after splitting out the debuginfo files
> git bisect bad 421d125c06c4be4c5005cb69840206bd09b71dd6
> # good: [b953c0d234bc72e8489d3bf51a276c5c4ec85345] Linux 4.1
> git bisect good b953c0d234bc72e8489d3bf51a276c5c4ec85345
> # good: [aeaa2122af4e53f3bfd28e8f294557bb95af43fc] drm/i915/skl: Add the INIT power domain to the MISC I/O power well
> git bisect good aeaa2122af4e53f3bfd28e8f294557bb95af43fc
> # bad: [4d70f38a760ad2879d2ebd84001c92980180f630] drm/i915/bios: remove a redundant NULL pointer check
> git bisect bad 4d70f38a760ad2879d2ebd84001c92980180f630
> # bad: [27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25] drm/i915/bxt: Enable WaEnableYV12BugFixInHalfSliceChicken7 for Broxton
> git bisect bad 27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25
> # good: [4be0731786de10d0e9ae1d159504c83c6b052647] drm/i915: Add crtc states before calling compute_config()
> git bisect good 4be0731786de10d0e9ae1d159504c83c6b052647
> # good: [d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1] drm/i915: Stage new modeset state straight into atomic state
> git bisect good d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1
> # bad: [a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10] drm/i915: Swap atomic state in legacy modeset
> git bisect bad a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10
> # bad: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags
> git bisect bad 8c7b5ccb729870e606321b3703e2c2e698c49a95
> # good: [0f63cca2afdc38877e86acfa9821020f6e2213fd] drm/i915: Update crtc state active flag based on DPMS
> git bisect good 0f63cca2afdc38877e86acfa9821020f6e2213fd
> # good: [840bfe953384a134c8639f2964d9b74bfa671e16] drm/atomic: Make mode_fixup() optional for check_modeset()
> git bisect good 840bfe953384a134c8639f2964d9b74bfa671e16
> # first bad commit: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags
>
next prev parent reply other threads:[~2015-07-30 1:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:49 i915 driver crashes on T540p if docking station attached Theodore Ts'o
2015-07-30 1:39 ` Theodore Ts'o [this message]
2015-07-30 1:39 ` [REGRESSION] " Theodore Ts'o
2015-07-30 1:47 ` Richard Harman
2015-07-30 5:18 ` Linus Torvalds
2015-07-30 5:18 ` Linus Torvalds
2015-07-30 11:16 ` Dave Airlie
2015-07-30 11:16 ` Dave Airlie
2015-07-30 14:40 ` Daniel Vetter
2015-07-30 14:40 ` Daniel Vetter
2015-07-30 15:32 ` Theodore Ts'o
2015-07-30 15:32 ` Theodore Ts'o
2015-07-30 15:54 ` Daniel Vetter
2015-07-30 15:54 ` [Intel-gfx] " Daniel Vetter
2015-07-30 15:57 ` Takashi Iwai
2015-07-30 15:57 ` [Intel-gfx] " Takashi Iwai
2015-07-30 18:14 ` Linus Torvalds
2015-07-30 18:14 ` [Intel-gfx] " Linus Torvalds
2015-07-30 15:50 ` Theodore Ts'o
2015-07-30 15:50 ` Theodore Ts'o
2015-07-30 15:59 ` Theodore Ts'o
2015-07-30 15:59 ` Theodore Ts'o
2015-07-30 16:00 ` Daniel Vetter
2015-07-30 16:00 ` Daniel Vetter
2015-08-03 15:27 ` Daniel Vetter
2015-08-03 16:25 ` Theodore Ts'o
2015-08-03 16:25 ` Theodore Ts'o
2015-08-03 17:24 ` Linus Torvalds
2015-08-03 17:24 ` Linus Torvalds
2015-08-03 18:49 ` Theodore Ts'o
2015-08-03 18:49 ` Theodore Ts'o
2015-08-03 22:05 ` Daniel Vetter
2015-08-03 22:05 ` Daniel Vetter
2015-08-04 1:17 ` Rafael J. Wysocki
2015-08-04 16:05 ` Daniel Vetter
2015-08-04 16:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730013912.GA4068@thunk.org \
--to=tytso@mit.edu \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.