All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	fupanli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Luis Henriques
	<luis.henriques-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3.10 ~ 3.14] efi: fix the efi 32bit boot failed problem
Date: Thu, 30 Jul 2015 17:45:44 +0100	[thread overview]
Message-ID: <20150730164544.GL2725@codeblueprint.co.uk> (raw)
In-Reply-To: <20150730163102.GA19943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>

On Thu, 30 Jul, at 09:31:02AM, Greg KH wrote:
> 
> Why isn't this an issue in newer kernel releases?  Did this already get
> fixed by some other patch?  If so, why can't we just take that patch?
> If not, why not?
 
The commit 35d5134b7d5a ("x86/efi: Correct EFI boot stub use of
code32_start") only exists in the stable trees in that form because
there was quite a lot of churn in that area in Linus tree that didn't
get backported.

So the code in Linus' tree never looked like the code in the stable does
right now.

> I _REALLY_ don't like taking patches that are not already in Linus's
> tree, as it almost always turns out to be the wrong solution.

Yeah, I think this issue verifies that.

-- 
Matt Fleming, Intel Open Source Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: fupan.li@windriver.com, linux-kernel@vger.kernel.org,
	fupanli@gmail.com, linux-efi@vger.kernel.org,
	Luis Henriques <luis.henriques@canonical.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH 3.10 ~ 3.14] efi: fix the efi 32bit boot failed problem
Date: Thu, 30 Jul 2015 17:45:44 +0100	[thread overview]
Message-ID: <20150730164544.GL2725@codeblueprint.co.uk> (raw)
In-Reply-To: <20150730163102.GA19943@kroah.com>

On Thu, 30 Jul, at 09:31:02AM, Greg KH wrote:
> 
> Why isn't this an issue in newer kernel releases?  Did this already get
> fixed by some other patch?  If so, why can't we just take that patch?
> If not, why not?
 
The commit 35d5134b7d5a ("x86/efi: Correct EFI boot stub use of
code32_start") only exists in the stable trees in that form because
there was quite a lot of churn in that area in Linus tree that didn't
get backported.

So the code in Linus' tree never looked like the code in the stable does
right now.

> I _REALLY_ don't like taking patches that are not already in Linus's
> tree, as it almost always turns out to be the wrong solution.

Yeah, I think this issue verifies that.

-- 
Matt Fleming, Intel Open Source Technology Center

  parent reply	other threads:[~2015-07-30 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 10:21 [PATCH 3.10 ~ 3.14] efi: fix the efi 32bit boot failed problem fupan.li
2015-07-28 15:15 ` Greg KH
2015-07-30 15:04 ` Matt Fleming
2015-07-30 16:31   ` Greg KH
     [not found]     ` <20150730163102.GA19943-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-30 16:45       ` Matt Fleming [this message]
2015-07-30 16:45         ` Matt Fleming
2015-07-30 16:59         ` Greg KH
     [not found]           ` <20150730165943.GD5515-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-31  1:22             ` fupan
2015-07-31  1:22               ` fupan
2015-07-31 12:05               ` Matt Fleming
2015-07-31 12:21                 ` Luis Henriques
2015-07-31 12:21                   ` Luis Henriques
2015-08-03  1:38                   ` fupan
2015-08-03  1:38                     ` fupan
2015-08-03  1:38                     ` fupan
2015-08-03  2:12                 ` fupan
2015-08-03  2:12                   ` fupan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730164544.GL2725@codeblueprint.co.uk \
    --to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
    --cc=fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
    --cc=fupanli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=luis.henriques-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.