From: Viresh Kumar <viresh.kumar@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Thomas Abraham <thomas.ab@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kevin Hilman <khilman@linaro.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Anand Moon <linux.amoon@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [PATCH v3 5/5] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option
Date: Sat, 1 Aug 2015 16:45:37 +0530 [thread overview]
Message-ID: <20150801111537.GH899@linux> (raw)
In-Reply-To: <1438368557-2352-6-git-send-email-b.zolnierkie@samsung.com>
On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote:
> Remove no longer needed CPU_FREQ_BOOST_SW config option.
>
> As a result scaling_boost_freqs sysfs attribute is available
> when cpufreq-dt driver is used and boost support is enabled.
>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/cpufreq/Kconfig | 4 ----
> drivers/cpufreq/freq_table.c | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index bf6d596..de00a52 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -21,10 +21,6 @@ if CPU_FREQ
> config CPU_FREQ_GOV_COMMON
> bool
>
> -config CPU_FREQ_BOOST_SW
> - bool
> - depends on THERMAL
> -
> config CPU_FREQ_STAT
> tristate "CPU frequency translation statistics"
> default y
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> index a8f1daf..4c5de5b 100644
> --- a/drivers/cpufreq/freq_table.c
> +++ b/drivers/cpufreq/freq_table.c
> @@ -293,9 +293,7 @@ EXPORT_SYMBOL_GPL(cpufreq_freq_attr_scaling_boost_freqs);
>
> struct freq_attr *cpufreq_generic_attr[] = {
> &cpufreq_freq_attr_scaling_available_freqs,
> -#ifdef CONFIG_CPU_FREQ_BOOST_SW
> &cpufreq_freq_attr_scaling_boost_freqs,
> -#endif
> NULL,
> };
> EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
So, this will start appearing for all platforms that use cpufreq_generic_attr
and that may not be the right thing. We may only want to show boost frequencies
only if the driver supports it.
@Rafael: What do you say?
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option
Date: Sat, 1 Aug 2015 16:45:37 +0530 [thread overview]
Message-ID: <20150801111537.GH899@linux> (raw)
In-Reply-To: <1438368557-2352-6-git-send-email-b.zolnierkie@samsung.com>
On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote:
> Remove no longer needed CPU_FREQ_BOOST_SW config option.
>
> As a result scaling_boost_freqs sysfs attribute is available
> when cpufreq-dt driver is used and boost support is enabled.
>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/cpufreq/Kconfig | 4 ----
> drivers/cpufreq/freq_table.c | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index bf6d596..de00a52 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -21,10 +21,6 @@ if CPU_FREQ
> config CPU_FREQ_GOV_COMMON
> bool
>
> -config CPU_FREQ_BOOST_SW
> - bool
> - depends on THERMAL
> -
> config CPU_FREQ_STAT
> tristate "CPU frequency translation statistics"
> default y
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> index a8f1daf..4c5de5b 100644
> --- a/drivers/cpufreq/freq_table.c
> +++ b/drivers/cpufreq/freq_table.c
> @@ -293,9 +293,7 @@ EXPORT_SYMBOL_GPL(cpufreq_freq_attr_scaling_boost_freqs);
>
> struct freq_attr *cpufreq_generic_attr[] = {
> &cpufreq_freq_attr_scaling_available_freqs,
> -#ifdef CONFIG_CPU_FREQ_BOOST_SW
> &cpufreq_freq_attr_scaling_boost_freqs,
> -#endif
> NULL,
> };
> EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
So, this will start appearing for all platforms that use cpufreq_generic_attr
and that may not be the right thing. We may only want to show boost frequencies
only if the driver supports it.
@Rafael: What do you say?
--
viresh
next prev parent reply other threads:[~2015-08-01 11:15 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 18:49 [PATCH v3 0/5] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` [PATCH v3 1/5] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` [PATCH v3 2/5] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` Bartlomiej Zolnierkiewicz
2015-08-01 10:48 ` Viresh Kumar
2015-08-01 10:48 ` Viresh Kumar
2015-07-31 18:49 ` [PATCH v3 3/5] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` Bartlomiej Zolnierkiewicz
2015-08-01 7:43 ` Krzysztof Kozlowski
2015-08-01 7:43 ` Krzysztof Kozlowski
2015-08-03 10:31 ` Bartlomiej Zolnierkiewicz
2015-08-03 10:31 ` Bartlomiej Zolnierkiewicz
2015-08-01 11:17 ` Viresh Kumar
2015-08-01 11:17 ` Viresh Kumar
2015-08-03 10:17 ` Bartlomiej Zolnierkiewicz
2015-08-03 10:17 ` Bartlomiej Zolnierkiewicz
2015-08-03 10:29 ` Viresh Kumar
2015-08-03 10:29 ` Viresh Kumar
2015-08-03 10:36 ` Bartlomiej Zolnierkiewicz
2015-08-03 10:36 ` Bartlomiej Zolnierkiewicz
2015-08-03 10:40 ` Viresh Kumar
2015-08-03 10:40 ` Viresh Kumar
2015-08-03 10:47 ` Bartlomiej Zolnierkiewicz
2015-08-03 10:47 ` Bartlomiej Zolnierkiewicz
2015-08-03 11:15 ` Krzysztof Kozlowski
2015-08-03 11:15 ` Krzysztof Kozlowski
2015-08-03 13:55 ` Bartlomiej Zolnierkiewicz
2015-08-03 13:55 ` Bartlomiej Zolnierkiewicz
2015-08-03 15:50 ` Viresh Kumar
2015-08-03 15:50 ` Viresh Kumar
2015-08-03 15:57 ` Bartlomiej Zolnierkiewicz
2015-08-03 15:57 ` Bartlomiej Zolnierkiewicz
2015-08-04 0:43 ` Krzysztof Kozlowski
2015-08-04 0:43 ` Krzysztof Kozlowski
2015-07-31 18:49 ` [PATCH v3 4/5] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` Bartlomiej Zolnierkiewicz
2015-08-01 10:50 ` Viresh Kumar
2015-08-01 10:50 ` Viresh Kumar
2015-07-31 18:49 ` [PATCH v3 5/5] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option Bartlomiej Zolnierkiewicz
2015-07-31 18:49 ` Bartlomiej Zolnierkiewicz
2015-08-01 11:15 ` Viresh Kumar [this message]
2015-08-01 11:15 ` Viresh Kumar
2015-08-03 17:12 ` Pandruvada, Srinivas
2015-08-03 17:12 ` Pandruvada, Srinivas
2015-08-03 17:12 ` Pandruvada, Srinivas
2015-08-03 17:12 ` Pandruvada, Srinivas
2015-08-04 1:09 ` Rafael J. Wysocki
2015-08-04 1:09 ` Rafael J. Wysocki
2015-08-03 20:55 ` [PATCH v3 0/5] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Tobias Jakobi
2015-08-03 20:55 ` Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801111537.GH899@linux \
--to=viresh.kumar@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=heiko@sntech.de \
--cc=javier@dowhile0.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@linaro.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=s.nawrocki@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.