[RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Alexander Aring]

Hi,

this patch series contains a rework of 802.15.4 6LoWPAN receive handling.
We need to check on some things before which never checked before, like
is 802.15.4 dataframe, if we can access skb->data[0] (could be that skb->len
is 0 then), etc.

Also various bug fixes like the masking for fragmentation dispatch value which
is currently wrong.

I introduced a complete new handling for the dispatch values based on mac80211
datatype receive handling mechanism.

This patch series based on bluetooth-next with various pending patches, I uploaded
the branch at:

https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2

so everybody can test it.

- Alex

Alexander Aring (16):
  ieee802154: 6lowpan: change dev vars to wdev and ldev
  ieee802154: 6lowpan: remove set to zero
  ieee802154: 6lowpan: remove EXPORT_SYMBOL
  ieee802154: 6lowpan: remove check on wdev is running
  ieee802154: 6lowpan: cleanup pull of iphc bytes
  ieee802154: 6lowpan: trivial checks at first
  ieee802154: 6lowpan: change skb->dev earlier
  ieee802154: 6lowpan: change frag return value handling
  ieee820154: 6lowpan: dispatch evaluation rework
  ieee802154: 6lowpan: add dispatch evalualtion helpers
  ieee802154: 6lowpan: fix fragmentation dispatch mask
  ieee802154: 6lowpan: add generic lowpan header check
  ieee802154: 6lowpan: add handler for all dispatch values
  ieee802154: 6lowpan: add check for reserved dispatch
  ieee802154: 6lowpan: check on valid 802.15.4 frame
  ieee802154: 6lowpan: remove packet type to host

 include/linux/ieee802154.h          |  48 +++++-
 include/net/6lowpan.h               |  18 ++-
 net/ieee802154/6lowpan/6lowpan_i.h  |   5 +-
 net/ieee802154/6lowpan/core.c       |  83 +++++-----
 net/ieee802154/6lowpan/reassembly.c |  15 +-
 net/ieee802154/6lowpan/rx.c         | 312 +++++++++++++++++++++++++++---------
 net/ieee802154/6lowpan/tx.c         |  39 +++--
 7 files changed, 369 insertions(+), 151 deletions(-)

-- 
2.5.0

[RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Alexander Aring]

Hi,

this patch series contains a rework of 802.15.4 6LoWPAN receive handling.
We need to check on some things before which never checked before, like
is 802.15.4 dataframe, if we can access skb->data[0] (could be that skb->len
is 0 then), etc.

Also various bug fixes like the masking for fragmentation dispatch value which
is currently wrong.

I introduced a complete new handling for the dispatch values based on mac80211
datatype receive handling mechanism.

This patch series based on bluetooth-next with various pending patches, I uploaded
the branch at:

https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2

so everybody can test it.

- Alex

Alexander Aring (16):
  ieee802154: 6lowpan: change dev vars to wdev and ldev
  ieee802154: 6lowpan: remove set to zero
  ieee802154: 6lowpan: remove EXPORT_SYMBOL
  ieee802154: 6lowpan: remove check on wdev is running
  ieee802154: 6lowpan: cleanup pull of iphc bytes
  ieee802154: 6lowpan: trivial checks at first
  ieee802154: 6lowpan: change skb->dev earlier
  ieee802154: 6lowpan: change frag return value handling
  ieee820154: 6lowpan: dispatch evaluation rework
  ieee802154: 6lowpan: add dispatch evalualtion helpers
  ieee802154: 6lowpan: fix fragmentation dispatch mask
  ieee802154: 6lowpan: add generic lowpan header check
  ieee802154: 6lowpan: add handler for all dispatch values
  ieee802154: 6lowpan: add check for reserved dispatch
  ieee802154: 6lowpan: check on valid 802.15.4 frame
  ieee802154: 6lowpan: remove packet type to host

 include/linux/ieee802154.h          |  48 +++++-
 include/net/6lowpan.h               |  18 ++-
 net/ieee802154/6lowpan/6lowpan_i.h  |   5 +-
 net/ieee802154/6lowpan/core.c       |  83 +++++-----
 net/ieee802154/6lowpan/reassembly.c |  15 +-
 net/ieee802154/6lowpan/rx.c         | 312 +++++++++++++++++++++++++++---------
 net/ieee802154/6lowpan/tx.c         |  39 +++--
 7 files changed, 369 insertions(+), 151 deletions(-)

-- 
2.5.0

Re: [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Alexander Aring]

Hi,

sorry my git-send-email setup seems to be broken somehow.

The first mail was sent and I got a "Maybe git-send-email is broken?".

I will try to dig into this issue. Again sorry for the noise.

- Alex

Re: [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Alexander Aring]

On Sun, Aug 02, 2015 at 01:38:05PM +0200, Alexander Aring wrote:
> Hi,
> 
> sorry my git-send-email setup seems to be broken somehow.
> 

I finally figured out that I have already known issue at [0].

Should be fixed now, I will try to resend.

- Alex

[0] http://www.spinics.net/lists/git/msg255933.html

[RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Alexander Aring]

Hi,

this patch series contains a rework of 802.15.4 6LoWPAN receive handling.
We need to check on some things before which never checked before, like
is 802.15.4 dataframe, if we can access skb->data[0] (could be that skb->len
is 0 then), etc.

Also various bug fixes like the masking for fragmentation dispatch value which
is currently wrong. Also we should again check the dispatch value after successful
reassembly a fragment, we currently assume always a iphc header there. This is wrong
it could also be a non-compressed header. This can occur if the compressed header is
larger than lower interface MTU size, we doesn't react on this while transmit which
is another issue. Nevertheless we also don't reach this case at worst-case compression
currently.

I introduced a complete new handling for the dispatch values based on mac80211
datatype receive handling mechanism.

This patch series based on bluetooth-next with various pending patches, I uploaded
the branch at:

https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2

so everybody can test it.

- Alex

Alexander Aring (16):
  ieee802154: 6lowpan: change dev vars to wdev and ldev
  ieee802154: 6lowpan: remove set to zero
  ieee802154: 6lowpan: remove EXPORT_SYMBOL
  ieee802154: 6lowpan: remove check on wdev is running
  ieee802154: 6lowpan: cleanup pull of iphc bytes
  ieee802154: 6lowpan: trivial checks at first
  ieee802154: 6lowpan: change skb->dev earlier
  ieee802154: 6lowpan: change frag return value handling
  ieee820154: 6lowpan: dispatch evaluation rework
  ieee802154: 6lowpan: add dispatch evalualtion helpers
  ieee802154: 6lowpan: fix fragmentation dispatch mask
  ieee802154: 6lowpan: add generic lowpan header check
  ieee802154: 6lowpan: add handler for all dispatch values
  ieee802154: 6lowpan: add check for reserved dispatch
  ieee802154: 6lowpan: check on valid 802.15.4 frame
  ieee802154: 6lowpan: remove packet type to host

 include/linux/ieee802154.h          |  48 +++++-
 include/net/6lowpan.h               |  18 ++-
 net/ieee802154/6lowpan/6lowpan_i.h  |   5 +-
 net/ieee802154/6lowpan/core.c       |  83 +++++-----
 net/ieee802154/6lowpan/reassembly.c |  15 +-
 net/ieee802154/6lowpan/rx.c         | 312 +++++++++++++++++++++++++++---------
 net/ieee802154/6lowpan/tx.c         |  39 +++--
 7 files changed, 369 insertions(+), 151 deletions(-)

-- 
2.5.0

Re: [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Stefan Schmidt]

Hello.

On 03/08/15 08:23, Alexander Aring wrote:
> Hi,
>
> this patch series contains a rework of 802.15.4 6LoWPAN receive handling.
> We need to check on some things before which never checked before, like
> is 802.15.4 dataframe, if we can access skb->data[0] (could be that skb->len
> is 0 then), etc.
>
> Also various bug fixes like the masking for fragmentation dispatch value which
> is currently wrong. Also we should again check the dispatch value after successful
> reassembly a fragment, we currently assume always a iphc header there. This is wrong
> it could also be a non-compressed header. This can occur if the compressed header is
> larger than lower interface MTU size, we doesn't react on this while transmit which
> is another issue. Nevertheless we also don't reach this case at worst-case compression
> currently.
>
> I introduced a complete new handling for the dispatch values based on mac80211
> datatype receive handling mechanism.

I'm going to review this set over the next days. Just as a heads up.

> This patch series based on bluetooth-next with various pending patches, I uploaded
> the branch at:
>
> https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2
>
> so everybody can test it.

I tried to apply the patches directly on bluetooth-next but they did not 
apply. Guess you want to rebase them when sending out a new round. For 
now I will review the patches here and use the branch you uploaded for 
testing. Will report back later.

regards
Stefan Schmidt

Re: [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Stefan Schmidt]

Hello.

On 12/08/15 10:15, Stefan Schmidt wrote:
> Hello.
>
> On 03/08/15 08:23, Alexander Aring wrote:
>> Hi,
>>
>> this patch series contains a rework of 802.15.4 6LoWPAN receive 
>> handling.
>> We need to check on some things before which never checked before, like
>> is 802.15.4 dataframe, if we can access skb->data[0] (could be that 
>> skb->len
>> is 0 then), etc.
>>
>> Also various bug fixes like the masking for fragmentation dispatch 
>> value which
>> is currently wrong. Also we should again check the dispatch value 
>> after successful
>> reassembly a fragment, we currently assume always a iphc header 
>> there. This is wrong
>> it could also be a non-compressed header. This can occur if the 
>> compressed header is
>> larger than lower interface MTU size, we doesn't react on this while 
>> transmit which
>> is another issue. Nevertheless we also don't reach this case at 
>> worst-case compression
>> currently.
>>
>> I introduced a complete new handling for the dispatch values based on 
>> mac80211
>> datatype receive handling mechanism.
>
> I'm going to review this set over the next days. Just as a heads up.
>
>> This patch series based on bluetooth-next with various pending 
>> patches, I uploaded
>> the branch at:
>>
>> https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2 
>>
>>
>> so everybody can test it.
>
> I tried to apply the patches directly on bluetooth-next but they did 
> not apply. Guess you want to rebase them when sending out a new round. 
> For now I will review the patches here and use the branch you uploaded 
> for testing. Will report back later.

My testing showed no problems with this. You can add a

Tested-by: Stefan Schmidt <stefan@osg.samsung.com>

to the whole series.

regards
Stefan Schmidt