Re: [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation

[Stefan Schmidt <stefan@osg.samsung.com>]

Hello.

On 12/08/15 10:15, Stefan Schmidt wrote:
> Hello.
>
> On 03/08/15 08:23, Alexander Aring wrote:
>> Hi,
>>
>> this patch series contains a rework of 802.15.4 6LoWPAN receive 
>> handling.
>> We need to check on some things before which never checked before, like
>> is 802.15.4 dataframe, if we can access skb->data[0] (could be that 
>> skb->len
>> is 0 then), etc.
>>
>> Also various bug fixes like the masking for fragmentation dispatch 
>> value which
>> is currently wrong. Also we should again check the dispatch value 
>> after successful
>> reassembly a fragment, we currently assume always a iphc header 
>> there. This is wrong
>> it could also be a non-compressed header. This can occur if the 
>> compressed header is
>> larger than lower interface MTU size, we doesn't react on this while 
>> transmit which
>> is another issue. Nevertheless we also don't reach this case at 
>> worst-case compression
>> currently.
>>
>> I introduced a complete new handling for the dispatch values based on 
>> mac80211
>> datatype receive handling mechanism.
>
> I'm going to review this set over the next days. Just as a heads up.
>
>> This patch series based on bluetooth-next with various pending 
>> patches, I uploaded
>> the branch at:
>>
>> https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2 
>>
>>
>> so everybody can test it.
>
> I tried to apply the patches directly on bluetooth-next but they did 
> not apply. Guess you want to rebase them when sending out a new round. 
> For now I will review the patches here and use the branch you uploaded 
> for testing. Will report back later.

My testing showed no problems with this. You can add a

Tested-by: Stefan Schmidt <stefan@osg.samsung.com>

to the whole series.

regards
Stefan Schmidt