From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gen9: Update null batch to follow VF state restriction
Date: Tue, 4 Aug 2015 18:37:27 -0700 [thread overview]
Message-ID: <20150805013726.GB2549@intel.com> (raw)
In-Reply-To: <1438356525-26820-1-git-send-email-arun.siluvery@linux.intel.com>
On Fri, Jul 31, 2015 at 04:28:45PM +0100, Arun Siluvery wrote:
> Atleast one component of one valid vertex element must be enabled.
>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_renderstate_gen9.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_renderstate_gen9.c b/drivers/gpu/drm/i915/intel_renderstate_gen9.c
> index 16a7ec2..fa86431 100644
> --- a/drivers/gpu/drm/i915/intel_renderstate_gen9.c
> +++ b/drivers/gpu/drm/i915/intel_renderstate_gen9.c
> @@ -873,7 +873,7 @@ static const u32 gen9_null_state_batch[] = {
> 0x00000000,
> 0x00000000,
> 0x78550003,
> - 0x00000000,
> + 0x00000001,
> 0x00000000,
> 0x00000000,
> 0x00000000,
Same as previous comment in patch 1, but silly programming is better than
definitely incorrect programming. With the comments from 1 addressed:
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-05 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 15:27 [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state Arun Siluvery
2015-07-31 15:28 ` [PATCH] drm/i915/gen9: Update null batch to follow VF state restriction Arun Siluvery
2015-08-05 1:37 ` Ben Widawsky [this message]
2015-08-05 7:07 ` Mika Kuoppala
2015-08-10 21:39 ` shuang.he
2015-08-04 14:03 ` [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state Mika Kuoppala
2015-08-05 1:36 ` Ben Widawsky
2015-08-05 8:13 ` Mika Kuoppala
2015-08-05 18:17 ` Ben Widawsky
2015-08-13 12:30 ` Mika Kuoppala
2015-08-13 13:11 ` [PATCH] tools/null_state/gen9: Send all components " Mika Kuoppala
2015-08-17 16:54 ` Ben Widawsky
2015-11-06 22:00 ` Chris Wilson
2015-11-06 22:19 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805013726.GB2549@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.