All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Mika Kuoppala <mika.kuoppala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] tools/null_state/gen9: Send all components in VF state
Date: Fri, 6 Nov 2015 14:19:37 -0800	[thread overview]
Message-ID: <20151106221931.GA9304@intel.com> (raw)
In-Reply-To: <20151106220019.GB18324@nuc-i3427.alporthouse.com>

On Fri, Nov 06, 2015 at 10:00:19PM +0000, Chris Wilson wrote:
> On Thu, Aug 13, 2015 at 04:11:00PM +0300, Mika Kuoppala wrote:
> > Fix
> > 
> > commit 59cdc16b1a6f069f944ff17851a59edf8f72d45d
> > Author: Arun Siluvery <arun.siluvery@linux.intel.com>
> > Date:   Fri Jul 31 16:27:07 2015 +0100
> > 
> >     tools/null_state/gen9: Send atleast one valid component in VF state
> > 
> > to honor the Reviewed-by, send all four components as noted by
> > Ben in his review.
> > 
> > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> > Cc: Arun Siluvery <arun.siluvery@linux.intel.com>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> 
> Mika, did you forget something? The kernel patch?
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

When you guys have a stable I-G-T I'd strongly advocate for removing null state
on gen9 and seeing if it actually hurts anything.

-- 
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-11-06 22:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 15:27 [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state Arun Siluvery
2015-07-31 15:28 ` [PATCH] drm/i915/gen9: Update null batch to follow VF state restriction Arun Siluvery
2015-08-05  1:37   ` Ben Widawsky
2015-08-05  7:07   ` Mika Kuoppala
2015-08-10 21:39   ` shuang.he
2015-08-04 14:03 ` [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state Mika Kuoppala
2015-08-05  1:36 ` Ben Widawsky
2015-08-05  8:13   ` Mika Kuoppala
2015-08-05 18:17     ` Ben Widawsky
2015-08-13 12:30   ` Mika Kuoppala
2015-08-13 13:11     ` [PATCH] tools/null_state/gen9: Send all components " Mika Kuoppala
2015-08-17 16:54       ` Ben Widawsky
2015-11-06 22:00       ` Chris Wilson
2015-11-06 22:19         ` Ben Widawsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151106221931.GA9304@intel.com \
    --to=benjamin.widawsky@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.