From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: "Cc: Ben Widawsky" <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state
Date: Tue, 04 Aug 2015 17:03:05 +0300 [thread overview]
Message-ID: <87k2tb6tie.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1438356427-26711-1-git-send-email-arun.siluvery@linux.intel.com>
Arun Siluvery <arun.siluvery@linux.intel.com> writes:
> A programming restriction exists for this instruction, atleast one component
> of one valid vertex element must be enabled.
>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> tools/null_state_gen/intel_renderstate_gen9.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/null_state_gen/intel_renderstate_gen9.c b/tools/null_state_gen/intel_renderstate_gen9.c
> index 6f808f8..b3766ea 100644
> --- a/tools/null_state_gen/intel_renderstate_gen9.c
> +++ b/tools/null_state_gen/intel_renderstate_gen9.c
> @@ -440,7 +440,12 @@ int gen9_setup_null_render_state(struct intel_batchbuffer *batch)
> /* Vertex buffers */
> gen8_emit_vertex_buffers(batch);
> gen8_emit_vertex_elements(batch);
> - OUT_CMD(GEN9_3DSTATE_COMPONENT_PACKING, 5);
> +
> + OUT_BATCH(GEN9_3DSTATE_COMPONENT_PACKING | 3);
> + OUT_BATCH(1);
> + OUT_BATCH(0);
> + OUT_BATCH(0);
> + OUT_BATCH(0);
>
> OUT_BATCH(GEN6_3DSTATE_VF_STATISTICS | 1 /* Enable */);
>
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-04 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 15:27 [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state Arun Siluvery
2015-07-31 15:28 ` [PATCH] drm/i915/gen9: Update null batch to follow VF state restriction Arun Siluvery
2015-08-05 1:37 ` Ben Widawsky
2015-08-05 7:07 ` Mika Kuoppala
2015-08-10 21:39 ` shuang.he
2015-08-04 14:03 ` Mika Kuoppala [this message]
2015-08-05 1:36 ` [PATCH] tools/null_state/gen9: Send atleast one valid component in VF state Ben Widawsky
2015-08-05 8:13 ` Mika Kuoppala
2015-08-05 18:17 ` Ben Widawsky
2015-08-13 12:30 ` Mika Kuoppala
2015-08-13 13:11 ` [PATCH] tools/null_state/gen9: Send all components " Mika Kuoppala
2015-08-17 16:54 ` Ben Widawsky
2015-11-06 22:00 ` Chris Wilson
2015-11-06 22:19 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2tb6tie.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.