[PATCH] acer-wmi: No rfkill on HP wifi

[PATCH] acer-wmi: No rfkill on HP wifi

[Powell, Michael]

Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Signed-off-by: Michael Powell <michael_powell@mentor.com>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c
b/drivers/platform/x86/acer-wmi.c
index 3ac29a1..3ad8077 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
__initconst = {
 	{ "IBM0068", 0},
 	{ "LEN0068", 0},
 	{ "SNY5001", 0},	/* sony-laptop in charge */
+        { "HPQ6001", 0},
 	{ "", 0},
 };
 
-- 
2.1.0

[PATCH RESEND] acer-wmi: No rfkill on HP wifi

[Powell, Michael]

Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Signed-off-by: Michael Powell <michael_powell@mentor.com>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c
b/drivers/platform/x86/acer-wmi.c
index 3ac29a1..3ad8077 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
__initconst = {
        { "IBM0068", 0},
        { "LEN0068", 0},
        { "SNY5001", 0},        /* sony-laptop in charge */
+	{ "HPQ6001", 0},
        { "", 0},
 };
 
-- 
2.1.0

Re: [PATCH RESEND] acer-wmi: No rfkill on HP wifi

[Darren Hart]

On Sun, Aug 02, 2015 at 10:59:29PM +0000, Powell, Michael wrote:
> Prevents acer-wmi from blocking wifi on HP Omen 15 laptops

Wow, you managed to miss both my automated scans for patches that fail
to Cc the maintainer :-) Patchwork caught it though.

Please Cc the maintainer listed in MAINTAINERS in the future per
Documentation/SubmittingPatches, section 5.

> 
> Signed-off-by: Michael Powell <michael_powell@mentor.com>
> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c
> b/drivers/platform/x86/acer-wmi.c
> index 3ac29a1..3ad8077 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
> __initconst = {
>         { "IBM0068", 0},
>         { "LEN0068", 0},
>         { "SNY5001", 0},        /* sony-laptop in charge */
> +	{ "HPQ6001", 0},
>         { "", 0},
>  };

I haven't determined the reason yet, but when saving this to apply, I get an
encoded blob of text instead of the patch. How did you send this email?

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH RESEND] acer-wmi: No rfkill on HP wifi

[Darren Hart]

On Wed, Aug 05, 2015 at 01:54:21PM -0700, Darren Hart wrote:
> On Sun, Aug 02, 2015 at 10:59:29PM +0000, Powell, Michael wrote:
> > Prevents acer-wmi from blocking wifi on HP Omen 15 laptops
> 
> Wow, you managed to miss both my automated scans for patches that fail
> to Cc the maintainer :-) Patchwork caught it though.
> 
> Please Cc the maintainer listed in MAINTAINERS in the future per
> Documentation/SubmittingPatches, section 5.
> 
> > 
> > Signed-off-by: Michael Powell <michael_powell@mentor.com>
> > ---
> >  drivers/platform/x86/acer-wmi.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/platform/x86/acer-wmi.c
> > b/drivers/platform/x86/acer-wmi.c
> > index 3ac29a1..3ad8077 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
> > __initconst = {
> >         { "IBM0068", 0},
> >         { "LEN0068", 0},
> >         { "SNY5001", 0},        /* sony-laptop in charge */
> > +	{ "HPQ6001", 0},
> >         { "", 0},
> >  };
> 
> I haven't determined the reason yet, but when saving this to apply, I get an
> encoded blob of text instead of the patch. How did you send this email?

And when pulling it down from Patchwork it has embedded ^M characters which
cause it to fail to apply with:

fatal: corrupt patch at line 17

Please resubmit after sending to yourself and verifying you can apply the patch.

-- 
Darren Hart
Intel Open Source Technology Center