From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Paul Mackerras <paulus@samba.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Luiz Capitulino <lcapitulino@redhat.com>,
Rik van Riel <riel@redhat.com>,
Steven Rostedt <srostedt@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq
Date: Fri, 7 Aug 2015 13:14:15 +0200 [thread overview]
Message-ID: <20150807111415.GC18673@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150807105738.GF16853@twins.programming.kicks-ass.net>
On Fri, Aug 07, 2015 at 12:57:38PM +0200, Peter Zijlstra wrote:
> > >+void __finish_swait(struct swait_queue_head *q, struct swait_queue *wait)
> > this one has no users the __ suggests that it is locked edition. Maybe
> > it is for the completions…
>
> Yeah, who knows, I certainly do not anymore ;-)
On that, we cannot convert completions to swait. Because swait wake_all
must not happen from IRQ context, and complete_all() typically is used
from just that.
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Paul Mackerras <paulus@samba.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Luiz Capitulino <lcapitulino@redhat.com>,
Rik van Riel <riel@redhat.com>,
Steven Rostedt <srostedt@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq
Date: Fri, 7 Aug 2015 13:14:15 +0200 [thread overview]
Message-ID: <20150807111415.GC18673@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150807105738.GF16853@twins.programming.kicks-ass.net>
On Fri, Aug 07, 2015 at 12:57:38PM +0200, Peter Zijlstra wrote:
> > >+void __finish_swait(struct swait_queue_head *q, struct swait_queue *wait)
> > this one has no users the __ suggests that it is locked edition. Maybe
> > it is for the completions…
>
> Yeah, who knows, I certainly do not anymore ;-)
On that, we cannot convert completions to swait. Because swait wake_all
must not happen from IRQ context, and complete_all() typically is used
from just that.
next prev parent reply other threads:[~2015-08-07 11:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 17:12 [patch -rt 0/2] use simple waitqueue for kvm vcpu waitqueue (v3) Marcelo Tosatti
2015-01-14 17:12 ` [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq Marcelo Tosatti
2015-01-14 18:22 ` Rik van Riel
2015-01-16 16:48 ` Steven Rostedt
2015-01-16 16:56 ` Steven Rostedt
2015-01-17 7:57 ` Peter Zijlstra
2015-01-19 14:41 ` Marcelo Tosatti
2015-01-20 5:46 ` Paul Mackerras
2015-01-20 18:16 ` Steven Rostedt
2015-01-21 15:07 ` Peter Zijlstra
2015-02-17 17:44 ` Sebastian Andrzej Siewior
2015-02-18 14:03 ` Peter Zijlstra
2015-02-25 21:02 ` Sebastian Andrzej Siewior
2015-08-07 10:57 ` Peter Zijlstra
2015-08-07 11:14 ` Peter Zijlstra [this message]
2015-08-07 11:14 ` Peter Zijlstra
2015-08-07 16:41 ` Christoph Hellwig
2015-08-07 16:45 ` Peter Zijlstra
2015-08-09 6:39 ` Christoph Hellwig
2015-08-17 20:31 ` Thomas Gleixner
2015-02-27 0:23 ` Marcelo Tosatti
2015-03-05 1:09 ` Marcelo Tosatti
2015-03-05 1:09 ` Marcelo Tosatti
2015-03-05 7:42 ` Sebastian Andrzej Siewior
2015-03-06 13:54 ` Sebastian Andrzej Siewior
2015-01-14 17:12 ` [patch -rt 2/2] KVM: lapic: mark LAPIC timer handler as irqsafe Marcelo Tosatti
2015-01-14 18:23 ` Rik van Riel
2015-01-14 17:35 ` [patch -rt 0/2] use simple waitqueue for kvm vcpu waitqueue (v3) Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2015-04-08 23:33 [patch -rt 0/2] use simple waitqueue for kvm vcpu waitqueue (v5) Marcelo Tosatti
2015-04-08 23:33 ` [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq Marcelo Tosatti
2015-01-21 20:36 [patch -rt 0/2] use simple waitqueue for kvm vcpu waitqueue (v4) Marcelo Tosatti
2015-01-21 20:36 ` [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq Marcelo Tosatti
2014-11-25 17:21 [patch -rt 0/2] use simple waitqueue for kvm vcpu waitqueue (v2) Marcelo Tosatti
2014-11-25 17:21 ` [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq Marcelo Tosatti
2014-11-25 18:57 ` Rik van Riel
2014-11-25 19:08 ` Rik van Riel
2014-11-25 19:30 ` Marcelo Tosatti
2014-11-25 20:23 ` Thomas Gleixner
2014-11-25 16:45 [patch -rt 0/2] use simple waitqueue for kvm vcpu waitqueue Marcelo Tosatti
2014-11-25 16:45 ` [patch -rt 1/2] KVM: use simple waitqueue for vcpu->wq Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807111415.GC18673@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.