[lm-sensors] [hwmon:watchdog-next 11/19] drivers/watchdog/lpc18xx_wdt.c:126:14: sparse: symbol

[lm-sensors] [hwmon:watchdog-next 11/19] drivers/watchdog/lpc18xx_wdt.c:126:14: sparse: symbol

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
head:   738f09850b8d45002a5315b24b893f5aaf419079
commit: 98dbc95687cc28c6a7a502c1fc35b53df5d13fa5 [11/19] watchdog: NXP LPC18xx Watchdog Timer Driver
reproduce:
  # apt-get install sparse
  git checkout 98dbc95687cc28c6a7a502c1fc35b53df5d13fa5
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/watchdog/lpc18xx_wdt.c:126:14: sparse: symbol 'lpc18xx_wdt_get_timeleft' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[lm-sensors] [PATCH hwmon] watchdog: lpc18xx_wdt_get_timeleft() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 lpc18xx_wdt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/lpc18xx_wdt.c b/drivers/watchdog/lpc18xx_wdt.c
index 00ff5bd..ab7b8b1 100644
--- a/drivers/watchdog/lpc18xx_wdt.c
+++ b/drivers/watchdog/lpc18xx_wdt.c
@@ -123,7 +123,7 @@ static int lpc18xx_wdt_set_timeout(struct watchdog_device *wdt_dev,
 	return 0;
 }
 
-unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
+static unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
 {
 	struct lpc18xx_wdt_dev *lpc18xx_wdt = watchdog_get_drvdata(wdt_dev);
 	unsigned int val;

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH hwmon] watchdog: lpc18xx_wdt_get_timeleft() can be static

[Guenter Roeck]

On 08/07/2015 10:03 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Wrong subsystem (should be watchdog), but still makes sense on top
of the offending patch. I'll add it to my pull request for Wim.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   lpc18xx_wdt.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/lpc18xx_wdt.c b/drivers/watchdog/lpc18xx_wdt.c
> index 00ff5bd..ab7b8b1 100644
> --- a/drivers/watchdog/lpc18xx_wdt.c
> +++ b/drivers/watchdog/lpc18xx_wdt.c
> @@ -123,7 +123,7 @@ static int lpc18xx_wdt_set_timeout(struct watchdog_device *wdt_dev,
>   	return 0;
>   }
>
> -unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
> +static unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
>   {
>   	struct lpc18xx_wdt_dev *lpc18xx_wdt = watchdog_get_drvdata(wdt_dev);
>   	unsigned int val;
>

Re: [lm-sensors] [PATCH hwmon] watchdog: lpc18xx_wdt_get_timeleft() can be static

[Guenter Roeck]

On 08/07/2015 10:03 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Wrong subsystem (should be watchdog), but still makes sense on top
of the offending patch. I'll add it to my pull request for Wim.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   lpc18xx_wdt.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/lpc18xx_wdt.c b/drivers/watchdog/lpc18xx_wdt.c
> index 00ff5bd..ab7b8b1 100644
> --- a/drivers/watchdog/lpc18xx_wdt.c
> +++ b/drivers/watchdog/lpc18xx_wdt.c
> @@ -123,7 +123,7 @@ static int lpc18xx_wdt_set_timeout(struct watchdog_device *wdt_dev,
>   	return 0;
>   }
>
> -unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
> +static unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
>   {
>   	struct lpc18xx_wdt_dev *lpc18xx_wdt = watchdog_get_drvdata(wdt_dev);
>   	unsigned int val;
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors