All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] usb: Add support for ACPI identification to xhci-platform
Date: Fri, 7 Aug 2015 18:29:05 -0700	[thread overview]
Message-ID: <20150808012905.GA10407@kroah.com> (raw)
In-Reply-To: <5e302acb5b03c9bf61ecfb9b5b37e8b3b520bed9.1438994178.git.dhdang@apm.com>

On Fri, Aug 07, 2015 at 06:03:36PM -0700, Duc Dang wrote:
> Provide the methods to let ACPI identify the need to use
> xhci-platform. Change the Kconfig files so the
> xhci-plat.o file is selectable during kernel config.
> 
> This has been tested on an ARM64 machine with platform XHCI, an
> x86_64 machine with XHCI, and an x86_64 machine without XHCI.
> There were no regressions or error messages on the machines
> without platform XHCI.
> 
> [dhdang: regenerate the patch over 4.2-rc5]
> Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
> Signed-off-by: Duc Dang <dhdang@apm.com>
> 
> ---
> Changes from v3:
> 	Regenerate the patch over 4.2-rc5
> 	No code change
> 
> Changes from v2
> 	Replaced tristate with a boolean as the driver doesn't
> 		compile as a module
> 	Correct --help-- to ---help---
> 
> Changes from v1
> 	Renamed from "add support for APM X-Gene to xhci-platform"
> 	Removed changes to arm64/Kconfig
> 	Made CONFIG_USB_XHCI_PLATFORM a user selectable config option
> 
>  drivers/usb/host/Kconfig     |  7 ++++++-
>  drivers/usb/host/xhci-plat.c | 11 +++++++++++
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 8afc3c1..96231ee 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -32,7 +32,12 @@ config USB_XHCI_PCI
>         default y
>  
>  config USB_XHCI_PLATFORM
> -	tristate
> +	tristate "xHCI platform driver support"
> +	---help---
> +	  Say 'Y' to enable the support for the xHCI host controller
> +	  as a platform device. Many ARM SoCs provide USB this way.
> +
> +	  If unsure, say 'Y'.
>  
>  config USB_XHCI_MVEBU
>  	tristate "xHCI support for Marvell Armada 375/38x"
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 5d03f8b..14b40d2 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -19,6 +19,7 @@
>  #include <linux/usb/phy.h>
>  #include <linux/slab.h>
>  #include <linux/usb/xhci_pdriver.h>
> +#include <linux/acpi.h>
>  
>  #include "xhci.h"
>  #include "xhci-mvebu.h"
> @@ -262,6 +263,15 @@ static const struct of_device_id usb_xhci_of_match[] = {
>  MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
>  #endif
>  
> +#ifdef CONFIG_ACPI

You shoudn't need this #ifdef, right?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Duc Dang <dhdang@apm.com>
Cc: Loc Ho <lho@apm.com>, USB list <linux-usb@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
	Mark Langsdorf <mlangsdo@redhat.com>, patches <patches@apm.com>,
	Feng Kan <fkan@apm.com>
Subject: Re: [PATCH v4 2/2] usb: Add support for ACPI identification to xhci-platform
Date: Fri, 7 Aug 2015 18:29:05 -0700	[thread overview]
Message-ID: <20150808012905.GA10407@kroah.com> (raw)
In-Reply-To: <5e302acb5b03c9bf61ecfb9b5b37e8b3b520bed9.1438994178.git.dhdang@apm.com>

On Fri, Aug 07, 2015 at 06:03:36PM -0700, Duc Dang wrote:
> Provide the methods to let ACPI identify the need to use
> xhci-platform. Change the Kconfig files so the
> xhci-plat.o file is selectable during kernel config.
> 
> This has been tested on an ARM64 machine with platform XHCI, an
> x86_64 machine with XHCI, and an x86_64 machine without XHCI.
> There were no regressions or error messages on the machines
> without platform XHCI.
> 
> [dhdang: regenerate the patch over 4.2-rc5]
> Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
> Signed-off-by: Duc Dang <dhdang@apm.com>
> 
> ---
> Changes from v3:
> 	Regenerate the patch over 4.2-rc5
> 	No code change
> 
> Changes from v2
> 	Replaced tristate with a boolean as the driver doesn't
> 		compile as a module
> 	Correct --help-- to ---help---
> 
> Changes from v1
> 	Renamed from "add support for APM X-Gene to xhci-platform"
> 	Removed changes to arm64/Kconfig
> 	Made CONFIG_USB_XHCI_PLATFORM a user selectable config option
> 
>  drivers/usb/host/Kconfig     |  7 ++++++-
>  drivers/usb/host/xhci-plat.c | 11 +++++++++++
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 8afc3c1..96231ee 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -32,7 +32,12 @@ config USB_XHCI_PCI
>         default y
>  
>  config USB_XHCI_PLATFORM
> -	tristate
> +	tristate "xHCI platform driver support"
> +	---help---
> +	  Say 'Y' to enable the support for the xHCI host controller
> +	  as a platform device. Many ARM SoCs provide USB this way.
> +
> +	  If unsure, say 'Y'.
>  
>  config USB_XHCI_MVEBU
>  	tristate "xHCI support for Marvell Armada 375/38x"
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 5d03f8b..14b40d2 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -19,6 +19,7 @@
>  #include <linux/usb/phy.h>
>  #include <linux/slab.h>
>  #include <linux/usb/xhci_pdriver.h>
> +#include <linux/acpi.h>
>  
>  #include "xhci.h"
>  #include "xhci-mvebu.h"
> @@ -262,6 +263,15 @@ static const struct of_device_id usb_xhci_of_match[] = {
>  MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
>  #endif
>  
> +#ifdef CONFIG_ACPI

You shoudn't need this #ifdef, right?

thanks,

greg k-h

  reply	other threads:[~2015-08-08  1:29 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADaLNDkeOP+gBw0qdSDha551w+w+q4ry9-EevDw5giyiQGdnqA@mail.gmail.com>
2015-08-08  1:03 ` [PATCH v4 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-08  1:03   ` Duc Dang
2015-08-08  1:03   ` [PATCH v4 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-08  1:03     ` Duc Dang
2015-08-08  1:29     ` Greg KH [this message]
2015-08-08  1:29       ` Greg KH
2015-08-08  2:40       ` Duc Dang
2015-08-08  2:40         ` Duc Dang
2015-08-08  3:18         ` [PATCH v5 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-08  3:18           ` Duc Dang
2015-08-08  3:18           ` [PATCH v5 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-08  3:18             ` Duc Dang
2015-08-08  9:22           ` [PATCH v5 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Russell King - ARM Linux
2015-08-08  9:22             ` Russell King - ARM Linux
2015-08-08 20:31             ` Duc Dang
2015-08-08 20:31               ` Duc Dang
2015-08-15 20:05               ` Arnd Bergmann
2015-08-15 20:05                 ` Arnd Bergmann
2015-08-19 21:28                 ` Duc Dang
2015-08-19 21:28                   ` Duc Dang
2015-08-20 13:09                   ` Arnd Bergmann
2015-08-20 13:09                     ` Arnd Bergmann
2015-08-20 19:38                     ` [PATCH v7 " Duc Dang
2015-08-20 19:38                       ` Duc Dang
2015-08-20 19:38                       ` [PATCH v7 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-20 19:38                         ` Duc Dang
2015-08-31 18:58                       ` [PATCH v7 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-31 18:58                         ` Duc Dang
2015-09-01 11:54                         ` Mathias Nyman
2015-09-01 11:54                           ` Mathias Nyman
2015-09-01 12:07                           ` Russell King - ARM Linux
2015-09-01 12:07                             ` Russell King - ARM Linux
2015-09-10 20:53                           ` Duc Dang
2015-09-10 20:53                             ` Duc Dang
2015-09-17 18:19                             ` [PATCH v8 0/3] usb: xhci-platform: Configure 64-bit DMA mask if the platform is capable Duc Dang
2015-09-17 18:19                               ` Duc Dang
2015-09-17 18:19                               ` [PATCH v8 1/3] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-09-17 18:19                                 ` Duc Dang
2015-09-17 19:51                                 ` Arnd Bergmann
2015-09-17 19:51                                   ` Arnd Bergmann
2015-09-17 20:29                                   ` Duc Dang
2015-09-17 20:29                                     ` Duc Dang
2015-09-17 18:19                               ` [PATCH v8 2/3] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-09-17 18:19                                 ` Duc Dang
2015-09-17 18:19                               ` [PATCH v8 3/3] usb: xhci: configure 32-bit DMA if the controller does not support 64-bit DMA Duc Dang
2015-09-17 18:19                                 ` Duc Dang
2015-09-30 21:24                               ` [PATCH v8 0/3] usb: xhci-platform: Configure 64-bit DMA mask if the platform is capable Duc Dang
2015-09-30 21:24                                 ` Duc Dang
2015-10-04  9:10                                 ` Greg KH
2015-10-04  9:10                                   ` Greg KH
2015-10-07 13:20                                   ` Mathias Nyman
2015-10-07 13:20                                     ` Mathias Nyman
2015-08-10  7:37             ` [PATCH v6 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-10  7:37               ` Duc Dang
2015-08-10  7:37               ` [PATCH v6 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-10  7:37                 ` Duc Dang
2015-08-08  5:43       ` [PATCH v4 " Javier Martinez Canillas
2015-08-08  5:43         ` Javier Martinez Canillas
2015-08-08 15:37         ` Greg KH
2015-08-08 15:37           ` Greg KH
2015-08-08 16:45           ` Duc Dang
2015-08-08 16:45             ` Duc Dang
2015-08-08 21:05           ` Javier Martinez Canillas
2015-08-08 21:05             ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150808012905.GA10407@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.