From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
Cc: Keerthy <a0393675-l0cyMroinI0@public.gmane.org>,
Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
grygorii.strashko-l0cyMroinI0@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
nm-l0cyMroinI0@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
t-kristo-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support
Date: Fri, 14 Aug 2015 10:29:35 +0200 [thread overview]
Message-ID: <20150814082935.GF22269@piout.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1508131822510.1009-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
On 13/08/2015 at 20:17:23 +0000, Paul Walmsley wrote :
> > I'd say that I don't really care. I'd say the best would be to make a
> > decision based on clock-accuracy but maybe that is an information you
> > don't have yet. Anyway, this could be added at a later date.
>
> Either the clock mux logic is glitchless, in which case the RTC is likely
> to lose at least 31 microseconds per switch; or it's not glitchless, in
> which case it's unsafe to switch the RTC clock source while the clock
> isn't gated. Keerthy, before submitting this patch for merging, I'd
> suggest consulting your hardware folks to figure out which case it is.
>
Don't take me wrong, your point is perfectly valid. I was just saying
that I didn't care what was done in the driver. Obviously, this has to
match what is best from a hardware point of view. But since we agreed on
the DT bindings, I'd say that we can still adjust the driver later.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Keerthy <a0393675@ti.com>, Keerthy <j-keerthy@ti.com>,
tony@atomide.com, linux-omap@vger.kernel.org, pawel.moll@arm.com,
galak@codeaurora.org, akpm@linux-foundation.org,
johan@kernel.org, grygorii.strashko@ti.com,
rtc-linux@googlegroups.com, bcousson@baylibre.com, nm@ti.com,
devicetree@vger.kernel.org, t-kristo@ti.com
Subject: [rtc-linux] Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support
Date: Fri, 14 Aug 2015 10:29:35 +0200 [thread overview]
Message-ID: <20150814082935.GF22269@piout.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1508131822510.1009@utopia.booyaka.com>
On 13/08/2015 at 20:17:23 +0000, Paul Walmsley wrote :
> > I'd say that I don't really care. I'd say the best would be to make a
> > decision based on clock-accuracy but maybe that is an information you
> > don't have yet. Anyway, this could be added at a later date.
>
> Either the clock mux logic is glitchless, in which case the RTC is likely
> to lose at least 31 microseconds per switch; or it's not glitchless, in
> which case it's unsafe to switch the RTC clock source while the clock
> isn't gated. Keerthy, before submitting this patch for merging, I'd
> suggest consulting your hardware folks to figure out which case it is.
>
Don't take me wrong, your point is perfectly valid. I was just saying
that I didn't care what was done in the driver. Obviously, this has to
match what is best from a hardware point of view. But since we agreed on
the DT bindings, I'd say that we can still adjust the driver later.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-08-14 8:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 9:28 [PATCH v2 0/6] ARM: AM4372: Enable RTC Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
[not found] ` <1439198906-31189-1-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-10 9:28 ` [PATCH v2 1/6] ARM: dts: AM43XX: Add clk_32k_rtc node Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
2015-08-10 9:28 ` [PATCH v2 2/6] rtc: omap: Add external clock enabling support Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
[not found] ` <1439198906-31189-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-11 14:00 ` Alexandre Belloni
2015-08-11 14:00 ` [rtc-linux] " Alexandre Belloni
2015-08-12 14:27 ` Paul Walmsley
2015-08-12 14:27 ` [rtc-linux] " Paul Walmsley
[not found] ` <alpine.DEB.2.02.1508121422020.7154-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2015-08-12 19:08 ` Keerthy
2015-08-12 19:08 ` [rtc-linux] " Keerthy
[not found] ` <55CB99C2.7010007-l0cyMroinI0@public.gmane.org>
2015-08-12 20:16 ` Alexandre Belloni
2015-08-12 20:16 ` [rtc-linux] " Alexandre Belloni
[not found] ` <20150812201636.GJ3411-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-08-13 20:17 ` Paul Walmsley
2015-08-13 20:17 ` [rtc-linux] " Paul Walmsley
[not found] ` <alpine.DEB.2.02.1508131822510.1009-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2015-08-14 4:55 ` Keerthy
2015-08-14 4:55 ` [rtc-linux] " Keerthy
2015-08-14 8:29 ` Alexandre Belloni [this message]
2015-08-14 8:29 ` Alexandre Belloni
2015-08-10 9:28 ` [PATCH v2 3/6] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
[not found] ` <1439198906-31189-4-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-11 12:55 ` Tony Lindgren
2015-08-11 12:55 ` [rtc-linux] " Tony Lindgren
[not found] ` <20150811125515.GN4215-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-08-11 17:54 ` Keerthy
2015-08-11 17:54 ` [rtc-linux] " Keerthy
[not found] ` <55CA36D2.3080509-l0cyMroinI0@public.gmane.org>
2015-08-12 8:37 ` Tony Lindgren
2015-08-12 8:37 ` [rtc-linux] " Tony Lindgren
[not found] ` <20150812083718.GS4215-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-08-13 6:59 ` Keerthy
2015-08-13 6:59 ` [rtc-linux] " Keerthy
2015-08-13 9:04 ` Keerthy
2015-08-13 9:04 ` [rtc-linux] " Keerthy
[not found] ` <55CC5DB4.7040704-l0cyMroinI0@public.gmane.org>
2015-08-13 9:59 ` Tony Lindgren
2015-08-13 9:59 ` [rtc-linux] " Tony Lindgren
2015-08-10 9:28 ` [PATCH v2 4/6] ARM: dts: am43x-epos-evm: Add the am438 compatible string Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
2015-08-10 9:28 ` [PATCH v2 5/6] ARM: AM43XX: HWMOD: Add rtc hwmod Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
[not found] ` <1439198906-31189-6-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2015-08-12 14:39 ` Paul Walmsley
2015-08-12 14:39 ` [rtc-linux] " Paul Walmsley
[not found] ` <alpine.DEB.2.02.1508121434190.7154-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2015-08-13 6:39 ` Tero Kristo
2015-08-13 6:39 ` [rtc-linux] " Tero Kristo
2015-08-10 9:28 ` [PATCH v2 6/6] ARM: dts: AM437X-GP-EVM: Enable rtc Keerthy
2015-08-10 9:28 ` [rtc-linux] " Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814082935.GF22269@piout.net \
--to=alexandre.belloni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=a0393675-l0cyMroinI0@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.