All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Pratyush Anand <panand@redhat.com>
Cc: linux@roeck-us.net, Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"open list:WOLFSON MICROELECTRONICS DRIVERS"
	<patches@opensource.wolfsonmicro.com>,
	"open list:ARM/STI ARCHITECTURE" <kernel@stlinux.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Baruch Siach <baruch@tkos.co.il>,
	"open list:INTEL MANAGEMENT ENGINE mei"
	<linux-kernel@vger.kernel.org>, Wim Van Sebroeck <wim@iguana.be>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
	<linux-samsung-soc@vger.kernel.org>, Lee Jones <lee@kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	Tomas Winkler <tomas.winkler@intel.com>,
	linux-watchdog@vger.kernel.org,
	Stephen Warren <swarren@wwwdotorg.org>,
	"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
	<linux-rpi-kernel@lists.infradead.org>,
	"open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra>
Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices
Date: Wed, 19 Aug 2015 08:44:19 +0200	[thread overview]
Message-ID: <20150819064419.GC9999@pengutronix.de> (raw)
In-Reply-To: <db7db9102158b87a4a7169e84e2272b3ba03f9f7.1439954581.git.panand@redhat.com>

Hello,

On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote:
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set

s/es//

> its parent and so, we do not see an entry for device in sysfs for such devices.
> 
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
> 
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.

I don't see why you don't use the platform device as parent for mpc8xxx.

Note however that I did several updates to the mpc8xxx driver which
probably conflict with setting the parent. I'll take care of that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Pratyush Anand <panand@redhat.com>
Cc: linux@roeck-us.net, Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"open list:WOLFSON MICROELECTRONICS DRIVERS"
	<patches@opensource.wolfsonmicro.com>,
	"open list:ARM/STI ARCHITECTURE" <kernel@stlinux.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Baruch Siach <baruch@tkos.co.il>,
	"open list:INTEL MANAGEMENT ENGINE mei"
	<linux-kernel@vger.kernel.org>, Wim Van Sebroeck <wim@iguana.be>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
	<linux-samsung-soc@vger.kernel.org>, Lee Jones <lee@kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	Tomas Winkler <tomas.winkler@intel.com>,
	linux-watchdog@vger.kernel.org,
	Stephen Warren <swarren@wwwdotorg.org>,
	"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
	<linux-rpi-kernel@lists.infradead.org>,
	"open list:TEGRA ARCHITECTURE SUPPORT"
	<linux-tegra@vger.kernel.org>,
	"moderated list:ARM/U300 MACHINE SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	Maxime Coquelin <maxime.coquelin@st.com>,
	Barry Song <baohua@kernel.org>,
	Johannes Thumshirn <morbidrsa@gmail.com>,
	Support Opensource <support.opensource@diasemi.com>,
	Andreas Werner <andreas.werner@men.de>,
	Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices
Date: Wed, 19 Aug 2015 08:44:19 +0200	[thread overview]
Message-ID: <20150819064419.GC9999@pengutronix.de> (raw)
In-Reply-To: <db7db9102158b87a4a7169e84e2272b3ba03f9f7.1439954581.git.panand@redhat.com>

Hello,

On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote:
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set

s/es//

> its parent and so, we do not see an entry for device in sysfs for such devices.
> 
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
> 
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.

I don't see why you don't use the platform device as parent for mpc8xxx.

Note however that I did several updates to the mpc8xxx driver which
probably conflict with setting the parent. I'll take care of that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] Watchdog: Fix parent of watchdog_devices
Date: Wed, 19 Aug 2015 08:44:19 +0200	[thread overview]
Message-ID: <20150819064419.GC9999@pengutronix.de> (raw)
In-Reply-To: <db7db9102158b87a4a7169e84e2272b3ba03f9f7.1439954581.git.panand@redhat.com>

Hello,

On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote:
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set

s/es//

> its parent and so, we do not see an entry for device in sysfs for such devices.
> 
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
> 
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.

I don't see why you don't use the platform device as parent for mpc8xxx.

Note however that I did several updates to the mpc8xxx driver which
probably conflict with setting the parent. I'll take care of that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Pratyush Anand <panand@redhat.com>
Cc: linux@roeck-us.net, Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"open list:WOLFSON MICROELECTRONICS DRIVERS" 
	<patches@opensource.wolfsonmicro.com>,
	"open list:ARM/STI ARCHITECTURE" <kernel@stlinux.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Baruch Siach <baruch@tkos.co.il>,
	"open list:INTEL MANAGEMENT ENGINE mei" 
	<linux-kernel@vger.kernel.org>, Wim Van Sebroeck <wim@iguana.be>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
	<linux-samsung-soc@vger.kernel.org>, Lee Jones <lee@kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	Tomas Winkler <tomas.winkler@intel.com>,
	linux-watchdog@vger.kernel.org,
	Stephen Warren <swarren@wwwdotorg.org>,
	"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
	<linux-rpi-kernel@lists.infradead.org>,
	"open list:TEGRA ARCHITECTURE SUPPORT"
	<linux-tegra@vger.kernel.org>,
	"moderated list:ARM/U300 MACHINE SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
	Maxime Coquelin <maxime.coquelin@st.com>,
	Barry Song <baohua@kernel.org>,
	Johannes Thumshirn <morbidrsa@gmail.com>,
	Support Opensource <support.opensource@diasemi.com>,
	Andreas Werner <andreas.werner@men.de>,
	Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices
Date: Wed, 19 Aug 2015 08:44:19 +0200	[thread overview]
Message-ID: <20150819064419.GC9999@pengutronix.de> (raw)
In-Reply-To: <db7db9102158b87a4a7169e84e2272b3ba03f9f7.1439954581.git.panand@redhat.com>

Hello,

On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote:
> /sys/class/watchdog/watchdogn/device/modalias can help to identify the
> driver/module for a given watchdog node. However, many wdt devices does not set

s/es//

> its parent and so, we do not see an entry for device in sysfs for such devices.
> 
> This patch fixes parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device is populated.
> 
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can we identify driver for these devices.

I don't see why you don't use the platform device as parent for mpc8xxx.

Note however that I did several updates to the mpc8xxx driver which
probably conflict with setting the parent. I'll take care of that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2015-08-19  6:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19  3:28 [PATCH V3] Watchdog: Fix parent of watchdog_devices Pratyush Anand
2015-08-19  3:28 ` Pratyush Anand
2015-08-19  3:28 ` Pratyush Anand
2015-08-19  6:44 ` Uwe Kleine-König [this message]
2015-08-19  6:44   ` Uwe Kleine-König
2015-08-19  6:44   ` Uwe Kleine-König
2015-08-19  6:44   ` Uwe Kleine-König
2015-08-19 10:09 ` Thierry Reding
2015-08-19 10:09   ` Thierry Reding
2015-08-19 10:09   ` Thierry Reding
     [not found] ` <db7db9102158b87a4a7169e84e2272b3ba03f9f7.1439954581.git.panand-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-19 10:55   ` Maxime Coquelin
2015-08-19 10:55     ` Maxime Coquelin
2015-08-19 10:55     ` Maxime Coquelin
2015-08-19 15:38   ` Guenter Roeck
2015-08-19 15:38     ` Guenter Roeck
2015-08-19 15:38     ` Guenter Roeck
2015-08-20  8:30 ` Opensource [Adam Thomson]
2015-08-20  8:30   ` Opensource [Adam Thomson]
2015-08-20  8:30   ` Opensource [Adam Thomson]
2015-08-20  8:30   ` Opensource [Adam Thomson]
2015-08-20  8:35 ` Winkler, Tomas
2015-08-20  8:35   ` Winkler, Tomas
2015-08-20  8:35   ` Winkler, Tomas
2015-09-02  9:39 ` Charles Keepax
2015-09-02  9:39   ` Charles Keepax
2015-09-02  9:39   ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150819064419.GC9999@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=baruch@tkos.co.il \
    --cc=gnurou@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kernel@stlinux.com \
    --cc=kgene@kernel.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=panand@redhat.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomas.winkler@intel.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.