From: Tejun Heo <tj@kernel.org>
To: Eryu Guan <eguan@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com, axboe@fb.com,
Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes
Date: Thu, 20 Aug 2015 09:55:37 -0700 [thread overview]
Message-ID: <20150820165537.GA2044@mtj.duckdns.org> (raw)
In-Reply-To: <20150820143735.GJ17933@dhcp-13-216.nay.redhat.com>
Hello, Eryu. Thanks a lot for the trace.
So, this is from the end of the trace from the failed test.
...
kworker/u8:1-1563 [002] 22016.987530: xfs_writepage: dev 253:6 ino 0xef64fe pgoff 0x9ff000 size 0xa00000 offset 0 length 0 delalloc 1 unwritten 0
kworker/2:1-49 [002] 22017.373595: xfs_setfilesize: dev 253:6 ino 0xef6504 isize 0xa00000 disize 0x0 offset 0x0 count 10481664
...
Maybe I'm misunderstanding the code but all xfs_writepage() calls are
from unbound workqueues - the writeback workers - while
xfs_setfilesize() are from bound workqueues, so I wondered why that
was and looked at the code and the setsize functions are run off of a
separate work item which is queued from the end_bio callback and I
can't tell who would be waiting for them. Dave, what am I missing?
Thanks.
--
tejun
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Eryu Guan <eguan@redhat.com>
Cc: Dave Chinner <david@fromorbit.com>, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com, axboe@fb.com,
Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes
Date: Thu, 20 Aug 2015 09:55:37 -0700 [thread overview]
Message-ID: <20150820165537.GA2044@mtj.duckdns.org> (raw)
In-Reply-To: <20150820143735.GJ17933@dhcp-13-216.nay.redhat.com>
Hello, Eryu. Thanks a lot for the trace.
So, this is from the end of the trace from the failed test.
...
kworker/u8:1-1563 [002] 22016.987530: xfs_writepage: dev 253:6 ino 0xef64fe pgoff 0x9ff000 size 0xa00000 offset 0 length 0 delalloc 1 unwritten 0
kworker/2:1-49 [002] 22017.373595: xfs_setfilesize: dev 253:6 ino 0xef6504 isize 0xa00000 disize 0x0 offset 0x0 count 10481664
...
Maybe I'm misunderstanding the code but all xfs_writepage() calls are
from unbound workqueues - the writeback workers - while
xfs_setfilesize() are from bound workqueues, so I wondered why that
was and looked at the code and the setsize functions are run off of a
separate work item which is queued from the end_bio callback and I
can't tell who would be waiting for them. Dave, what am I missing?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-08-20 16:55 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 10:12 generic/04[89] fail on XFS due to change in writeback code Eryu Guan
2015-08-12 10:27 ` Eryu Guan
2015-08-13 0:44 ` generic/04[89] fail on XFS due to change in writeback code [4.2-rc1 regression] Dave Chinner
2015-08-13 0:44 ` Dave Chinner
2015-08-13 15:34 ` Tejun Heo
2015-08-13 15:34 ` Tejun Heo
2015-08-13 19:16 ` Tejun Heo
2015-08-13 22:44 ` [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes Tejun Heo
2015-08-13 22:44 ` Tejun Heo
2015-08-14 11:14 ` Jan Kara
2015-08-14 11:14 ` Jan Kara
2015-08-14 15:14 ` Damien Wyart
2015-08-14 15:14 ` Damien Wyart
2015-08-17 20:00 ` Tejun Heo
2015-08-17 20:00 ` Tejun Heo
2015-08-18 5:33 ` Damien Wyart
2015-08-18 5:33 ` Damien Wyart
2015-08-17 20:02 ` Tejun Heo
2015-08-17 20:02 ` Tejun Heo
2015-08-18 9:16 ` Jan Kara
2015-08-18 9:16 ` Jan Kara
2015-08-18 17:47 ` Tejun Heo
2015-08-18 17:47 ` Tejun Heo
2015-08-18 19:54 ` Tejun Heo
2015-08-18 19:54 ` Tejun Heo
2015-08-18 21:56 ` Dave Chinner
2015-08-18 21:56 ` Dave Chinner
2015-08-20 6:12 ` Eryu Guan
2015-08-20 6:12 ` Eryu Guan
2015-08-20 14:01 ` Eryu Guan
2015-08-20 14:36 ` Eryu Guan
2015-08-20 14:36 ` Eryu Guan
2015-08-20 14:37 ` Eryu Guan
2015-08-20 14:37 ` Eryu Guan
2015-08-20 16:55 ` Tejun Heo [this message]
2015-08-20 16:55 ` Tejun Heo
2015-08-20 23:04 ` Dave Chinner
2015-08-20 23:04 ` Dave Chinner
2015-08-24 18:10 ` Tejun Heo
2015-08-24 18:10 ` Tejun Heo
2015-08-24 22:27 ` Dave Chinner
2015-08-24 22:27 ` Dave Chinner
2015-08-24 22:53 ` Tejun Heo
2015-08-24 22:53 ` Tejun Heo
2015-08-21 10:20 ` Eryu Guan
2015-08-21 10:20 ` Eryu Guan
2015-08-22 0:30 ` Dave Chinner
2015-08-22 0:30 ` Dave Chinner
2015-08-22 4:46 ` Eryu Guan
2015-08-22 4:46 ` Eryu Guan
2015-08-24 1:11 ` Dave Chinner
2015-08-24 1:11 ` Dave Chinner
2015-08-24 3:18 ` Eryu Guan
2015-08-24 3:18 ` Eryu Guan
2015-08-24 6:24 ` Dave Chinner
2015-08-24 6:24 ` Dave Chinner
2015-08-24 8:34 ` Eryu Guan
2015-08-24 8:34 ` Eryu Guan
2015-08-24 8:55 ` Dave Chinner
2015-08-24 8:55 ` Dave Chinner
2015-08-24 9:19 ` Jan Kara
2015-08-24 9:19 ` Jan Kara
2015-08-24 14:51 ` Tejun Heo
2015-08-24 14:51 ` Tejun Heo
2015-08-24 17:11 ` Tejun Heo
2015-08-24 17:11 ` Tejun Heo
2015-08-24 19:08 ` Jan Kara
2015-08-24 19:08 ` Jan Kara
2015-08-24 19:32 ` Tejun Heo
2015-08-24 19:32 ` Tejun Heo
2015-08-24 21:09 ` Jan Kara
2015-08-24 21:09 ` Jan Kara
2015-08-24 21:45 ` Tejun Heo
2015-08-24 21:45 ` Tejun Heo
2015-08-24 22:54 ` Tejun Heo
2015-08-24 22:54 ` Tejun Heo
2015-08-24 22:57 ` Dave Chinner
2015-08-24 22:57 ` Dave Chinner
2015-08-25 18:11 ` [PATCH v2 block/for-linus] writeback: sync_inodes_sb() must write out I_DIRTY_TIME inodes and always call wait_sb_inodes() Tejun Heo
2015-08-25 18:11 ` Tejun Heo
2015-08-25 20:37 ` Jens Axboe
2015-08-25 20:37 ` Jens Axboe
2015-08-26 9:00 ` Jan Kara
2015-08-26 9:00 ` Jan Kara
2015-08-13 23:24 ` generic/04[89] fail on XFS due to change in writeback code [4.2-rc1 regression] Tejun Heo
2015-08-13 23:24 ` Tejun Heo
2015-08-14 6:19 ` Eryu Guan
2015-08-14 6:19 ` Eryu Guan
2015-08-17 20:27 ` Tejun Heo
2015-08-17 20:27 ` Tejun Heo
2015-08-18 3:57 ` Eryu Guan
2015-08-18 3:57 ` Eryu Guan
2015-08-18 5:31 ` Eryu Guan
2015-08-18 5:31 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820165537.GA2044@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=eguan@redhat.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.