All of lore.kernel.org
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [RFC v6 09/25] char/nvram: Use generic fixed_size_llseek()
Date: Sun, 23 Aug 2015 20:41:38 +1000	[thread overview]
Message-ID: <20150823104131.777727326@telegraphics.com.au> (raw)
In-Reply-To: 20150823104129.517600532@telegraphics.com.au

[-- Attachment #1: nvram-generic-llseek --]
[-- Type: text/plain, Size: 919 bytes --]

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

---
 drivers/char/nvram.c |   16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

Index: linux/drivers/char/nvram.c
===================================================================
--- linux.orig/drivers/char/nvram.c	2015-08-23 20:41:03.000000000 +1000
+++ linux/drivers/char/nvram.c	2015-08-23 20:41:04.000000000 +1000
@@ -235,21 +235,7 @@ EXPORT_SYMBOL(arch_nvram_ops);
 
 static loff_t nvram_misc_llseek(struct file *file, loff_t offset, int origin)
 {
-	switch (origin) {
-	case 0:
-		/* nothing to do */
-		break;
-	case 1:
-		offset += file->f_pos;
-		break;
-	case 2:
-		offset += NVRAM_BYTES;
-		break;
-	default:
-		return -EINVAL;
-	}
-
-	return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;
+	return fixed_size_llseek(file, offset, origin, nvram_size);
 }
 
 static ssize_t nvram_misc_read(struct file *file, char __user *buf,

WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: <linux-kernel@vger.kernel.org>, <linux-m68k@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [RFC v6 09/25] char/nvram: Use generic fixed_size_llseek()
Date: Sun, 23 Aug 2015 20:41:38 +1000	[thread overview]
Message-ID: <20150823104131.777727326@telegraphics.com.au> (raw)
In-Reply-To: 20150823104129.517600532@telegraphics.com.au

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

---
 drivers/char/nvram.c |   16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

Index: linux/drivers/char/nvram.c
===================================================================
--- linux.orig/drivers/char/nvram.c	2015-08-23 20:41:03.000000000 +1000
+++ linux/drivers/char/nvram.c	2015-08-23 20:41:04.000000000 +1000
@@ -235,21 +235,7 @@ EXPORT_SYMBOL(arch_nvram_ops);
 
 static loff_t nvram_misc_llseek(struct file *file, loff_t offset, int origin)
 {
-	switch (origin) {
-	case 0:
-		/* nothing to do */
-		break;
-	case 1:
-		offset += file->f_pos;
-		break;
-	case 2:
-		offset += NVRAM_BYTES;
-		break;
-	default:
-		return -EINVAL;
-	}
-
-	return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;
+	return fixed_size_llseek(file, offset, origin, nvram_size);
 }
 
 static ssize_t nvram_misc_read(struct file *file, char __user *buf,

WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: <linux-kernel@vger.kernel.org>, <linux-m68k@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [RFC v6 09/25] char/nvram: Use generic fixed_size_llseek()
Date: Sun, 23 Aug 2015 20:41:38 +1000	[thread overview]
Message-ID: <20150823104131.777727326@telegraphics.com.au> (raw)
In-Reply-To: 20150823104129.517600532@telegraphics.com.au

[-- Attachment #1: nvram-generic-llseek --]
[-- Type: text/plain, Size: 921 bytes --]

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

---
 drivers/char/nvram.c |   16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

Index: linux/drivers/char/nvram.c
===================================================================
--- linux.orig/drivers/char/nvram.c	2015-08-23 20:41:03.000000000 +1000
+++ linux/drivers/char/nvram.c	2015-08-23 20:41:04.000000000 +1000
@@ -235,21 +235,7 @@ EXPORT_SYMBOL(arch_nvram_ops);
 
 static loff_t nvram_misc_llseek(struct file *file, loff_t offset, int origin)
 {
-	switch (origin) {
-	case 0:
-		/* nothing to do */
-		break;
-	case 1:
-		offset += file->f_pos;
-		break;
-	case 2:
-		offset += NVRAM_BYTES;
-		break;
-	default:
-		return -EINVAL;
-	}
-
-	return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;
+	return fixed_size_llseek(file, offset, origin, nvram_size);
 }
 
 static ssize_t nvram_misc_read(struct file *file, char __user *buf,



  parent reply	other threads:[~2015-08-23 10:41 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 10:41 [RFC v6 00/25] Re-use nvram module Finn Thain
2015-08-23 10:41 ` Finn Thain
2015-08-23 10:41 ` [RFC v6 01/25] scsi/atari_scsi: Dont select CONFIG_NVRAM Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 02/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 03/25] m68k/atari: Replace nvram_{read, write}_byte with arch_nvram_ops Finn Thain
2015-08-23 10:41   ` [RFC v6 03/25] m68k/atari: Replace nvram_{read,write}_byte " Finn Thain
2015-08-23 10:41   ` [RFC v6 03/25] m68k/atari: Replace nvram_{read, write}_byte " Finn Thain
2015-10-14 11:19   ` [RFC v6 03/25] m68k/atari: Replace nvram_{read,write}_byte " Finn Thain
2015-08-23 10:41 ` [RFC v6 04/25] char/nvram: Re-order functions to remove forward declarations and #ifdefs Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 05/25] char/nvram: Adopt arch_nvram_ops Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 06/25] x86/thinkpad_acpi: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte() Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 07/25] char/nvram: Allow the set_checksum and initialize ioctls to be omitted Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 08/25] char/nvram: Implement NVRAM read/write methods Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` Finn Thain [this message]
2015-08-23 10:41   ` [RFC v6 09/25] char/nvram: Use generic fixed_size_llseek() Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 10/25] m68k/atari: Implement arch_nvram_ops methods and enable CONFIG_HAVE_ARCH_NVRAM_OPS Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 11/25] char/nvram: Add "devname:nvram" module alias Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 12/25] powerpc: Cleanup nvram includes Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 13/25] powerpc: Add missing ppc_md.nvram_size for CHRP and PowerMac Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 14/25] powerpc: Implement arch_nvram_ops.get_size() and remove old nvram_* exports Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 15/25] powerpc: Implement nvram sync ioctl Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 16/25] powerpc, fbdev: Use NV_CMODE and NV_VMODE only when CONFIG_PPC32 and CONFIG_PPC_PMAC Finn Thain
2015-08-23 10:41   ` [RFC v6 16/25] powerpc, fbdev: Use NV_CMODE and NV_VMODE only when CONFIG_PPC32 and CONFIG_PPC_PMAC and CONFIG_NVRAM Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 17/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_wri Finn Thain
2015-08-23 10:41   ` [RFC v6 17/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte() Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 18/25] nvram: Drop nvram_* symbol exports and prototypes Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 19/25] powerpc: Remove CONFIG_GENERIC_NVRAM and adopt CONFIG_HAVE_ARCH_NVRAM_OPS Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 20/25] char/generic_nvram: Remove as unused Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 21/25] powerpc: Adopt nvram module for PPC64 Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 22/25] m68k/mac: Adopt naming and calling conventions for PRAM routines Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 23/25] m68k/mac: Use macros for RTC accesses not magic numbers Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 24/25] m68k/mac: Fix PRAM accessors Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41 ` [RFC v6 25/25] m68k: Dispatch nvram_ops calls to Atari or Mac functions Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-08-23 10:41   ` Finn Thain
2015-10-11 20:06 ` [RFC v6 00/25] Re-use nvram module Laurent Vivier
2015-10-12  2:32   ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150823104131.777727326@telegraphics.com.au \
    --to=fthain@telegraphics.com.au \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.