All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: George Spelvin <linux@horizon.com>,
	dave@sr71.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	peterz@infradead.org, riel@redhat.com, rientjes@google.com,
	torvalds@linux-foundation.org
Subject: Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info
Date: Mon, 24 Aug 2015 09:00:01 +0200	[thread overview]
Message-ID: <20150824070001.GB13082@gmail.com> (raw)
In-Reply-To: <87h9npwtx3.fsf@rasmusvillemoes.dk>


* Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> I was curious why these fields were ever added to /proc/meminfo, and dug
> up this:
> 
> commit d262ee3ee6ba4f5f6125571d93d9d63191d2ef76
> Author: Andrew Morton <akpm@digeo.com>
> Date:   Sat Apr 12 12:59:04 2003 -0700
> 
>     [PATCH] vmalloc stats in /proc/meminfo
>     
>     From: Matt Porter <porter@cox.net>
>     
>     There was a thread a while back on lkml where Dave Hansen proposed this
>     simple vmalloc usage reporting patch.  The thread pretty much died out as
>     most people seemed focused on what VM loading type bugs it could solve.  I
>     had posted that this type of information was really valuable in debugging
>     embedded Linux board ports.  A common example is where people do arch
>     specific setup that limits there vmalloc space and then they find modules
>     won't load.  ;) Having the Vmalloc* info readily available is real useful in
>     helping folks to fix their kernel ports.
> 
> That thread is at <http://thread.gmane.org/gmane.linux.kernel/53360>.
> 
> [Maybe one could just remove the fields and see if anybody actually
> notices/cares any longer. Or, if they are only used by kernel
> developers, put them in their own file.]

So instead of removing the fields (which I'm quite sure is an ABI breaker as it 
could break less robust /proc/meminfo parsers and scripts), we could just report 
'0' all the time - and have the real info somewhere else?

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: George Spelvin <linux@horizon.com>,
	dave@sr71.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	peterz@infradead.org, riel@redhat.com, rientjes@google.com,
	torvalds@linux-foundation.org
Subject: Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info
Date: Mon, 24 Aug 2015 09:00:01 +0200	[thread overview]
Message-ID: <20150824070001.GB13082@gmail.com> (raw)
In-Reply-To: <87h9npwtx3.fsf@rasmusvillemoes.dk>


* Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> I was curious why these fields were ever added to /proc/meminfo, and dug
> up this:
> 
> commit d262ee3ee6ba4f5f6125571d93d9d63191d2ef76
> Author: Andrew Morton <akpm@digeo.com>
> Date:   Sat Apr 12 12:59:04 2003 -0700
> 
>     [PATCH] vmalloc stats in /proc/meminfo
>     
>     From: Matt Porter <porter@cox.net>
>     
>     There was a thread a while back on lkml where Dave Hansen proposed this
>     simple vmalloc usage reporting patch.  The thread pretty much died out as
>     most people seemed focused on what VM loading type bugs it could solve.  I
>     had posted that this type of information was really valuable in debugging
>     embedded Linux board ports.  A common example is where people do arch
>     specific setup that limits there vmalloc space and then they find modules
>     won't load.  ;) Having the Vmalloc* info readily available is real useful in
>     helping folks to fix their kernel ports.
> 
> That thread is at <http://thread.gmane.org/gmane.linux.kernel/53360>.
> 
> [Maybe one could just remove the fields and see if anybody actually
> notices/cares any longer. Or, if they are only used by kernel
> developers, put them in their own file.]

So instead of removing the fields (which I'm quite sure is an ABI breaker as it 
could break less robust /proc/meminfo parsers and scripts), we could just report 
'0' all the time - and have the real info somewhere else?

Thanks,

	Ingo

  reply	other threads:[~2015-08-24  7:00 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23  4:48 [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics George Spelvin
2015-08-23  4:48 ` George Spelvin
2015-08-23  6:04 ` Ingo Molnar
2015-08-23  6:04   ` Ingo Molnar
2015-08-23  6:46   ` George Spelvin
2015-08-23  6:46     ` George Spelvin
2015-08-23  8:17     ` [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar
2015-08-23  8:17       ` Ingo Molnar
2015-08-23 20:53       ` Rasmus Villemoes
2015-08-23 20:53         ` Rasmus Villemoes
2015-08-24  6:58         ` Ingo Molnar
2015-08-24  6:58           ` Ingo Molnar
2015-08-24  8:39           ` Rasmus Villemoes
2015-08-24  8:39             ` Rasmus Villemoes
2015-08-23 21:56       ` Rasmus Villemoes
2015-08-23 21:56         ` Rasmus Villemoes
2015-08-24  7:00         ` Ingo Molnar [this message]
2015-08-24  7:00           ` Ingo Molnar
2015-08-25 16:39         ` Linus Torvalds
2015-08-25 16:39           ` Linus Torvalds
2015-08-25 17:03           ` Linus Torvalds
2015-08-25 17:03             ` Linus Torvalds
2015-08-24  1:04       ` George Spelvin
2015-08-24  1:04         ` George Spelvin
2015-08-24  7:34         ` [PATCH 3/3 v4] " Ingo Molnar
2015-08-24  7:34           ` Ingo Molnar
2015-08-24  7:47           ` Ingo Molnar
2015-08-24  7:47             ` Ingo Molnar
2015-08-24  7:50             ` [PATCH 3/3 v5] " Ingo Molnar
2015-08-24  7:50               ` Ingo Molnar
2015-08-24 12:54               ` George Spelvin
2015-08-24 12:54                 ` George Spelvin
2015-08-25  9:56                 ` [PATCH 3/3 v6] " Ingo Molnar
2015-08-25  9:56                   ` Ingo Molnar
2015-08-25 10:36                   ` George Spelvin
2015-08-25 10:36                     ` George Spelvin
2015-08-25 12:59                   ` Peter Zijlstra
2015-08-25 12:59                     ` Peter Zijlstra
2015-08-25 14:19                   ` Rasmus Villemoes
2015-08-25 14:19                     ` Rasmus Villemoes
2015-08-25 15:11                     ` George Spelvin
2015-08-25 15:11                       ` George Spelvin
2015-08-24 13:11           ` [PATCH 3/3 v4] " John Stoffel
2015-08-24 13:11             ` John Stoffel
2015-08-24 15:11             ` George Spelvin
2015-08-24 15:11               ` George Spelvin
2015-08-24 15:55               ` John Stoffel
2015-08-24 15:55                 ` John Stoffel
2015-08-25 12:46       ` [PATCH 3/3 v3] " Peter Zijlstra
2015-08-25 12:46         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150824070001.GB13082@gmail.com \
    --to=mingo@kernel.org \
    --cc=dave@sr71.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@horizon.com \
    --cc=linux@rasmusvillemoes.dk \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.