From: Andrew Lunn <andrew@lunn.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/3] backlight: add led-backlight driver
Date: Tue, 25 Aug 2015 12:39:52 +0000 [thread overview]
Message-ID: <20150825123952.GA18009@lunn.ch> (raw)
In-Reply-To: <1440502442-19531-3-git-send-email-tomi.valkeinen@ti.com>
On Tue, Aug 25, 2015 at 02:34:01PM +0300, Tomi Valkeinen wrote:
> This patch adds a led-backlight driver (led_bl), which is similar to
> pwm_bl except the driver uses a LED class driver to adjust the
> brightness in the HW.
Shouldn't this be sending an event to drivers/leds/trigger/kedtrig-backlight.c
Calling led_set_brightness() from outside of drivers/leds is pretty
much unheard of. It is normal to have a trigger to do this. So why not
use the exiting backlight trigger?
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/3] backlight: add led-backlight driver
Date: Tue, 25 Aug 2015 14:39:52 +0200 [thread overview]
Message-ID: <20150825123952.GA18009@lunn.ch> (raw)
In-Reply-To: <1440502442-19531-3-git-send-email-tomi.valkeinen@ti.com>
On Tue, Aug 25, 2015 at 02:34:01PM +0300, Tomi Valkeinen wrote:
> This patch adds a led-backlight driver (led_bl), which is similar to
> pwm_bl except the driver uses a LED class driver to adjust the
> brightness in the HW.
Shouldn't this be sending an event to drivers/leds/trigger/kedtrig-backlight.c
Calling led_set_brightness() from outside of drivers/leds is pretty
much unheard of. It is normal to have a trigger to do this. So why not
use the exiting backlight trigger?
Andrew
next prev parent reply other threads:[~2015-08-25 12:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 11:33 [PATCH 0/3] backlight: led-backlight driver Tomi Valkeinen
2015-08-25 11:33 ` Tomi Valkeinen
2015-08-25 11:34 ` [PATCH 1/3] leds: Add of_led_get() and led_put() Tomi Valkeinen
2015-08-25 11:34 ` Tomi Valkeinen
2015-08-25 12:18 ` Andrew Lunn
2015-08-25 12:18 ` Andrew Lunn
2015-08-25 12:53 ` Tomi Valkeinen
2015-08-25 12:53 ` Tomi Valkeinen
2015-09-08 11:23 ` Tomi Valkeinen
2015-09-08 11:23 ` Tomi Valkeinen
2015-08-25 13:25 ` Jacek Anaszewski
2015-08-25 13:25 ` Jacek Anaszewski
2015-09-07 12:35 ` Tomi Valkeinen
2015-09-07 12:35 ` Tomi Valkeinen
2015-09-07 14:11 ` Jacek Anaszewski
2015-09-07 14:11 ` Jacek Anaszewski
2015-09-08 7:10 ` Tomi Valkeinen
2015-09-08 7:10 ` Tomi Valkeinen
2015-09-08 9:21 ` Jacek Anaszewski
2015-09-08 9:21 ` Jacek Anaszewski
2015-09-08 10:41 ` Tomi Valkeinen
2015-09-08 10:41 ` Tomi Valkeinen
2015-09-08 10:57 ` Jacek Anaszewski
2015-09-08 10:57 ` Jacek Anaszewski
2015-09-07 13:18 ` Tomi Valkeinen
2015-09-07 13:18 ` Tomi Valkeinen
2015-09-07 14:10 ` Jacek Anaszewski
2015-09-07 14:10 ` Jacek Anaszewski
2015-08-25 11:34 ` [PATCH 2/3] backlight: add led-backlight driver Tomi Valkeinen
2015-08-25 11:34 ` Tomi Valkeinen
2015-08-25 12:39 ` Andrew Lunn [this message]
2015-08-25 12:39 ` Andrew Lunn
2015-08-25 13:00 ` Tomi Valkeinen
2015-08-25 13:00 ` Tomi Valkeinen
2015-08-25 11:34 ` [PATCH 3/3] devicetree: Add led-backlight binding Tomi Valkeinen
2015-08-25 11:34 ` Tomi Valkeinen
2015-08-25 13:39 ` Jacek Anaszewski
2015-08-25 13:39 ` Jacek Anaszewski
2015-08-25 15:41 ` Tomi Valkeinen
2015-08-25 15:41 ` Tomi Valkeinen
2015-08-26 7:07 ` Jacek Anaszewski
2015-08-26 7:07 ` Jacek Anaszewski
2015-08-26 9:11 ` Tomi Valkeinen
2015-08-26 9:11 ` Tomi Valkeinen
2015-08-26 9:56 ` Jacek Anaszewski
2015-08-26 9:56 ` Jacek Anaszewski
2015-08-31 23:12 ` Rob Herring
2015-08-31 23:12 ` Rob Herring
2015-09-04 15:03 ` Jacek Anaszewski
2015-09-04 15:03 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825123952.GA18009@lunn.ch \
--to=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.