Re: [PATCH 2/3] backlight: add led-backlight driver

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]



On 25/08/15 15:39, Andrew Lunn wrote:
> On Tue, Aug 25, 2015 at 02:34:01PM +0300, Tomi Valkeinen wrote:
>> This patch adds a led-backlight driver (led_bl), which is similar to
>> pwm_bl except the driver uses a LED class driver to adjust the
>> brightness in the HW.
> 
> Shouldn't this be sending an event to drivers/leds/trigger/kedtrig-backlight.c
>
> Calling led_set_brightness() from outside of drivers/leds is pretty
> much unheard of. It is normal to have a trigger to do this. So why not
> use the exiting backlight trigger?

ledtrig-backlight.c is based on fbdev, and I want the backlight to work
also with DRM. And I want the backlight device to be a proper backlight
device, i.e. something I can pass data to from the DT.

So, I could create a new trigger, say, "bldev" trigger, which would
create a backlight device. But then I could not pass any info to it via DT.

This patch was the only working solution I could figure out, but I don't
have much experience with leds, so I might be missing something.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]