From: Brian Norris <computersforpeace@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: dwmw2@infradead.org, sebastian@breakpoint.cc, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
shawn.guo@linaro.org, kernel@pengutronix.de,
boris.brezillon@free-electrons.com, marb@ixxat.de,
aaron@tastycactus.com, bpringlemeir@gmail.com,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, albert.aribaud@3adev.fr,
klimov.linux@gmail.com, Bill Pringlemeir <bpringlemeir@nbsps.com>
Subject: Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 25 Aug 2015 13:34:12 -0700 [thread overview]
Message-ID: <20150825203412.GM81844@google.com> (raw)
In-Reply-To: <1438594050-4595-2-git-send-email-stefan@agner.ch>
One more thing...
On Mon, Aug 03, 2015 at 11:27:26AM +0200, Stefan Agner wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -0,0 +1,645 @@
...
> +struct vf610_nfc {
> + struct mtd_info mtd;
> + struct nand_chip chip;
> + struct device *dev;
> + void __iomem *regs;
> + struct completion cmd_done;
> + uint buf_offset;
> + int page_sz;
AFAICT (even with the 2nd patch), you never really use this field. You
just set it/increment it, but don't use it for anything. Kill it?
> + /* Status and ID are in alternate locations. */
> + int alt_buf;
> +#define ALT_BUF_ID 1
> +#define ALT_BUF_STAT 2
> +#define ALT_BUF_ONFI 3
> + struct clk *clk;
> +};
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 25 Aug 2015 13:34:12 -0700 [thread overview]
Message-ID: <20150825203412.GM81844@google.com> (raw)
In-Reply-To: <1438594050-4595-2-git-send-email-stefan@agner.ch>
One more thing...
On Mon, Aug 03, 2015 at 11:27:26AM +0200, Stefan Agner wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -0,0 +1,645 @@
...
> +struct vf610_nfc {
> + struct mtd_info mtd;
> + struct nand_chip chip;
> + struct device *dev;
> + void __iomem *regs;
> + struct completion cmd_done;
> + uint buf_offset;
> + int page_sz;
AFAICT (even with the 2nd patch), you never really use this field. You
just set it/increment it, but don't use it for anything. Kill it?
> + /* Status and ID are in alternate locations. */
> + int alt_buf;
> +#define ALT_BUF_ID 1
> +#define ALT_BUF_STAT 2
> +#define ALT_BUF_ONFI 3
> + struct clk *clk;
> +};
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
marb-Z4QKGCRq86k@public.gmane.org,
aaron-yuhzfaV+M/Wz3Dx2OeFgIA@public.gmane.org,
bpringlemeir-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
albert.aribaud-iEu9NFBzPZE@public.gmane.org,
klimov.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Bill Pringlemeir
<bpringlemeir-ygJ1pmMJ17cAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 25 Aug 2015 13:34:12 -0700 [thread overview]
Message-ID: <20150825203412.GM81844@google.com> (raw)
In-Reply-To: <1438594050-4595-2-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
One more thing...
On Mon, Aug 03, 2015 at 11:27:26AM +0200, Stefan Agner wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -0,0 +1,645 @@
...
> +struct vf610_nfc {
> + struct mtd_info mtd;
> + struct nand_chip chip;
> + struct device *dev;
> + void __iomem *regs;
> + struct completion cmd_done;
> + uint buf_offset;
> + int page_sz;
AFAICT (even with the 2nd patch), you never really use this field. You
just set it/increment it, but don't use it for anything. Kill it?
> + /* Status and ID are in alternate locations. */
> + int alt_buf;
> +#define ALT_BUF_ID 1
> +#define ALT_BUF_STAT 2
> +#define ALT_BUF_ONFI 3
> + struct clk *clk;
> +};
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-25 20:34 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 9:27 [PATCH v10 0/5] mtd: nand: vf610_nfc: Freescale NFC for VF610 Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 9:27 ` [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-25 20:16 ` Brian Norris
2015-08-25 20:16 ` Brian Norris
2015-08-27 1:02 ` Stefan Agner
2015-08-27 1:02 ` Stefan Agner
2015-08-27 16:34 ` Brian Norris
2015-08-27 16:34 ` Brian Norris
2015-08-27 16:34 ` Brian Norris
2015-08-27 17:25 ` Stefan Agner
2015-08-27 17:25 ` Stefan Agner
2015-08-27 17:25 ` Stefan Agner
2015-08-25 20:34 ` Brian Norris [this message]
2015-08-25 20:34 ` Brian Norris
2015-08-25 20:34 ` Brian Norris
2015-08-27 1:10 ` Stefan Agner
2015-08-27 1:10 ` Stefan Agner
2015-08-27 1:10 ` Stefan Agner
2015-08-27 16:47 ` Brian Norris
2015-08-27 16:47 ` Brian Norris
2015-08-03 9:27 ` [PATCH v10 2/5] mtd: nand: vf610_nfc: add hardware BCH-ECC support Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 9:28 ` Stefan Agner
2015-08-03 9:28 ` Stefan Agner
2015-08-25 19:54 ` Brian Norris
2015-08-25 19:54 ` Brian Norris
2015-08-25 19:54 ` Brian Norris
2015-08-25 20:43 ` Boris Brezillon
2015-08-25 20:43 ` Boris Brezillon
2015-08-26 17:57 ` Stefan Agner
2015-08-26 17:57 ` Stefan Agner
2015-08-26 21:34 ` Brian Norris
2015-08-26 21:34 ` Brian Norris
2015-08-28 21:14 ` Bill Pringlemeir
2015-08-28 21:14 ` Bill Pringlemeir
2015-08-28 21:14 ` Bill Pringlemeir
2015-08-03 9:27 ` [PATCH v10 3/5] mtd: nand: vf610_nfc: add device tree bindings Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-25 20:25 ` Brian Norris
2015-08-25 20:25 ` Brian Norris
2015-08-25 20:25 ` Brian Norris
2015-08-26 15:26 ` Bill Pringlemeir
2015-08-26 15:26 ` Bill Pringlemeir
2015-08-26 15:26 ` Bill Pringlemeir
2015-08-26 15:39 ` Boris Brezillon
2015-08-26 15:39 ` Boris Brezillon
2015-08-26 15:39 ` Boris Brezillon
2015-08-26 21:15 ` Stefan Agner
2015-08-26 21:15 ` Stefan Agner
2015-08-26 21:15 ` Stefan Agner
2015-08-26 21:28 ` Brian Norris
2015-08-26 21:28 ` Brian Norris
2015-08-26 21:28 ` Brian Norris
2015-08-03 9:27 ` [PATCH v10 4/5] ARM: dts: vf610twr: add NAND flash controller peripherial Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 9:27 ` [PATCH v10 5/5] ARM: dts: vf-colibri: enable NAND flash controller Stefan Agner
2015-08-03 9:27 ` Stefan Agner
2015-08-03 10:35 ` [PATCH v10 0/5] mtd: nand: vf610_nfc: Freescale NFC for VF610 Albert ARIBAUD
2015-08-03 10:35 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825203412.GM81844@google.com \
--to=computersforpeace@gmail.com \
--cc=aaron@tastycactus.com \
--cc=albert.aribaud@3adev.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=bpringlemeir@gmail.com \
--cc=bpringlemeir@nbsps.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=klimov.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marb@ixxat.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian@breakpoint.cc \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.