All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: implement mesh support
Date: Sat, 29 Aug 2015 18:25:31 -0400	[thread overview]
Message-ID: <20150829222531.GA8604@localhost> (raw)
In-Reply-To: <CAKf6xpsaygeFJyX_LKH2r82P2Xvih1GGBTAspKtCsZbBcVO9Ug@mail.gmail.com>

On Sat, Aug 29, 2015 at 01:11:03PM -0400, Jason Andryuk wrote:
> Is there a reason to hide rawmode behind a modparam, or should the
> modparam just be removed?  Just let the driver set
> ATH10K_FLAG_RAW_MODE when ATH10K_FW_FEATURE_RAW_MODE_SUPPORT is
> detected?

Yes: you don't want to enable raw mode TX / RX decap in the normal
case because it's fairly inefficient compared to "native" wifi mode,
according to my understanding.  The latter doesn't support mesh framing
however.

> Does struct ieee80211_iface_limit need to be conditional on firmware
> support as well or does interface_modes (below) gate use of
> MESH_POINT?

If you advertise a combination that isn't supported by interface modes,
I believe you'll get a kernel warning when the wiphy is registered.

> 
> > @@ -6998,7 +7020,8 @@ int ath10k_mac_register(struct ath10k *ar)
> >
> >         ar->hw->wiphy->interface_modes =
> >                 BIT(NL80211_IFTYPE_STATION) |
> > -               BIT(NL80211_IFTYPE_AP);
> > +               BIT(NL80211_IFTYPE_AP) |
> > +               BIT(NL80211_IFTYPE_MESH_POINT);
> 
> Set BIT(NL80211_IFTYPE_MESH_POINT) conditionally if ATH10K_FLAG_RAW_MODE is set?

Yes, this was discussed on the ath10k mailing list and I'll probably do
it in a follow-up patch.  It is a little messy because it will involve
casting away a const somewhere.

-- 
Bob Copeland %% http://bobcopeland.com/

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: implement mesh support
Date: Sat, 29 Aug 2015 18:25:31 -0400	[thread overview]
Message-ID: <20150829222531.GA8604@localhost> (raw)
In-Reply-To: <CAKf6xpsaygeFJyX_LKH2r82P2Xvih1GGBTAspKtCsZbBcVO9Ug@mail.gmail.com>

On Sat, Aug 29, 2015 at 01:11:03PM -0400, Jason Andryuk wrote:
> Is there a reason to hide rawmode behind a modparam, or should the
> modparam just be removed?  Just let the driver set
> ATH10K_FLAG_RAW_MODE when ATH10K_FW_FEATURE_RAW_MODE_SUPPORT is
> detected?

Yes: you don't want to enable raw mode TX / RX decap in the normal
case because it's fairly inefficient compared to "native" wifi mode,
according to my understanding.  The latter doesn't support mesh framing
however.

> Does struct ieee80211_iface_limit need to be conditional on firmware
> support as well or does interface_modes (below) gate use of
> MESH_POINT?

If you advertise a combination that isn't supported by interface modes,
I believe you'll get a kernel warning when the wiphy is registered.

> 
> > @@ -6998,7 +7020,8 @@ int ath10k_mac_register(struct ath10k *ar)
> >
> >         ar->hw->wiphy->interface_modes =
> >                 BIT(NL80211_IFTYPE_STATION) |
> > -               BIT(NL80211_IFTYPE_AP);
> > +               BIT(NL80211_IFTYPE_AP) |
> > +               BIT(NL80211_IFTYPE_MESH_POINT);
> 
> Set BIT(NL80211_IFTYPE_MESH_POINT) conditionally if ATH10K_FLAG_RAW_MODE is set?

Yes, this was discussed on the ath10k mailing list and I'll probably do
it in a follow-up patch.  It is a little messy because it will involve
casting away a const somewhere.

-- 
Bob Copeland %% http://bobcopeland.com/

  reply	other threads:[~2015-08-29 22:25 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 10:57 [PATCH 0/3] mesh support for ath10k Bob Copeland
2015-08-27 10:57 ` Bob Copeland
2015-08-27 10:57 ` [PATCH 1/3] ath10k: enable monitor when OTHER_BSS requested Bob Copeland
2015-08-27 10:57   ` Bob Copeland
2015-08-27 10:57 ` [PATCH 2/3] ath10k: check for encryption before adding MIC_LEN Bob Copeland
2015-08-27 10:57   ` Bob Copeland
2015-08-27 10:57 ` [PATCH 3/3] ath10k: implement mesh support Bob Copeland
2015-08-27 10:57   ` Bob Copeland
2015-08-29 17:11   ` Jason Andryuk
2015-08-29 17:11     ` Jason Andryuk
2015-08-29 22:25     ` Bob Copeland [this message]
2015-08-29 22:25       ` Bob Copeland
2015-08-30 17:43       ` Yeoh Chun-Yeow
2015-08-30 17:43         ` Yeoh Chun-Yeow
2015-09-16 12:39         ` Bob Copeland
2015-09-16 12:39           ` Bob Copeland
2015-09-17 17:48           ` Yeoh Chun-Yeow
2015-09-17 17:48             ` Yeoh Chun-Yeow
2015-09-17 23:56             ` Peter Oh
2015-09-17 23:56               ` Peter Oh
2015-09-01  3:02       ` Jason Andryuk
2015-09-01  3:02         ` Jason Andryuk
2015-09-09  7:57   ` Kalle Valo
2015-09-09  7:57     ` Kalle Valo
2015-09-09  9:10     ` Kalle Valo
2015-09-09  9:10       ` Kalle Valo
2015-09-09 16:49       ` Bob Copeland
2015-09-09 16:49         ` Bob Copeland
2015-09-10  5:46         ` Kalle Valo
2015-09-10  5:46           ` Kalle Valo
2015-09-10  7:22         ` Johannes Berg
2015-09-10  7:22           ` Johannes Berg
2015-09-15  7:21           ` Peter Oh
2015-09-15  7:21             ` Peter Oh
2015-09-16 12:32             ` Bob Copeland
2015-09-16 12:32               ` Bob Copeland
2015-09-09 11:08     ` Bob Copeland
2015-09-09 11:08       ` Bob Copeland
  -- strict thread matches above, loose matches on Subject: below --
2015-08-16 15:25 [PATCH 0/3] ath10k " Bob Copeland
2015-08-16 15:25 ` [PATCH 3/3] ath10k: implement " Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150829222531.GA8604@localhost \
    --to=me@bobcopeland.com \
    --cc=ath10k@lists.infradead.org \
    --cc=jandryuk@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.