All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: implement mesh support
Date: Thu, 10 Sep 2015 08:46:54 +0300	[thread overview]
Message-ID: <87oaha4yi9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20150909164945.GA4062@localhost> (Bob Copeland's message of "Wed, 9 Sep 2015 12:49:45 -0400")

Bob Copeland <me@bobcopeland.com> writes:

> On Wed, Sep 09, 2015 at 12:10:38PM +0300, Kalle Valo wrote:
>> > I did a quick smoke test and saw the splat below. It's this warning from
>> > cfg80211:
>> >
>> > 			/*
>> > 			 * Don't advertise an unsupported type
>> > 			 * in a combination.
>> > 			 */
>> > 			if (WARN_ON((wiphy->interface_modes & types) != types))
>> > 				return -EINVAL;
>
> OK, this happens when mesh is configured out (we mask off the mesh
> interface_modes internally but not the types).  Sent an updated version
> with appropriate ifdefs added.

Indeed, when I enabled CONFIG_MAC80211_MESH I didn't see the WARN_ON()
anymore. (I haven't tested your latest version yet, will do it soon)

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH 3/3] ath10k: implement mesh support
Date: Thu, 10 Sep 2015 08:46:54 +0300	[thread overview]
Message-ID: <87oaha4yi9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20150909164945.GA4062@localhost> (Bob Copeland's message of "Wed, 9 Sep 2015 12:49:45 -0400")

Bob Copeland <me@bobcopeland.com> writes:

> On Wed, Sep 09, 2015 at 12:10:38PM +0300, Kalle Valo wrote:
>> > I did a quick smoke test and saw the splat below. It's this warning from
>> > cfg80211:
>> >
>> > 			/*
>> > 			 * Don't advertise an unsupported type
>> > 			 * in a combination.
>> > 			 */
>> > 			if (WARN_ON((wiphy->interface_modes & types) != types))
>> > 				return -EINVAL;
>
> OK, this happens when mesh is configured out (we mask off the mesh
> interface_modes internally but not the types).  Sent an updated version
> with appropriate ifdefs added.

Indeed, when I enabled CONFIG_MAC80211_MESH I didn't see the WARN_ON()
anymore. (I haven't tested your latest version yet, will do it soon)

-- 
Kalle Valo

  reply	other threads:[~2015-09-10  5:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 10:57 [PATCH 0/3] mesh support for ath10k Bob Copeland
2015-08-27 10:57 ` Bob Copeland
2015-08-27 10:57 ` [PATCH 1/3] ath10k: enable monitor when OTHER_BSS requested Bob Copeland
2015-08-27 10:57   ` Bob Copeland
2015-08-27 10:57 ` [PATCH 2/3] ath10k: check for encryption before adding MIC_LEN Bob Copeland
2015-08-27 10:57   ` Bob Copeland
2015-08-27 10:57 ` [PATCH 3/3] ath10k: implement mesh support Bob Copeland
2015-08-27 10:57   ` Bob Copeland
2015-08-29 17:11   ` Jason Andryuk
2015-08-29 17:11     ` Jason Andryuk
2015-08-29 22:25     ` Bob Copeland
2015-08-29 22:25       ` Bob Copeland
2015-08-30 17:43       ` Yeoh Chun-Yeow
2015-08-30 17:43         ` Yeoh Chun-Yeow
2015-09-16 12:39         ` Bob Copeland
2015-09-16 12:39           ` Bob Copeland
2015-09-17 17:48           ` Yeoh Chun-Yeow
2015-09-17 17:48             ` Yeoh Chun-Yeow
2015-09-17 23:56             ` Peter Oh
2015-09-17 23:56               ` Peter Oh
2015-09-01  3:02       ` Jason Andryuk
2015-09-01  3:02         ` Jason Andryuk
2015-09-09  7:57   ` Kalle Valo
2015-09-09  7:57     ` Kalle Valo
2015-09-09  9:10     ` Kalle Valo
2015-09-09  9:10       ` Kalle Valo
2015-09-09 16:49       ` Bob Copeland
2015-09-09 16:49         ` Bob Copeland
2015-09-10  5:46         ` Kalle Valo [this message]
2015-09-10  5:46           ` Kalle Valo
2015-09-10  7:22         ` Johannes Berg
2015-09-10  7:22           ` Johannes Berg
2015-09-15  7:21           ` Peter Oh
2015-09-15  7:21             ` Peter Oh
2015-09-16 12:32             ` Bob Copeland
2015-09-16 12:32               ` Bob Copeland
2015-09-09 11:08     ` Bob Copeland
2015-09-09 11:08       ` Bob Copeland
  -- strict thread matches above, loose matches on Subject: below --
2015-08-16 15:25 [PATCH 0/3] ath10k " Bob Copeland
2015-08-16 15:25 ` [PATCH 3/3] ath10k: implement " Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oaha4yi9.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.