From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
patchwork-lst@pengutronix.de, kernel@pengutronix.de,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/8] clk: imx25: retain early UART clocks during kernel init
Date: Mon, 7 Sep 2015 11:10:05 +0200 [thread overview]
Message-ID: <20150907091005.GV9999@pengutronix.de> (raw)
In-Reply-To: <20150906142315.GA30746@tiger>
On Sun, Sep 06, 2015 at 10:23:15PM +0800, Shawn Guo wrote:
>
> I prefer to code it like:
>
> static struct clk **uart_clks[] __initdata = {
> &clk[uart_ipg_per],
> &clk[uart1_ipg],
> &clk[uart2_ipg],
> &clk[uart3_ipg],
> &clk[uart4_ipg],
> &clk[uart5_ipg],
> NULL
> };
And maybe also use mx25_ as prefix to make the name unique.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/8] clk: imx25: retain early UART clocks during kernel init
Date: Mon, 7 Sep 2015 11:10:05 +0200 [thread overview]
Message-ID: <20150907091005.GV9999@pengutronix.de> (raw)
In-Reply-To: <20150906142315.GA30746@tiger>
On Sun, Sep 06, 2015 at 10:23:15PM +0800, Shawn Guo wrote:
>
> I prefer to code it like:
>
> static struct clk **uart_clks[] __initdata = {
> &clk[uart_ipg_per],
> &clk[uart1_ipg],
> &clk[uart2_ipg],
> &clk[uart3_ipg],
> &clk[uart4_ipg],
> &clk[uart5_ipg],
> NULL
> };
And maybe also use mx25_ as prefix to make the name unique.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-09-07 9:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 16:00 [PATCH v2 0/8] i.MX early debug UART clock fixes Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 1/8] clk: imx: add common logic to detect early UART usage Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-06 14:21 ` Shawn Guo
2015-09-06 14:21 ` Shawn Guo
2015-09-07 9:06 ` Uwe Kleine-König
2015-09-07 9:06 ` Uwe Kleine-König
2015-09-07 9:15 ` Lucas Stach
2015-09-07 9:15 ` Lucas Stach
2015-09-07 9:50 ` Uwe Kleine-König
2015-09-07 9:50 ` Uwe Kleine-König
2015-09-04 16:00 ` [PATCH v2 2/8] clk: imx25: retain early UART clocks during kernel init Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-06 14:23 ` Shawn Guo
2015-09-06 14:23 ` Shawn Guo
2015-09-07 9:10 ` Uwe Kleine-König [this message]
2015-09-07 9:10 ` Uwe Kleine-König
2015-09-07 9:18 ` Lucas Stach
2015-09-07 9:18 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 3/8] clk: imx27: " Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 4/8] clk: imx31: " Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 5/8] clk: imx35: " Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 6/8] clk: imx5: " Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 7/8] clk: imx6: " Lucas Stach
2015-09-04 16:00 ` Lucas Stach
2015-09-04 16:00 ` [PATCH v2 8/8] clk: imx7d: " Lucas Stach
2015-09-04 16:00 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907091005.GV9999@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=patchwork-lst@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.