All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Archit Taneja <archit@ti.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] drm/mgag200: Fix calling drm_fb_helper_fini() twice
Date: Thu, 17 Sep 2015 16:47:40 +0530	[thread overview]
Message-ID: <20150917111740.GD20514@sudip-pc> (raw)
In-Reply-To: <55FA9BDD.7010603@codeaurora.org>

On Thu, Sep 17, 2015 at 04:24:21PM +0530, Archit Taneja wrote:
> 
> 
> On 9/17/2015 2:04 PM, Ingo Molnar wrote:
> >
> >
> >* Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> >
> >>So this patch was whitespace damaged - I applied it by hand and made the commit
> >
> >>below. This has solved the crash, thanks Archit!
> >
> >
> >
> >Spoke too soon - the attached (allyesconfig-ish) config still crashes, first there
> >
> >are a handful of kobject debug warnings, then:
> 
> The error handling in the driver is bad. The main problem is that
> the driver_load op calls mgag200_driver_unload if anything fails,
> which doesn't work well if driver_load fails mid way.
mgag200_driver_unload is trying to unload everything evenif that has not
succeeded in initializing. Here the ttm failed to initialize but
still mgag200_mm_fini was called to unload it.

regards
sudip
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Dave Airlie <airlied@gmail.com>, David Airlie <airlied@linux.ie>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Archit Taneja <archit@ti.com>
Subject: Re: [PATCH] drm/mgag200: Fix calling drm_fb_helper_fini() twice
Date: Thu, 17 Sep 2015 16:47:40 +0530	[thread overview]
Message-ID: <20150917111740.GD20514@sudip-pc> (raw)
In-Reply-To: <55FA9BDD.7010603@codeaurora.org>

On Thu, Sep 17, 2015 at 04:24:21PM +0530, Archit Taneja wrote:
> 
> 
> On 9/17/2015 2:04 PM, Ingo Molnar wrote:
> >
> >
> >* Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> >
> >>So this patch was whitespace damaged - I applied it by hand and made the commit
> >
> >>below. This has solved the crash, thanks Archit!
> >
> >
> >
> >Spoke too soon - the attached (allyesconfig-ish) config still crashes, first there
> >
> >are a handful of kobject debug warnings, then:
> 
> The error handling in the driver is bad. The main problem is that
> the driver_load op calls mgag200_driver_unload if anything fails,
> which doesn't work well if driver_load fails mid way.
mgag200_driver_unload is trying to unload everything evenif that has not
succeeded in initializing. Here the ttm failed to initialize but
still mgag200_mm_fini was called to unload it.

regards
sudip

  reply	other threads:[~2015-09-17 11:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 11:58 [PATCH] drm/mgag200: fix memory leak Sudip Mukherjee
2015-09-07 11:58 ` Sudip Mukherjee
2015-09-13  9:36 ` Ingo Molnar
2015-09-14  8:44   ` Sudip Mukherjee
2015-09-14  8:44     ` Sudip Mukherjee
2015-09-14  9:06     ` Ingo Molnar
2015-09-14 10:04   ` Dave Airlie
2015-09-14 10:04     ` Dave Airlie
2015-09-14 10:05     ` Dave Airlie
2015-09-14 10:29       ` Sudip Mukherjee
2015-09-14 10:29         ` Sudip Mukherjee
2015-09-14 15:23       ` Archit Taneja
2015-09-14 15:23         ` Archit Taneja
2015-09-16  9:46         ` [PATCH] drm/mgag200: Fix calling drm_fb_helper_fini() twice Ingo Molnar
2015-09-16  9:46           ` Ingo Molnar
2015-09-17  8:34           ` Ingo Molnar
2015-09-17 10:54             ` Archit Taneja
2015-09-17 10:54               ` Archit Taneja
2015-09-17 11:17               ` Sudip Mukherjee [this message]
2015-09-17 11:17                 ` Sudip Mukherjee
2015-10-03 10:55               ` Ingo Molnar
2015-09-24 15:53 ` [PATCH] drm/mgag200: fix memory leak Sudip Mukherjee
2015-09-24 15:53   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917111740.GD20514@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=archit@ti.com \
    --cc=architt@codeaurora.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.