From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Olliver Schinagl <oliver+list@schinagl.nl>,
hdegoede@redhat.com, Wolfram Sang <wsa@the-dreams.de>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-sunxi@googlegroups.com, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs
Date: Tue, 29 Sep 2015 14:29:34 +0200 [thread overview]
Message-ID: <20150929122934.GQ7104@lukather> (raw)
In-Reply-To: <20150927165303.GI31209@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Sun, Sep 27, 2015 at 06:53:03PM +0200, Andrew Lunn wrote:
> > >+ if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") ||
> > >+ of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
>
> Rather than have to extend this list every so often, how about adding
> a helper of_device_is_compatible_vendor(), so you can just have:
I don't know, I kind of like the fact that it's explicit. If we ever
have another SoC coming in with a different behaviour, we won't have
to expand it back.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs
Date: Tue, 29 Sep 2015 14:29:34 +0200 [thread overview]
Message-ID: <20150929122934.GQ7104@lukather> (raw)
In-Reply-To: <20150927165303.GI31209@lunn.ch>
On Sun, Sep 27, 2015 at 06:53:03PM +0200, Andrew Lunn wrote:
> > >+ if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") ||
> > >+ of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
>
> Rather than have to extend this list every so often, how about adding
> a helper of_device_is_compatible_vendor(), so you can just have:
I don't know, I kind of like the fact that it's explicit. If we ever
have another SoC coming in with a different behaviour, we won't have
to expand it back.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150929/0e430dea/attachment.sig>
next prev parent reply other threads:[~2015-09-29 12:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 14:57 [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs Hans de Goede
2015-09-27 14:57 ` Hans de Goede
2015-09-27 16:05 ` [linux-sunxi] " Olliver Schinagl
2015-09-27 16:05 ` Olliver Schinagl
[not found] ` <560813CF.4000807-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2015-09-27 16:53 ` Andrew Lunn
2015-09-27 16:53 ` [linux-sunxi] " Andrew Lunn
2015-09-29 10:14 ` Hans de Goede
2015-09-29 10:14 ` Hans de Goede
2015-09-29 12:29 ` Maxime Ripard [this message]
2015-09-29 12:29 ` Maxime Ripard
2015-09-29 12:09 ` Maxime Ripard
2015-09-29 12:09 ` [linux-sunxi] " Maxime Ripard
2015-10-01 18:51 ` Olliver Schinagl
2015-10-01 18:51 ` [linux-sunxi] " Olliver Schinagl
[not found] ` <560D80CF.6050500-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2015-10-20 15:58 ` Wolfram Sang
2015-10-20 15:58 ` [linux-sunxi] " Wolfram Sang
2015-10-20 22:05 ` Olliver Schinagl
2015-10-20 22:05 ` [linux-sunxi] " Olliver Schinagl
2015-10-25 17:32 ` Olliver Schinagl
2015-10-25 17:32 ` [linux-sunxi] " Olliver Schinagl
[not found] ` <1443365828-8956-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-27 19:36 ` Peter Korsgaard
2015-09-27 19:36 ` [linux-sunxi] " Peter Korsgaard
2015-09-29 12:09 ` Maxime Ripard
2015-09-29 12:09 ` Maxime Ripard
2015-11-30 13:51 ` Wolfram Sang
2015-11-30 13:51 ` Wolfram Sang
2015-11-30 14:54 ` Wolfram Sang
2015-11-30 14:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929122934.GQ7104@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=oliver+list@schinagl.nl \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.