All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>, Olliver Schinagl <oliver+list@schinagl.nl>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-sunxi@googlegroups.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs
Date: Tue, 29 Sep 2015 12:14:45 +0200	[thread overview]
Message-ID: <560A6495.1000606@redhat.com> (raw)
In-Reply-To: <20150927165303.GI31209@lunn.ch>

Hi,

On 27-09-15 18:53, Andrew Lunn wrote:
> On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote:
>> Hey Hans,
>>
>> On 27-09-15 16:57, Hans de Goede wrote:
>>> According to the datasheets to n factor for dividing the tclk is
>>> 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is
>>> on other mv64xxx implementations.
>> Ah!
>
> Just to be sure, i checked Kirkwood, Armada XP and Armada 370
> datasheets. They all say n+1.

Thanks.

>>> +	if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") ||
>>> +	    of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
>
> Rather than have to extend this list every so often, how about adding
> a helper of_device_is_compatible_vendor(), so you can just have:
>
>>> +	if (of_device_is_compatible_vendor(np, "allwinner")

I agree that if such a helper would already exist it would be a good
idea to use it, but it seems overkill to just at it for this.

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs
Date: Tue, 29 Sep 2015 12:14:45 +0200	[thread overview]
Message-ID: <560A6495.1000606@redhat.com> (raw)
In-Reply-To: <20150927165303.GI31209@lunn.ch>

Hi,

On 27-09-15 18:53, Andrew Lunn wrote:
> On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote:
>> Hey Hans,
>>
>> On 27-09-15 16:57, Hans de Goede wrote:
>>> According to the datasheets to n factor for dividing the tclk is
>>> 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is
>>> on other mv64xxx implementations.
>> Ah!
>
> Just to be sure, i checked Kirkwood, Armada XP and Armada 370
> datasheets. They all say n+1.

Thanks.

>>> +	if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") ||
>>> +	    of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
>
> Rather than have to extend this list every so often, how about adding
> a helper of_device_is_compatible_vendor(), so you can just have:
>
>>> +	if (of_device_is_compatible_vendor(np, "allwinner")

I agree that if such a helper would already exist it would be a good
idea to use it, but it seems overkill to just at it for this.

Regards,

Hans

  reply	other threads:[~2015-09-29 10:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27 14:57 [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs Hans de Goede
2015-09-27 14:57 ` Hans de Goede
2015-09-27 16:05 ` [linux-sunxi] " Olliver Schinagl
2015-09-27 16:05   ` Olliver Schinagl
     [not found]   ` <560813CF.4000807-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2015-09-27 16:53     ` Andrew Lunn
2015-09-27 16:53       ` [linux-sunxi] " Andrew Lunn
2015-09-29 10:14       ` Hans de Goede [this message]
2015-09-29 10:14         ` Hans de Goede
2015-09-29 12:29       ` Maxime Ripard
2015-09-29 12:29         ` Maxime Ripard
2015-09-29 12:09     ` Maxime Ripard
2015-09-29 12:09       ` [linux-sunxi] " Maxime Ripard
2015-10-01 18:51       ` Olliver Schinagl
2015-10-01 18:51         ` [linux-sunxi] " Olliver Schinagl
     [not found]         ` <560D80CF.6050500-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2015-10-20 15:58           ` Wolfram Sang
2015-10-20 15:58             ` [linux-sunxi] " Wolfram Sang
2015-10-20 22:05             ` Olliver Schinagl
2015-10-20 22:05               ` [linux-sunxi] " Olliver Schinagl
2015-10-25 17:32             ` Olliver Schinagl
2015-10-25 17:32               ` [linux-sunxi] " Olliver Schinagl
     [not found] ` <1443365828-8956-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-27 19:36   ` Peter Korsgaard
2015-09-27 19:36     ` [linux-sunxi] " Peter Korsgaard
2015-09-29 12:09   ` Maxime Ripard
2015-09-29 12:09     ` Maxime Ripard
2015-11-30 13:51 ` Wolfram Sang
2015-11-30 13:51   ` Wolfram Sang
2015-11-30 14:54   ` Wolfram Sang
2015-11-30 14:54     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560A6495.1000606@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=oliver+list@schinagl.nl \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.