All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 03/12] net: igb: avoid using timespec
Date: Fri, 2 Oct 2015 09:47:16 +0200	[thread overview]
Message-ID: <20151002074716.GA3930@localhost.localdomain> (raw)
In-Reply-To: <1803983.ImzkvzgWES@wuerfel>

On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote:
> I tried to use this pattern whenever I convert the 64-bit 'long long'
> tv_sec member of 'struct timespec64' into a 32-bit number, to annotate
> the loss of range.

Sounds reasonable to me.
 
> I have thought about defining separate helpers like this
...
> This would make it even more explicit, but my fear was that I was
> adding too much complexity like that.

I think a cast plus a comment when needed is clear enough.

Thanks,
Richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: netdev@vger.kernel.org, y2038@lists.linaro.org,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH 03/12] net: igb: avoid using timespec
Date: Fri, 2 Oct 2015 09:47:16 +0200	[thread overview]
Message-ID: <20151002074716.GA3930@localhost.localdomain> (raw)
In-Reply-To: <1803983.ImzkvzgWES@wuerfel>

On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote:
> I tried to use this pattern whenever I convert the 64-bit 'long long'
> tv_sec member of 'struct timespec64' into a 32-bit number, to annotate
> the loss of range.

Sounds reasonable to me.
 
> I have thought about defining separate helpers like this
...
> This would make it even more explicit, but my fear was that I was
> adding too much complexity like that.

I think a cast plus a comment when needed is clear enough.

Thanks,
Richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 03/12] net: igb: avoid using timespec
Date: Fri, 2 Oct 2015 09:47:16 +0200	[thread overview]
Message-ID: <20151002074716.GA3930@localhost.localdomain> (raw)
In-Reply-To: <1803983.ImzkvzgWES@wuerfel>

On Thu, Oct 01, 2015 at 10:01:57PM +0200, Arnd Bergmann wrote:
> I tried to use this pattern whenever I convert the 64-bit 'long long'
> tv_sec member of 'struct timespec64' into a 32-bit number, to annotate
> the loss of range.

Sounds reasonable to me.
 
> I have thought about defining separate helpers like this
...
> This would make it even more explicit, but my fear was that I was
> adding too much complexity like that.

I think a cast plus a comment when needed is clear enough.

Thanks,
Richard
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038

  reply	other threads:[~2015-10-02  7:47 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 11:26 [Intel-wired-lan] [PATCH 00/12] net: assorted y2038 changes Arnd Bergmann
2015-09-30 11:26 ` Arnd Bergmann
2015-09-30 11:26 ` Arnd Bergmann
2015-09-30 11:26 ` Arnd Bergmann
2015-09-30 11:26 ` [PATCH 01/12] net: fec: avoid timespec use Arnd Bergmann
2015-10-01 19:08   ` Richard Cochran
2015-09-30 11:26 ` [PATCH 02/12] net: stmmac: avoid using timespec Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-10-01 19:08   ` Richard Cochran
2015-09-30 11:26 ` [Intel-wired-lan] [PATCH 03/12] net: igb: " Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-10-01 19:17   ` [Intel-wired-lan] " Richard Cochran
2015-10-01 19:17     ` Richard Cochran
2015-10-01 19:17     ` Richard Cochran
2015-10-01 20:01     ` [Intel-wired-lan] " Arnd Bergmann
2015-10-01 20:01       ` Arnd Bergmann
2015-10-01 20:01       ` Arnd Bergmann
2015-10-02  7:47       ` Richard Cochran [this message]
2015-10-02  7:47         ` Richard Cochran
2015-10-02  7:47         ` Richard Cochran
2015-09-30 11:26 ` [PATCH 04/12] mwifiex: use ktime_get_real for timestamping Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-10-09 11:36   ` Amitkumar Karwar
2015-09-30 11:26 ` [PATCH 05/12] mwifiex: avoid gettimeofday in ba_threshold setting Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-10-09 11:35   ` Amitkumar Karwar
2015-10-09 11:35     ` Amitkumar Karwar
2015-09-30 11:26 ` [PATCH 06/12] mac80211: use ktime_get_seconds Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-09-30 11:26 ` [PATCH 07/12] atm: hide 'struct zatm_t_hist' Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-09-30 15:24   ` Charles (Chas) Williams
2015-09-30 15:31     ` Arnd Bergmann
2015-09-30 15:31       ` Arnd Bergmann
2015-09-30 15:32     ` [PATCH v2] atm: remove " Arnd Bergmann
2015-09-30 11:26 ` [PATCH 08/12] nfnetlink: use y2038 safe timestamp Arnd Bergmann
2015-10-02 12:53   ` Pablo Neira Ayuso
2015-10-02 21:23     ` Arnd Bergmann
2015-10-02 21:23       ` Arnd Bergmann
2015-09-30 11:26 ` [PATCH 09/12] ipv6: use ktime_t for internal timestamps Arnd Bergmann
2015-09-30 11:26 ` [PATCH 10/12] net: sctp: avoid incorrect time_t use Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
2015-09-30 13:57   ` Neil Horman
2015-09-30 13:57     ` Neil Horman
2015-09-30 14:15     ` Marcelo Ricardo Leitner
2015-09-30 14:15       ` Marcelo Ricardo Leitner
2015-09-30 14:19       ` Neil Horman
2015-09-30 14:19         ` Neil Horman
2015-09-30 14:28   ` Marcelo Ricardo Leitner
2015-09-30 14:28     ` Marcelo Ricardo Leitner
2015-09-30 11:26 ` [PATCH 11/12] [RFC] ipv4: avoid timespec in timestamp computation Arnd Bergmann
2015-09-30 11:55   ` kbuild test robot
2015-09-30 12:39     ` [Y2038] " Arnd Bergmann
2015-09-30 12:58       ` [RFC v2] " Arnd Bergmann
2015-09-30 12:15   ` [RFC PATCH] ipv4: ktime_get_ms_of_day() can be static kbuild test robot
2015-09-30 12:15   ` [PATCH 11/12] [RFC] ipv4: avoid timespec in timestamp computation kbuild test robot
2015-09-30 12:15     ` kbuild test robot
2015-09-30 11:26 ` [PATCH 12/12] [RFC] can: avoid using timeval for uapi Arnd Bergmann
2015-09-30 11:26   ` Arnd Bergmann
     [not found]   ` <1443612402-3000775-13-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2015-10-05 18:51     ` Oliver Hartkopp
2015-10-05 18:51       ` Oliver Hartkopp
2015-10-06  8:32       ` Arnd Bergmann
2015-10-06  8:32         ` Arnd Bergmann
2015-10-06  9:05         ` Marc Kleine-Budde
2015-10-06  9:18           ` Arnd Bergmann
2015-10-06  9:37             ` Marc Kleine-Budde
2015-10-06  9:37               ` Marc Kleine-Budde
2015-10-05 10:17 ` [Intel-wired-lan] [PATCH 00/12] net: assorted y2038 changes David Miller
2015-10-05 10:17   ` David Miller
2015-10-05 10:17   ` David Miller
2015-10-05 10:17   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002074716.GA3930@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.