All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Alison Schofield <amsfield22@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings
Date: Tue, 6 Oct 2015 09:57:23 +0530	[thread overview]
Message-ID: <20151006042723.GB4745@sudip-pc> (raw)
In-Reply-To: <20151005213849.GA3566@Ubuntu-D830>

On Mon, Oct 05, 2015 at 02:38:49PM -0700, Alison Schofield wrote:
> On Mon, Oct 05, 2015 at 09:38:28PM +0100, Julia Lawall wrote:
> > On Mon, 5 Oct 2015, Alison Schofield wrote:
> > 
> > > This patch fixes multiple instances of the checkpatch.pl warning:
> > >
> > > WARNING: Comparisons should place the constant on the right side of the
> > > test
> > 
> > Thanks for the patch, but try to avoid using "fix" in your commit message.
> > Say instead what you have done to do the fix.  Here, you could say
> > something like "Move constant to the right side of a comparison operator,
> > as suggested by checkpatch".
> > 
> > julia
> 
> Thanks for the quick review and I will check that on future patches.
> Do I need to amend and resend this one?

I think no need to resend this one. But keep in mind what Julia said in
your next patches.

regards
sudip


  reply	other threads:[~2015-10-06  4:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 18:39 [PATCH] staging: rtl8712: fix comparison test warnings Alison Schofield
2015-10-05 20:38 ` [Outreachy kernel] " Julia Lawall
2015-10-05 21:38   ` Alison Schofield
2015-10-06  4:27     ` Sudip Mukherjee [this message]
2015-10-06  4:28       ` Julia Lawall
2015-10-06  7:53 ` Arnd Bergmann
2015-10-06 17:32   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151006042723.GB4745@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=amsfield22@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.