Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test warnings

[Alison Schofield <amsfield22@gmail.com>]

On Tue, Oct 06, 2015 at 09:53:46AM +0200, Arnd Bergmann wrote:
> On Monday 05 October 2015 11:39:35 Alison Schofield wrote:
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -140,7 +140,7 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> >  static inline void handle_group_key(struct ieee_param *param,
> >                                     struct _adapter *padapter)
> >  {
> > -       if (0 < param->u.crypt.idx &&
> > +       if (param->u.crypt.idx > 0 &&
> >             param->u.crypt.idx < 3) {
> >                 /* group key idx is 1 or 2 */
> >                 memcpy(padapter->securitypriv.XGrpKey[param->u.crypt.
> 
> this part is good.
> 
> 
> > @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
> >         if (IS_ERR(ext))
> >                 return PTR_ERR(ext);
> >  
> > -       if (0 == strcasecmp(ext, "RSSI")) {
> > +       if (strcasecmp(ext, "RSSI") == 0) {
> >                 /*Return received signal strength indicator in -db for */
> >                 /* current AP */
> >                 /*<ssid> Rssi xx */
> 
> while this and most of the other comparisons below can be further
> improved by removing the "== 0" part. You can write this as
> 
> 	if (!strcasecmp(ext, "RSSI")) {
> 
> 
> 	Arnd

Thanks & understood. v2 in the works with ! and commit msg changes.

alison