* [PATCH] Staging: most: video: Changed the return value integer to NULL @ 2015-10-07 10:14 Shivani Bhardwaj 2015-10-07 11:15 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: Shivani Bhardwaj @ 2015-10-07 10:14 UTC (permalink / raw) To: outreachy-kernel Fixed the sparse warning : Using plain integer as NULL pointer, by changing the return value of function *get_aim_dev(struct, int) from 0 to NULL. Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> --- drivers/staging/most/aim-v4l2/video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index d968791..8333245 100644 --- a/drivers/staging/most/aim-v4l2/video.c +++ b/drivers/staging/most/aim-v4l2/video.c @@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev( } } spin_unlock(&list_lock); - return 0; + return NULL; } static int aim_rx_data(struct mbo *mbo) -- 2.1.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: most: video: Changed the return value integer to NULL 2015-10-07 10:14 [PATCH] Staging: most: video: Changed the return value integer to NULL Shivani Bhardwaj @ 2015-10-07 11:15 ` Julia Lawall 2015-10-07 11:30 ` Shivani Bhardwaj 0 siblings, 1 reply; 6+ messages in thread From: Julia Lawall @ 2015-10-07 11:15 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: outreachy-kernel On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > Fixed the sparse warning : Using plain integer as NULL pointer, by > changing the return value of function *get_aim_dev(struct, int) from 0 > to NULL. If you want, you could try doing this sort of thing with Coccinelle. An easy case is the assignment case. The following would find an assignment where the type is a pointer and the value is 0: @@ type T; T *x; @@ x = - 0 + NULL This makes a rule where T is an arbitrary type and x is an expression that has type pointer to type T. Then it searches for an assignment where there is this pointer typed expression on the left side and 0 on the right side, and then makes the change. The function return case is a bit more complicated, because you have to find the function return type and the return statement, which are not right next to each other. But it can be done as well. You can find out more at the Coccinelle web site: coccinelle.lip6.fr. There are some tutorials at the papers and slides link. julia > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > --- > drivers/staging/most/aim-v4l2/video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c > index d968791..8333245 100644 > --- a/drivers/staging/most/aim-v4l2/video.c > +++ b/drivers/staging/most/aim-v4l2/video.c > @@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev( > } > } > spin_unlock(&list_lock); > - return 0; > + return NULL; > } > > static int aim_rx_data(struct mbo *mbo) > -- > 2.1.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007101433.GA50144%40ubuntu. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: most: video: Changed the return value integer to NULL 2015-10-07 11:15 ` [Outreachy kernel] " Julia Lawall @ 2015-10-07 11:30 ` Shivani Bhardwaj 2015-10-07 11:33 ` Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: Shivani Bhardwaj @ 2015-10-07 11:30 UTC (permalink / raw) To: outreachy-kernel On Wed, Oct 07, 2015 at 12:15:11PM +0100, Julia Lawall wrote: > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > > > Fixed the sparse warning : Using plain integer as NULL pointer, by > > changing the return value of function *get_aim_dev(struct, int) from 0 > > to NULL. > > If you want, you could try doing this sort of thing with Coccinelle. An > easy case is the assignment case. The following would find an assignment > where the type is a pointer and the value is 0: > > @@ > type T; > T *x; > @@ > > x = > - 0 > + NULL > > This makes a rule where T is an arbitrary type and x is an expression that > has type pointer to type T. Then it searches for an assignment where > there is this pointer typed expression on the left side and 0 on the right > side, and then makes the change. > > The function return case is a bit more complicated, because you have to > find the function return type and the return statement, which are not > right next to each other. But it can be done as well. > > You can find out more at the Coccinelle web site: coccinelle.lip6.fr. > There are some tutorials at the papers and slides link. > > julia > Thanks, Julia! Is this patch not acceptable? > > > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > > --- > > drivers/staging/most/aim-v4l2/video.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c > > index d968791..8333245 100644 > > --- a/drivers/staging/most/aim-v4l2/video.c > > +++ b/drivers/staging/most/aim-v4l2/video.c > > @@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev( > > } > > } > > spin_unlock(&list_lock); > > - return 0; > > + return NULL; > > } > > > > static int aim_rx_data(struct mbo *mbo) > > -- > > 2.1.0 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007101433.GA50144%40ubuntu. > > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: most: video: Changed the return value integer to NULL 2015-10-07 11:30 ` Shivani Bhardwaj @ 2015-10-07 11:33 ` Julia Lawall 2015-10-07 11:36 ` Shivani Bhardwaj 0 siblings, 1 reply; 6+ messages in thread From: Julia Lawall @ 2015-10-07 11:33 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: outreachy-kernel On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > On Wed, Oct 07, 2015 at 12:15:11PM +0100, Julia Lawall wrote: > > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > > > > > Fixed the sparse warning : Using plain integer as NULL pointer, by > > > changing the return value of function *get_aim_dev(struct, int) from 0 > > > to NULL. > > > > If you want, you could try doing this sort of thing with Coccinelle. An > > easy case is the assignment case. The following would find an assignment > > where the type is a pointer and the value is 0: > > > > @@ > > type T; > > T *x; > > @@ > > > > x = > > - 0 > > + NULL > > > > This makes a rule where T is an arbitrary type and x is an expression that > > has type pointer to type T. Then it searches for an assignment where > > there is this pointer typed expression on the left side and 0 on the right > > side, and then makes the change. > > > > The function return case is a bit more complicated, because you have to > > find the function return type and the return statement, which are not > > right next to each other. But it can be done as well. > > > > You can find out more at the Coccinelle web site: coccinelle.lip6.fr. > > There are some tutorials at the papers and slides link. > > > > julia > > > Thanks, Julia! Is this patch not acceptable? The patch looks fine :) It was just something else to try. julia > > > > > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > > > --- > > > drivers/staging/most/aim-v4l2/video.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c > > > index d968791..8333245 100644 > > > --- a/drivers/staging/most/aim-v4l2/video.c > > > +++ b/drivers/staging/most/aim-v4l2/video.c > > > @@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev( > > > } > > > } > > > spin_unlock(&list_lock); > > > - return 0; > > > + return NULL; > > > } > > > > > > static int aim_rx_data(struct mbo *mbo) > > > -- > > > 2.1.0 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007101433.GA50144%40ubuntu. > > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007113026.GA51614%40ubuntu. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: most: video: Changed the return value integer to NULL 2015-10-07 11:33 ` Julia Lawall @ 2015-10-07 11:36 ` Shivani Bhardwaj 2015-10-07 11:49 ` Sudip Mukherjee 0 siblings, 1 reply; 6+ messages in thread From: Shivani Bhardwaj @ 2015-10-07 11:36 UTC (permalink / raw) To: outreachy-kernel On Wed, Oct 07, 2015 at 12:33:32PM +0100, Julia Lawall wrote: > > > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > > > On Wed, Oct 07, 2015 at 12:15:11PM +0100, Julia Lawall wrote: > > > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > > > > > > > Fixed the sparse warning : Using plain integer as NULL pointer, by > > > > changing the return value of function *get_aim_dev(struct, int) from 0 > > > > to NULL. > > > > > > If you want, you could try doing this sort of thing with Coccinelle. An > > > easy case is the assignment case. The following would find an assignment > > > where the type is a pointer and the value is 0: > > > > > > @@ > > > type T; > > > T *x; > > > @@ > > > > > > x = > > > - 0 > > > + NULL > > > > > > This makes a rule where T is an arbitrary type and x is an expression that > > > has type pointer to type T. Then it searches for an assignment where > > > there is this pointer typed expression on the left side and 0 on the right > > > side, and then makes the change. > > > > > > The function return case is a bit more complicated, because you have to > > > find the function return type and the return statement, which are not > > > right next to each other. But it can be done as well. > > > > > > You can find out more at the Coccinelle web site: coccinelle.lip6.fr. > > > There are some tutorials at the papers and slides link. > > > > > > julia > > > > > Thanks, Julia! Is this patch not acceptable? > > The patch looks fine :) It was just something else to try. > > julia > OK. Thank you, Julia! :) > > > > > > > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > > > > --- > > > > drivers/staging/most/aim-v4l2/video.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c > > > > index d968791..8333245 100644 > > > > --- a/drivers/staging/most/aim-v4l2/video.c > > > > +++ b/drivers/staging/most/aim-v4l2/video.c > > > > @@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev( > > > > } > > > > } > > > > spin_unlock(&list_lock); > > > > - return 0; > > > > + return NULL; > > > > } > > > > > > > > static int aim_rx_data(struct mbo *mbo) > > > > -- > > > > 2.1.0 > > > > > > > > -- > > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007101433.GA50144%40ubuntu. > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007113026.GA51614%40ubuntu. > > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: most: video: Changed the return value integer to NULL 2015-10-07 11:36 ` Shivani Bhardwaj @ 2015-10-07 11:49 ` Sudip Mukherjee 0 siblings, 0 replies; 6+ messages in thread From: Sudip Mukherjee @ 2015-10-07 11:49 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: outreachy-kernel On Wed, Oct 07, 2015 at 05:06:02PM +0530, Shivani Bhardwaj wrote: > On Wed, Oct 07, 2015 at 12:33:32PM +0100, Julia Lawall wrote: > > > > > > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > > > > > On Wed, Oct 07, 2015 at 12:15:11PM +0100, Julia Lawall wrote: > > > > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote: > > > > <snip> > > > > > > > Thanks, Julia! Is this patch not acceptable? > > > > The patch looks fine :) It was just something else to try. > > > > julia > > > OK. Thank you, Julia! :) :( This has also been done by 9b532df0fc1e ("staging: most: return NULL instead of integer") I think you are using Linus's tree and not Greg's staging tree. regards sudip ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-07 11:49 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-07 10:14 [PATCH] Staging: most: video: Changed the return value integer to NULL Shivani Bhardwaj 2015-10-07 11:15 ` [Outreachy kernel] " Julia Lawall 2015-10-07 11:30 ` Shivani Bhardwaj 2015-10-07 11:33 ` Julia Lawall 2015-10-07 11:36 ` Shivani Bhardwaj 2015-10-07 11:49 ` Sudip Mukherjee
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.